Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 54d6a54367ed6a852b54a89f567d901f494e682a https://github.com/galaxyproject/galaxy/commit/54d6a54367ed6a852b54a89f567d9... Author: peterjc p.j.a.cock@googlemail.com Date: 2017-05-29 (Mon, 29 May 2017)
Changed paths: M lib/galaxy/jobs/runners/__init__.py M lib/galaxy/jobs/runners/drmaa.py
Log Message: ----------- Avoid locale specific string.letters for job_name
The job_name sanitation can fail if the locale specific string.letters contains unexpected characters. e.g. Saravanaraj Ayyampalayam reported getting the following under locale en_US.iso885915
Traceback (most recent call last): File /.../galaxy-dist/lib/galaxy/jobs/runners/drmaa.py, line 397, in <genexpr> job_name = ''.join( x if x in ( string.letters + string.digits + '_' ) else '_' for x in job_name ) UnicodeDecodeError: 'ascii' codec can't decode byte 0xa6 in position 52: ordinal not in range(128)
See http://dev.list.galaxyproject.org/Issue-with-job-name-UnicodeDecodeError-in-... or https://lists.galaxyproject.org/pipermail/galaxy-dev/2017-May/025687.html
The downside of this proposed change would be to mask reasonable non ASCII letters from the job name on a well defined system with consistent locale settings for both Galaxy and the Cluster. But ASCII only seems safer.
Commit: aa7d701cbc7674a13a4db30fce333e81558b2fea https://github.com/galaxyproject/galaxy/commit/aa7d701cbc7674a13a4db30fce333... Author: Martin Cech marten@bx.psu.edu Date: 2017-05-29 (Mon, 29 May 2017)
Changed paths: M lib/galaxy/jobs/runners/__init__.py M lib/galaxy/jobs/runners/drmaa.py
Log Message: ----------- Merge pull request #4121 from peterjc/locales_string_letters
Avoid locale specific string.letters for job_name
Compare: https://github.com/galaxyproject/galaxy/compare/64d6ffd59dee...aa7d701cbc76