1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/7d278a17747a/ changeset: 7d278a17747a user: carlfeberhard date: 2012-11-21 20:02:58 summary: history panel: documenting fix to show display and edit attributes buttons for HDA in the error state. affected #: 2 files
diff -r 8481560e2c3287a75f85e3a05e59b50b18bcd634 -r 7d278a17747ad9cb35b1af5ec011e46f814c339a static/scripts/mvc/dataset/hda-base.js --- a/static/scripts/mvc/dataset/hda-base.js +++ b/static/scripts/mvc/dataset/hda-base.js @@ -181,7 +181,8 @@ * @returns {jQuery} rendered DOM */ _render_displayButton : function(){ - // don't show display if not in ready state, error'd, or not accessible + // don't show display if not in ready state or not accessible + // DO show if in error (ala previous history panel) if( ( !this.model.inReadyState() ) //|| ( this.model.get( 'state' ) === HistoryDatasetAssociation.STATES.ERROR ) || ( this.model.get( 'state' ) === HistoryDatasetAssociation.STATES.NOT_VIEWABLE )
diff -r 8481560e2c3287a75f85e3a05e59b50b18bcd634 -r 7d278a17747ad9cb35b1af5ec011e46f814c339a static/scripts/mvc/dataset/hda-edit.js --- a/static/scripts/mvc/dataset/hda-edit.js +++ b/static/scripts/mvc/dataset/hda-edit.js @@ -64,8 +64,8 @@ * @returns {jQuery} rendered DOM */ _render_editButton : function(){ - // don't show edit while uploading - //TODO??: error? + // don't show edit while uploading, in-accessible + // DO show if in error (ala previous history panel) //TODO??: not viewable/accessible are essentially the same (not viewable set from accessible) if( ( this.model.get( 'state' ) === HistoryDatasetAssociation.STATES.UPLOAD ) //|| ( this.model.get( 'state' ) === HistoryDatasetAssociation.STATES.ERROR )
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.