Hi,
I'm trying to use the built-in cleanup scripts (instead of my own), came across a possible bug:
1. When running "delete_datasets.sh", the "info_only" flag is ignored. This is evident by running it twice with "-i" and getting different results (the second time - no datasets are deleted).
2. When running "purge_datasets.sh" with the "info_only" flag, no information is printed at all, making it impossible to know what would be purged without the "-i" flag. The only way to see what is purged is actually purging the datasets (kind of defeats the purpose of "info only").
I think the attached patch fixes both issues.
3. The relevant wiki page (https://bitbucket.org/galaxy/galaxy-central/wiki/Config/PurgeHistoriesAndDat...) says about "delete_datasets.sh": "The purge_datasets.sh script will need to be run afterwards to remove the base datasets from disk."
But the example on the wiki page (and in the script) has "-r" - so the files are actually deleted from the disk by "delete_datasets.sh".
Does one still need to run "purge_datasets.sh" if used "-r" with "delete_datasets.sh" ?
4. If I accidentally run "purge_datasets.sh" without "-r" = is there a way to delete the stale files ? if not, perhaps the script should require either "-i" or "-r" to avoid such cases (or provide another cleanup script?)
comments are welcomed, -gordon