I have pushed your patch along with a fix for the ext problem into galaxy-central. I don't think the fix will modifies the behavior in such a way that your implementation will be affected but let me know if I have broken something.
Overall, this seems like a solid change to me - thanks for the contribution.
On Wed, Nov 27, 2013 at 10:37 AM, Peter Cock firstname.lastname@example.org wrote:
On Wed, Nov 27, 2013 at 4:23 PM, John Chilton email@example.com wrote:
It looks like ext will be undefined in your default implementation of _archive_main_file - is this going to cause an error or am I missing something?
Whoops, yes - I was primarily testing the subclassed version.
If this is the interface you would like - I could rework it to handle this ext issue and apply it directly to galaxy-central. Otherwise, I will await a pull request.
Thanks for working on this!
This interface is flexible enough for my immediate itch (altering the default HTML file and its naming), but could be more open ended. I was fishing for feedback on this.
If we leave this with the methods having leading underscores, then it is clear this is a private API and open to change at short notice - so committing it as it shouldn't pin us down to future improvements (although it would leave using it in the BLAST datatype definition a little shaky).