Patch: show User menu's history and dataset options show independent of app.config.use_remote_user setting
It's not much, but we're using a remote_user setup and the History and Datasets menu items were not showing up under the User menu, which didn't seem to be by design. Attached is a micro patch to the template, which is also available here: http://bitbucket.org/Ry4an/galaxy-umn-msi-changes/src/tip/always-show-users-... Also, What's the preferred patch submission mechanism? Patchbomb? Bitbucket pull-request? Thanks, -- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu
Ry4an Brase wrote:
It's not much, but we're using a remote_user setup and the History and Datasets menu items were not showing up under the User menu, which didn't seem to be by design. Attached is a micro patch to the template, which is also available here:
http://bitbucket.org/Ry4an/galaxy-umn-msi-changes/src/tip/always-show-users-...
Hi Ry4an, Thanks, we'll add this shortly.
Also, What's the preferred patch submission mechanism? Patchbomb? Bitbucket pull-request?
No preference, any patch mailed or linked to on the dev list will be seen.
Thanks,
------------------------------------------------------------------------
_______________________________________________ galaxy-dev mailing list galaxy-dev@lists.bx.psu.edu http://lists.bx.psu.edu/listinfo/galaxy-dev
Just a quick re-ping on this one. It still applies cleanly, but I'm happy to rebase if desired. On Tue, Mar 23, 2010 at 04:08:15PM -0500, Ry4an Brase wrote:
It's not much, but we're using a remote_user setup and the History and Datasets menu items were not showing up under the User menu, which didn't seem to be by design. Attached is a micro patch to the template, which is also available here:
http://bitbucket.org/Ry4an/galaxy-umn-msi-changes/src/tip/always-show-users-...
Also, What's the preferred patch submission mechanism? Patchbomb? Bitbucket pull-request?
Thanks,
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu
# HG changeset patch # User JJ <jj@msi.umn.edu> # Date 1269360929 18000 # Node ID 3424869fd91cfe435e7d46ebca7f1ef94ccbee70 # Parent bc2e61c2dac16e6eb37d34f3d3d6dee013b14368 Made User menu's history and dataset options show independent of app.config.use_remote_user setting.
diff -r bc2e61c2dac1 -r 3424869fd91c templates/base_panels.mako --- a/templates/base_panels.mako Tue Mar 23 15:43:58 2010 -0400 +++ b/templates/base_panels.mako Tue Mar 23 11:15:29 2010 -0500 @@ -269,12 +269,12 @@ logout_url = h.url_for( controller='/user', action='logout' ) %> <li><a target="${logout_target}" href="${logout_url}">Logout</a></li> - <li><hr style="color: inherit; background-color: gray"/></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> - %if app.config.get_bool( 'enable_pages', False ): - <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> - %endif + %endif + <li><hr style="color: inherit; background-color: gray"/></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> + %if app.config.get_bool( 'enable_pages', False ): + <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> %endif </ul> </div>
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu
Still looks good. We'll get it into galaxy-central in the next day or two. Thanks, J. On Mar 29, 2010, at 2:51 PM, Ry4an Brase wrote:
Just a quick re-ping on this one. It still applies cleanly, but I'm happy to rebase if desired.
On Tue, Mar 23, 2010 at 04:08:15PM -0500, Ry4an Brase wrote:
It's not much, but we're using a remote_user setup and the History and Datasets menu items were not showing up under the User menu, which didn't seem to be by design. Attached is a micro patch to the template, which is also available here:
http://bitbucket.org/Ry4an/galaxy-umn-msi-changes/src/tip/always-show-users-...
Also, What's the preferred patch submission mechanism? Patchbomb? Bitbucket pull-request?
Thanks,
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu
# HG changeset patch # User JJ <jj@msi.umn.edu> # Date 1269360929 18000 # Node ID 3424869fd91cfe435e7d46ebca7f1ef94ccbee70 # Parent bc2e61c2dac16e6eb37d34f3d3d6dee013b14368 Made User menu's history and dataset options show independent of app.config.use_remote_user setting.
diff -r bc2e61c2dac1 -r 3424869fd91c templates/base_panels.mako --- a/templates/base_panels.mako Tue Mar 23 15:43:58 2010 -0400 +++ b/templates/base_panels.mako Tue Mar 23 11:15:29 2010 -0500 @@ -269,12 +269,12 @@ logout_url = h.url_for( controller='/user', action='logout' ) %> <li><a target="${logout_target}" href="${logout_url}">Logout</a></li> - <li><hr style="color: inherit; background-color: gray"/></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> - %if app.config.get_bool( 'enable_pages', False ): - <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> - %endif + %endif + <li><hr style="color: inherit; background-color: gray"/></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> + %if app.config.get_bool( 'enable_pages', False ): + <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> %endif </ul> </div>
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu <ry4an-umn-msi-always-show-users-history-datasets.patch>_______________________________________________ galaxy-dev mailing list galaxy-dev@lists.bx.psu.edu http://lists.bx.psu.edu/listinfo/galaxy-dev
Patch is changeset 3582:feff604427ee in galaxy-central Thanks, J. On Tue, Mar 30, 2010 at 3:33 PM, Jeremy Goecks <jeremy.goecks@emory.edu>wrote:
Still looks good. We'll get it into galaxy-central in the next day or two.
Thanks, J.
On Mar 29, 2010, at 2:51 PM, Ry4an Brase wrote:
Just a quick re-ping on this one. It still applies cleanly, but I'm happy to rebase if desired.
On Tue, Mar 23, 2010 at 04:08:15PM -0500, Ry4an Brase wrote:
It's not much, but we're using a remote_user setup and the History and Datasets menu items were not showing up under the User menu, which didn't seem to be by design. Attached is a micro patch to the template, which is also available here:
http://bitbucket.org/Ry4an/galaxy-umn-msi-changes/src/tip/always-show-users-...
Also, What's the preferred patch submission mechanism? Patchbomb? Bitbucket pull-request?
Thanks,
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research
# HG changeset patch # User JJ <jj@msi.umn.edu> # Date 1269360929 18000 # Node ID 3424869fd91cfe435e7d46ebca7f1ef94ccbee70 # Parent bc2e61c2dac16e6eb37d34f3d3d6dee013b14368 Made User menu's history and dataset options show independent of app.config.use_remote_user setting.
diff -r bc2e61c2dac1 -r 3424869fd91c templates/base_panels.mako --- a/templates/base_panels.mako Tue Mar 23 15:43:58 2010 -0400 +++ b/templates/base_panels.mako Tue Mar 23 11:15:29 2010 -0500 @@ -269,12 +269,12 @@ logout_url = h.url_for( controller='/user', action='logout' ) %> <li><a target="${logout_target}" href="${logout_url}">Logout</a></li> - <li><hr style="color: inherit; background-color: gray"/></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> - <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> - %if app.config.get_bool( 'enable_pages', False ): - <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> - %endif + %endif + <li><hr style="color: inherit; background-color: gray"/></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/history', action='list' )}">Histories</a></li> + <li><a target="galaxy_main" href="${h.url_for( controller='/dataset', action='list' )}">Datasets</a></li> + %if app.config.get_bool( 'enable_pages', False ): + <li><a href="${h.url_for( controller='/page', action='list' )}">Pages</a></li> %endif </ul> </div>
-- Ry4an Brase 612-626-6575 University of Minnesota Supercomputing Institute for Advanced Computational Research http://www.msi.umn.edu
<ry4an-umn-msi-always-show-users-history-datasets.patch>_______________________________________________
galaxy-dev mailing list galaxy-dev@lists.bx.psu.edu http://lists.bx.psu.edu/listinfo/galaxy-dev
_______________________________________________ galaxy-dev mailing list galaxy-dev@lists.bx.psu.edu http://lists.bx.psu.edu/listinfo/galaxy-dev
participants (3)
-
Jeremy Goecks -
Nate Coraor -
Ry4an Brase