- galaxy-commits - lists.galaxyproject.org

galaxy-dist commit 56431b214df1: Don't 'use strict' as FF4 beta doesn't support it
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User Kanwei Li <kanwei(a)gmail.com> # Date 1289944688 18000 # Node ID 56431b214df16653a966b96bf399c7646da267b8 # Parent 394d8186f666b506cd0a93aefb7a079e0c9ec59b Don't 'use strict' as FF4 beta doesn't support it --- a/static/scripts/jquery.jstore.js +++ b/static/scripts/jquery.jstore.js @@ -15,7 +15,7 @@ * http://creativecommons.org/licenses/by/3.0/us */ -"use strict"; +//"use strict"; /*global Class, window, jQuery, ActiveXObject, google */ --- a/static/scripts/class.js +++ b/static/scripts/class.js @@ -5,7 +5,7 @@ * Inspired by base2 and Prototype */ -"use strict"; +//"use strict"; (function () { --- a/static/scripts/packed/jquery.jstore.js +++ b/static/scripts/packed/jquery.jstore.js @@ -14,4 +14,4 @@ * Licensed under the Creative Commons Attribution 3.0 United States License: * http://creativecommons.org/licenses/by/3.0/us */ -"use strict";(function(i,n){var h="JSTORE_ENGINE_UNSTABLE",t="JSTORE_UNKNOWN_ENGINE_REQUESTED",r="JSTORE_ENGINE_NAMESPACE_COLLISION",j="JSTORE_RESOURCE_NAMESPACE_COLLISION",m="JSTORE_ENGINE_UNAVAILABLE",o="JSTORE_INVALID_FLAVOR",f=(function(){try{return new RegExp('^("(\\\\.|[^"\\\\\\n\\r])*?"|[,:{}\\[\\]0-9.\\-+Eaeflnr-u \\n\\r\\t])+?$')}catch(I){return(/^(true|false|null|\[.*\]|\{.*\}|".*"|\d+|\d+\.\d+)$/)}}()),b="jstore-html5-local",y="jstore-html5-sql",F="jstore-flash",G="jstore-google-gears",A="jstore-msie",u,E={},D={},C={},c=false,d={},q={project:undefined,flash:"jStore.Flash.html",json:"browser.json.js"},l;function z(I){switch(I){case b:case y:case F:case G:case A:return true;default:return false}}function g(I,J){return !I?false:I.constructor.toString().match(new RegExp(J+"\$\$","i"))!==null}function s(K,I,J){if(g(K,"Function")){return K.apply(I||E,g(J,"Array")?J:[J])}}function p(J,I){i.ajax({url:J,complete:I||i.noop(),type:"GET",dataType:"script",cache:false})}func tion x(I){if(I===undefined){return""}if(g(I,"Object")||g(I,"Array")||g(I,"Function")){return JSON.stringify(I)}return I}function k(I){return f.test(I)?JSON.parse(I):I}function w(I){return I.replace(/^\s+|\s+$/g,"")}function e(I,J,K){if(!z(I)){throw o}if(K[I]!==undefined){throw r}if(s(K)===true){E.available[I]=true;J.flavor=I;D[I]=u.extend(J)}else{E.available[I]=false;E.enginePriority=i.map(E.enginePriority,function(L){if(L===I){return null}else{return L}})}}function v(){if(E.isReady){return}if((c&&E.isFlashReady)||!c){E.isReady=true;E.trigger("jstore-ready",[C[l]])}}function a(){E.create(E.enginePriority[0],undefined,"best-fit")}function H(){try{var J=new ActiveXObject("ShockwaveFlash.ShockwaveFlash.6");try{J.AllowScriptAccess="always"}catch(L){return"6,0,0"}return new ActiveXObject("ShockwaveFlash.ShockwaveFlash").GetVariable("$version").replace(/\D+/g,",").match(/^,?(.+),?$/)[1]}catch(K){try{if(navigator.mimeTypes["application/x-shockwave-flash"].enabledPlugin){return(navi gator.plugins["Shockwave Flash 2.0"]||navigator.plugins["Shockwave Flash"]).description.replace(/\D+/g,",").match(/^,?(.+),?$/)[1]}}catch(I){}}return"0,0,0"}function B(I){var N=H().match(/\d+/g),L=I.match(/\d+/g),J=0,K,M;for(;J<3;J++){K=parseInt(N[J],10);M=parseInt(L[J],10);if(K<M){return false}else{if(K>M){return true}}}return true}i.extend(E,{enginePriority:[b,y,F,A],available:{},isReady:false,isFlashReady:false,flavors:{local:b,sql:y,flash:F,gears:G,msie:A},init:function(J,K,I){i.extend(q,{project:J},K);i(function(){if(n.JSON===undefined){p(q.json)}if(I!==undefined){E.create(I,J,"default")}else{a()}});return E},create:function(I,M,J){M=M||q.project||location.hostname.replace(/\./g,"-")||"unknown";if(!z(I)){throw o}if(D[I]===undefined){throw m}var L=(J!==undefined?J+".":"")+M+"."+I,K;if(C[L]!==undefined){throw j}K=C[L]=new D[I](M,L);K.ready(function(){E.trigger("jstore-engine-ready",[K])});if(I===F&&!E.isFlashReady){if(l===undefined){c=true}n.jstore_ready=function(){E.isFl ashReady=true;E.trigger("flash-ready");if(l===undefined){v()}n.flash_ready=undefined};n.jstore_error=function(N){E.trigger("jstore-error",["JSTORE_FLASH_EXCEPTION",null,N])};i('<iframe style="height:1px;width:1px;position:absolute;left:0;top:0;margin-left:-100px;" id="jStoreFlashFrame" src="'+q.flash+'"></iframe>').appendTo("body")}else{if(l===undefined){l=L;v()}}return K},engine:function(I){return C[I]},activeEngine:function(I){if(I!==undefined){if(C[I]===undefined){throw t}else{l=I}}return C[l]},bind:function(J,K,I){I=I||"jstore";if(d[I]===undefined){d[I]={}}if(d[I][J]===undefined){d[I][J]=[K]}else{d[I][J].push(K)}return E},trigger:function(K,J,I){I=I||"jstore";if(d[I]!==undefined){if(d[I][K]!==undefined){i.each(d[I][K],function(){s(this,E,J)})}}return E},error:function(I){E.bind("jstore-error",I)},ready:function(I){if(E.isReady){s(I)}else{E.bind("jstore-ready",I)}return E},engineReady:function(I){if(E.isReady){s(I)}else{E.bind("jstore-engine-ready",I)}return E},store:func tion(I,J){return J===undefined?E.get(I):E.set(I,J)},remove:function(I){return E.activeEngine().remove(I)},get:function(I){return E.activeEngine().get(I)},set:function(I,J){return E.activeEngine().set(I,J)}});u=Class.extend({project:undefined,jri:undefined,flavor:undefined,database:undefined,data:undefined,limit:undefined,isReady:undefined,init:function(J,I){this.project=J;this.jri=I;this.data={};this.isReady=false;this.updateCache()},updateCache:function(){this.isReady=true;this.trigger("engine-ready",[this])},bind:function(I,J){E.bind(I,J,this.jri)},trigger:function(J,I){E.trigger(J,I,this.jri)},ready:function(I){if(this.isReady){s(I,this)}else{this.bind("engine-ready",I)}},get:function(I){this.__interruptAccess();return this.data[I]},set:function(I,J){this.__interruptAccess();I=w(I);try{this.__set(I,J)}catch(K){E.trigger("jstore-error",["JSTORE_STORAGE_FAILURE",this.jri,K])}this.data[I]=J;return J},remove:function(J){this.__interruptAccess();J=w(J);try{this.__remove(J)}cat ch(K){E.trigger("jstore-error",["JSTORE_REMOVE_FAILURE",this.jri,K])}var I=this.data[J];this.data[J]=undefined;return I},__interruptAccess:function(){if(!this.isReady){throw h}},__set:function(I,J){return},__remove:function(I){return}});i.extend(i.fn,{store:function(I,J){if(J===undefined){E.get(I)}else{E.set(I,J)}return this},removeStore:function(I){E.activeEngine().remove(I);return this},getStore:function(I){return E.activeEngine().get(I)},setStore:function(I,J){E.activeEngine().set(I,J);return this}});n.jStore=i.jStore=E;e(b,{limit:parseInt(500000,16),init:function(J,I){this.database=n.globalStorage===undefined?n.localStorage:n.globalStorage[location.hostname];this._super(J,I)},updateCache:function(){var J,K;for(J in this.database){var I=false;if(this.database.hasOwnProperty){if(this.database.hasOwnProperty(J)){I=true}}else{if(this.database.getItem(J)!==null){I=true}}if(I){K=this.database.getItem(J);this.data[J]=k(K&&K.value?K.value:K)}}this._super()},__set:function(I,J){t his.database.setItem(I,x(J))},__remove:function(I){this.database.removeItem(I)}},function(){return n.localStorage!==undefined||n.globalStorage!==undefined});e(y,{limit:parseInt(32000,16),init:function(J,I){this.database=n.openDatabase("jstore-"+J,"1.0",J,this.limit);if(!this.database){throw"JSTORE_SQL_NO_DB"}this.database.transaction(function(K){K.executeSql("CREATE TABLE IF NOT EXISTS jstore (k TEXT UNIQUE NOT NULL PRIMARY KEY, v TEXT NOT NULL)")});this._super(J,I)},updateCache:function(){var I=this,J=this._super;this.database.transaction(function(K){K.executeSql("SELECT k,v FROM jstore",[],function(O,L){var N=L.rows,M=0,P;for(;M<N.length;++M){P=N.item(M);I.data[P.k]=k(P.v)}J.apply(I)})})},__set:function(I,J){this.database.transaction(function(K){K.executeSql("INSERT OR REPLACE INTO jstore(k, v) VALUES (?, ?)",[I,x(J)])})},__remove:function(I){this.database.transaction(function(J){J.executeSql("DELETE FROM jstore WHERE k = ?",[I])})}},function(){return n.openDatabase!==unde fined});e(F,{limit:-1,init:function(K,J){var I=this;E.bind("flash-ready",function(){I.__flashReadyListener()});this._super(K,J)},updateCache:function(I){if(I===true){var J,K=this.database.jstore_get_all();for(J in K){if(K.hasOwnProperty(J)){this.data[J]=k(this.database.jstore_get(J))}}this._super()}},__set:function(I,J){if(!this.database.jstore_set(I,x(J))){E.trigger("jstore-error",["JSTORE_STORAGE_FAILURE",this.jri,"Flash Exception"])}},__remove:function(I){this.database.jstore_remove(I)},__flashReadyListener:function(){var I=i("#jStoreFlashFrame")[0],J;if(I.Document!==undefined&&g(I.Document.jStoreFlash.jstore_get,"Function")){this.database=I.Document.jStoreFlash}else{if(I.contentWindow&&I.contentWindow.document){J=i(I.contentWindow.document);if(g(i("object",J)[0].jstore_get,"Function")){this.database=i("object",J)[0]}else{if(g(i("embed",J)[0].jstore_get,"Function")){this.database=i("embed",J)[0]}}}}if(this.database===undefined){throw"JSTORE_FLASH_REFERENCE_ISSUE"}else{thi s.updateCache(true)}}},function(){return B("9.0.0")});e(G,{limit:-1,init:function(J,I){this.database=google.gears.factory.create("beta.database");this.database.open("jstore-"+J);this.database.execute("CREATE TABLE IF NOT EXISTS jstore (k TEXT UNIQUE NOT NULL PRIMARY KEY, v TEXT NOT NULL)");this._super(J,I)},updateCache:function(){var I=this.database.execute("SELECT k,v FROM jstore");while(I.isValidRow()){this.data[I.field(0)]=k(I.field(1));I.next()}I.close();this._super()},__set:function(I,J){this.database.execute("BEGIN");this.database.execute("INSERT OR REPLACE INTO jstore(k, v) VALUES (?, ?)",[I,x(J)]);this.database.execute("COMMIT")},__remove:function(I){this.database.execute("BEGIN");this.database.execute("DELETE FROM jstore WHERE k = ?",[I]);this.database.execute("COMMIT")}},function(){return n.google!==undefined&&n.google.gears!==undefined});e(A,{limit:parseInt(10000,16),init:function(J,I){this.database=i('<div style="display:none;behavior:url(\'#default#userData\')" id="jstore-'+J+'"></div>').appendTo(document.body).get(0);this._super(J,I)},updateCache:function(){this.database.load(this.project);var K=document.getElementById("jstore-"+this.project),L=K.XMLDocument,I,J=0;if(L&&L.documentElement&&L.documentElement.attributes){I=L.documentElement;for(;J<I.attributes.length;++J){this.data[I.attributes.item(J).nodeName]=k(I.attributes.item(J).nodeValue)}}this._super()},__set:function(I,J){this.database.setAttribute(I,x(J));this.database.save(this.project)},__remove:function(I){this.database.removeAttribute(I);this.database.save(this.project)}},function(){return n.ActiveXObject!==undefined})}(jQuery,window)); +(function(i,n){var h="JSTORE_ENGINE_UNSTABLE",t="JSTORE_UNKNOWN_ENGINE_REQUESTED",r="JSTORE_ENGINE_NAMESPACE_COLLISION",j="JSTORE_RESOURCE_NAMESPACE_COLLISION",m="JSTORE_ENGINE_UNAVAILABLE",o="JSTORE_INVALID_FLAVOR",f=(function(){try{return new RegExp('^("(\\\\.|[^"\\\\\\n\\r])*?"|[,:{}\\[\\]0-9.\\-+Eaeflnr-u \\n\\r\\t])+?$')}catch(I){return(/^(true|false|null|\[.*\]|\{.*\}|".*"|\d+|\d+\.\d+)$/)}}()),b="jstore-html5-local",y="jstore-html5-sql",F="jstore-flash",G="jstore-google-gears",A="jstore-msie",u,E={},D={},C={},c=false,d={},q={project:undefined,flash:"jStore.Flash.html",json:"browser.json.js"},l;function z(I){switch(I){case b:case y:case F:case G:case A:return true;default:return false}}function g(I,J){return !I?false:I.constructor.toString().match(new RegExp(J+"\$\$","i"))!==null}function s(K,I,J){if(g(K,"Function")){return K.apply(I||E,g(J,"Array")?J:[J])}}function p(J,I){i.ajax({url:J,complete:I||i.noop(),type:"GET",dataType:"script",cache:false})}function x(I){if( I===undefined){return""}if(g(I,"Object")||g(I,"Array")||g(I,"Function")){return JSON.stringify(I)}return I}function k(I){return f.test(I)?JSON.parse(I):I}function w(I){return I.replace(/^\s+|\s+$/g,"")}function e(I,J,K){if(!z(I)){throw o}if(K[I]!==undefined){throw r}if(s(K)===true){E.available[I]=true;J.flavor=I;D[I]=u.extend(J)}else{E.available[I]=false;E.enginePriority=i.map(E.enginePriority,function(L){if(L===I){return null}else{return L}})}}function v(){if(E.isReady){return}if((c&&E.isFlashReady)||!c){E.isReady=true;E.trigger("jstore-ready",[C[l]])}}function a(){E.create(E.enginePriority[0],undefined,"best-fit")}function H(){try{var J=new ActiveXObject("ShockwaveFlash.ShockwaveFlash.6");try{J.AllowScriptAccess="always"}catch(L){return"6,0,0"}return new ActiveXObject("ShockwaveFlash.ShockwaveFlash").GetVariable("$version").replace(/\D+/g,",").match(/^,?(.+),?$/)[1]}catch(K){try{if(navigator.mimeTypes["application/x-shockwave-flash"].enabledPlugin){return(navigator.plugins ["Shockwave Flash 2.0"]||navigator.plugins["Shockwave Flash"]).description.replace(/\D+/g,",").match(/^,?(.+),?$/)[1]}}catch(I){}}return"0,0,0"}function B(I){var N=H().match(/\d+/g),L=I.match(/\d+/g),J=0,K,M;for(;J<3;J++){K=parseInt(N[J],10);M=parseInt(L[J],10);if(K<M){return false}else{if(K>M){return true}}}return true}i.extend(E,{enginePriority:[b,y,F,A],available:{},isReady:false,isFlashReady:false,flavors:{local:b,sql:y,flash:F,gears:G,msie:A},init:function(J,K,I){i.extend(q,{project:J},K);i(function(){if(n.JSON===undefined){p(q.json)}if(I!==undefined){E.create(I,J,"default")}else{a()}});return E},create:function(I,M,J){M=M||q.project||location.hostname.replace(/\./g,"-")||"unknown";if(!z(I)){throw o}if(D[I]===undefined){throw m}var L=(J!==undefined?J+".":"")+M+"."+I,K;if(C[L]!==undefined){throw j}K=C[L]=new D[I](M,L);K.ready(function(){E.trigger("jstore-engine-ready",[K])});if(I===F&&!E.isFlashReady){if(l===undefined){c=true}n.jstore_ready=function(){E.isFlashReady=true ;E.trigger("flash-ready");if(l===undefined){v()}n.flash_ready=undefined};n.jstore_error=function(N){E.trigger("jstore-error",["JSTORE_FLASH_EXCEPTION",null,N])};i('<iframe style="height:1px;width:1px;position:absolute;left:0;top:0;margin-left:-100px;" id="jStoreFlashFrame" src="'+q.flash+'"></iframe>').appendTo("body")}else{if(l===undefined){l=L;v()}}return K},engine:function(I){return C[I]},activeEngine:function(I){if(I!==undefined){if(C[I]===undefined){throw t}else{l=I}}return C[l]},bind:function(J,K,I){I=I||"jstore";if(d[I]===undefined){d[I]={}}if(d[I][J]===undefined){d[I][J]=[K]}else{d[I][J].push(K)}return E},trigger:function(K,J,I){I=I||"jstore";if(d[I]!==undefined){if(d[I][K]!==undefined){i.each(d[I][K],function(){s(this,E,J)})}}return E},error:function(I){E.bind("jstore-error",I)},ready:function(I){if(E.isReady){s(I)}else{E.bind("jstore-ready",I)}return E},engineReady:function(I){if(E.isReady){s(I)}else{E.bind("jstore-engine-ready",I)}return E},store:function(I,J){ret urn J===undefined?E.get(I):E.set(I,J)},remove:function(I){return E.activeEngine().remove(I)},get:function(I){return E.activeEngine().get(I)},set:function(I,J){return E.activeEngine().set(I,J)}});u=Class.extend({project:undefined,jri:undefined,flavor:undefined,database:undefined,data:undefined,limit:undefined,isReady:undefined,init:function(J,I){this.project=J;this.jri=I;this.data={};this.isReady=false;this.updateCache()},updateCache:function(){this.isReady=true;this.trigger("engine-ready",[this])},bind:function(I,J){E.bind(I,J,this.jri)},trigger:function(J,I){E.trigger(J,I,this.jri)},ready:function(I){if(this.isReady){s(I,this)}else{this.bind("engine-ready",I)}},get:function(I){this.__interruptAccess();return this.data[I]},set:function(I,J){this.__interruptAccess();I=w(I);try{this.__set(I,J)}catch(K){E.trigger("jstore-error",["JSTORE_STORAGE_FAILURE",this.jri,K])}this.data[I]=J;return J},remove:function(J){this.__interruptAccess();J=w(J);try{this.__remove(J)}catch(K){E.trigg er("jstore-error",["JSTORE_REMOVE_FAILURE",this.jri,K])}var I=this.data[J];this.data[J]=undefined;return I},__interruptAccess:function(){if(!this.isReady){throw h}},__set:function(I,J){return},__remove:function(I){return}});i.extend(i.fn,{store:function(I,J){if(J===undefined){E.get(I)}else{E.set(I,J)}return this},removeStore:function(I){E.activeEngine().remove(I);return this},getStore:function(I){return E.activeEngine().get(I)},setStore:function(I,J){E.activeEngine().set(I,J);return this}});n.jStore=i.jStore=E;e(b,{limit:parseInt(500000,16),init:function(J,I){this.database=n.globalStorage===undefined?n.localStorage:n.globalStorage[location.hostname];this._super(J,I)},updateCache:function(){var J,K;for(J in this.database){var I=false;if(this.database.hasOwnProperty){if(this.database.hasOwnProperty(J)){I=true}}else{if(this.database.getItem(J)!==null){I=true}}if(I){K=this.database.getItem(J);this.data[J]=k(K&&K.value?K.value:K)}}this._super()},__set:function(I,J){this.database. setItem(I,x(J))},__remove:function(I){this.database.removeItem(I)}},function(){return n.localStorage!==undefined||n.globalStorage!==undefined});e(y,{limit:parseInt(32000,16),init:function(J,I){this.database=n.openDatabase("jstore-"+J,"1.0",J,this.limit);if(!this.database){throw"JSTORE_SQL_NO_DB"}this.database.transaction(function(K){K.executeSql("CREATE TABLE IF NOT EXISTS jstore (k TEXT UNIQUE NOT NULL PRIMARY KEY, v TEXT NOT NULL)")});this._super(J,I)},updateCache:function(){var I=this,J=this._super;this.database.transaction(function(K){K.executeSql("SELECT k,v FROM jstore",[],function(O,L){var N=L.rows,M=0,P;for(;M<N.length;++M){P=N.item(M);I.data[P.k]=k(P.v)}J.apply(I)})})},__set:function(I,J){this.database.transaction(function(K){K.executeSql("INSERT OR REPLACE INTO jstore(k, v) VALUES (?, ?)",[I,x(J)])})},__remove:function(I){this.database.transaction(function(J){J.executeSql("DELETE FROM jstore WHERE k = ?",[I])})}},function(){return n.openDatabase!==undefined});e(F,{ limit:-1,init:function(K,J){var I=this;E.bind("flash-ready",function(){I.__flashReadyListener()});this._super(K,J)},updateCache:function(I){if(I===true){var J,K=this.database.jstore_get_all();for(J in K){if(K.hasOwnProperty(J)){this.data[J]=k(this.database.jstore_get(J))}}this._super()}},__set:function(I,J){if(!this.database.jstore_set(I,x(J))){E.trigger("jstore-error",["JSTORE_STORAGE_FAILURE",this.jri,"Flash Exception"])}},__remove:function(I){this.database.jstore_remove(I)},__flashReadyListener:function(){var I=i("#jStoreFlashFrame")[0],J;if(I.Document!==undefined&&g(I.Document.jStoreFlash.jstore_get,"Function")){this.database=I.Document.jStoreFlash}else{if(I.contentWindow&&I.contentWindow.document){J=i(I.contentWindow.document);if(g(i("object",J)[0].jstore_get,"Function")){this.database=i("object",J)[0]}else{if(g(i("embed",J)[0].jstore_get,"Function")){this.database=i("embed",J)[0]}}}}if(this.database===undefined){throw"JSTORE_FLASH_REFERENCE_ISSUE"}else{this.updateCache (true)}}},function(){return B("9.0.0")});e(G,{limit:-1,init:function(J,I){this.database=google.gears.factory.create("beta.database");this.database.open("jstore-"+J);this.database.execute("CREATE TABLE IF NOT EXISTS jstore (k TEXT UNIQUE NOT NULL PRIMARY KEY, v TEXT NOT NULL)");this._super(J,I)},updateCache:function(){var I=this.database.execute("SELECT k,v FROM jstore");while(I.isValidRow()){this.data[I.field(0)]=k(I.field(1));I.next()}I.close();this._super()},__set:function(I,J){this.database.execute("BEGIN");this.database.execute("INSERT OR REPLACE INTO jstore(k, v) VALUES (?, ?)",[I,x(J)]);this.database.execute("COMMIT")},__remove:function(I){this.database.execute("BEGIN");this.database.execute("DELETE FROM jstore WHERE k = ?",[I]);this.database.execute("COMMIT")}},function(){return n.google!==undefined&&n.google.gears!==undefined});e(A,{limit:parseInt(10000,16),init:function(J,I){this.database=i('<div style="display:none;behavior:url(\'#default#userData\')" id="jstore-'+ J+'"></div>').appendTo(document.body).get(0);this._super(J,I)},updateCache:function(){this.database.load(this.project);var K=document.getElementById("jstore-"+this.project),L=K.XMLDocument,I,J=0;if(L&&L.documentElement&&L.documentElement.attributes){I=L.documentElement;for(;J<I.attributes.length;++J){this.data[I.attributes.item(J).nodeName]=k(I.attributes.item(J).nodeValue)}}this._super()},__set:function(I,J){this.database.setAttribute(I,x(J));this.database.save(this.project)},__remove:function(I){this.database.removeAttribute(I);this.database.save(this.project)}},function(){return n.ActiveXObject!==undefined})}(jQuery,window)); --- a/static/scripts/packed/class.js +++ b/static/scripts/packed/class.js @@ -4,4 +4,4 @@ * Copyright (c) 2008 John Resig (http://ejohn.org/blog/simple-javascript-inheritance/) * Inspired by base2 and Prototype */ -"use strict";(function(){var a=false,b=/xyz/.test(function(){xyz})?/\b_super\b/:/.*/;this.Class=function(){};Class.extend=function(g){var f=this.prototype;a=true;var e=new this();a=false;for(var d in g){e[d]=(typeof g[d]==="function"&&typeof f[d]==="function"&&b.test(g[d])?(function(h,i){return function(){var k=this._super;this._super=f[h];var j=i.apply(this,arguments);this._super=k;return j}}(d,g[d])):g[d])}function c(){if(!a&&this.init){this.init.apply(this,arguments)}}c.prototype=e;c.constructor=c;c.extend=arguments.callee;return c}}()); +(function(){var a=false,b=/xyz/.test(function(){xyz})?/\b_super\b/:/.*/;this.Class=function(){};Class.extend=function(g){var f=this.prototype;a=true;var e=new this();a=false;for(var d in g){e[d]=(typeof g[d]==="function"&&typeof f[d]==="function"&&b.test(g[d])?(function(h,i){return function(){var k=this._super;this._super=f[h];var j=i.apply(this,arguments);this._super=k;return j}}(d,g[d])):g[d])}function c(){if(!a&&this.init){this.init.apply(this,arguments)}}c.prototype=e;c.constructor=c;c.extend=arguments.callee;return c}}());

1 0

galaxy-dist commit 7bded9108bd8: More miscellaneous Sample Tracking cleanup and bug fixes, move supported form_builder field types from form_builder.BaseField to Request.model and Sample.model.
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User Greg Von Kuster <greg(a)bx.psu.edu> # Date 1290007512 18000 # Node ID 7bded9108bd8297ea609e9ec06bbe516b5f0b83a # Parent a68c74ec8cfbc641db4b6fe424e3f77b9f3c5d3c More miscellaneous Sample Tracking cleanup and bug fixes, move supported form_builder field types from form_builder.BaseField to Request.model and Sample.model. --- a/templates/admin/requests/edit_request_type.mako +++ b/templates/admin/requests/edit_request_type.mako @@ -28,7 +28,7 @@ </div><div class="form-row"><label> - Sequencing Request Form definition: + Sequencing request form definition: </label><select name="form_id"> %for form in forms: @@ -42,7 +42,7 @@ </div><div class="form-row"><label> - Sample Form definition: + Sample form definition: </label><select name="form_id"> %for form in forms: --- a/lib/galaxy/web/form_builder.py +++ b/lib/galaxy/web/form_builder.py @@ -18,12 +18,6 @@ class BaseField(object): return ' disabled="disabled"' else: return '' - @staticmethod - def form_field_types(): - return ['TextField', 'TextArea', 'SelectField', 'CheckboxField', 'AddressField', 'WorkflowField'] - @staticmethod - def sample_field_types(): - return ['TextField', 'SelectField', 'CheckboxField', 'WorkflowField'] class TextField(BaseField): """ @@ -559,8 +553,8 @@ class AddressField(BaseField): self.select_address.add_option( 'Add a new address', 'new' ) return self.select_address.get_html( disabled=disabled ) + address_html -class WorkflowField(BaseField): - def __init__(self, name, user=None, value=None, params=None): +class WorkflowField( BaseField ): + def __init__( self, name, user=None, value=None, params=None ): self.name = name self.user = user self.value = value @@ -580,7 +574,7 @@ class WorkflowField(BaseField): else: self.select_workflow.add_option( a.name, str( a.id ) ) return self.select_workflow.get_html( disabled=disabled ) - + def get_suite(): """Get unittest suite for this module""" import doctest, sys @@ -592,11 +586,11 @@ def build_select_field( trans, objs, lab selected_value='none', refresh_on_change=False, multiple=False, display=None, size=None ): """ Build a SelectField given a set of objects. The received params are: - - objs: the set of object used to populate the option list + - objs: the set of objects used to populate the option list - label_attr: the attribute of each obj (e.g., name, email, etc ) whose value is used to populate each option label. If the string 'self' is passed as label_attr, each obj in objs is assumed to be a string, so the obj itself is used - select_field_name: the name of the SelectField - - initial_value: the vlaue of the first option in the SelectField - allows for an option telling the user to select something + - initial_value: the value of the first option in the SelectField - allows for an option telling the user to select something - selected_value: the value of the currently selected option - refresh_on_change: True if the SelectField should perform a refresh_on_change """ --- a/templates/admin/requests/view_request_type.mako +++ b/templates/admin/requests/view_request_type.mako @@ -38,7 +38,7 @@ <div style="clear: both"></div></div><div class="form-row"> - <label>Sequencing Request form definition</label> + <label>Sequencing request form definition</label> ${request_type.request_form.name} </div><div class="form-row"> --- a/lib/galaxy/model/__init__.py +++ b/lib/galaxy/model/__init__.py @@ -1495,12 +1495,11 @@ class MetadataFile( object ): class FormDefinition( object ): # The following form_builder classes are supported by the FormDefinition class. - # AddressField, CheckboxField, SelectField, TextArea, TextField, WorkflowField supported_field_types = [ AddressField, CheckboxField, SelectField, TextArea, TextField, WorkflowField ] types = Bunch( REQUEST = 'Sequencing Request Form', SAMPLE = 'Sequencing Sample Form', LIBRARY_INFO_TEMPLATE = 'Library information template', - USER_INFO = 'User Information' ) + USER_INFO = 'User Information' ) def __init__( self, name=None, desc=None, fields=[], form_definition_current=None, form_type=None, layout=None ): self.name = name self.desc = desc @@ -1792,6 +1791,8 @@ class RequestTypePermissions( object ): self.role = role class Sample( object ): + # The following form_builder classes are supported by the Sample class. + supported_field_types = [ CheckboxField, SelectField, TextField, WorkflowField ] bulk_operations = Bunch( CHANGE_STATE = 'Change state', SELECT_LIBRARY = 'Select data library and folder' ) api_collection_visible_keys = ( 'id', 'name' ) --- a/lib/galaxy/web/controllers/requests_common.py +++ b/lib/galaxy/web/controllers/requests_common.py @@ -588,12 +588,8 @@ class RequestsCommon( BaseController, Us request = trans.sa_session.query( trans.model.Request ).get( trans.security.decode_id( request_id ) ) except: return invalid_id_redirect( trans, cntrller, request_id ) - events_list = [] - for event in request.events: - events_list.append( ( event.state, time_ago( event.update_time ), event.comment ) ) return trans.fill_template( '/requests/common/view_request_history.mako', cntrller=cntrller, - events_list=events_list, request=request ) @web.expose @web.require_login( "edit email notification settings" ) @@ -777,7 +773,7 @@ class RequestsCommon( BaseController, Us search_box=search_box ) @web.expose @web.require_login( "sample events" ) - def sample_events( self, trans, cntrller, **kwd ): + def view_sample_history( self, trans, cntrller, **kwd ): params = util.Params( kwd ) status = params.get( 'status', 'done' ) message = util.restore_text( params.get( 'message', '' ) ) @@ -786,15 +782,8 @@ class RequestsCommon( BaseController, Us sample = trans.sa_session.query( trans.model.Sample ).get( trans.security.decode_id( sample_id ) ) except: return invalid_id_redirect( trans, cntrller, sample_id ) - events_list = [] - for event in sample.events: - events_list.append( ( event.state.name, - event.state.desc, - time_ago( event.update_time ), - event.comment ) ) - return trans.fill_template( '/requests/common/sample_events.mako', + return trans.fill_template( '/requests/common/view_sample_history.mako', cntrller=cntrller, - events_list=events_list, sample=sample ) @web.expose @web.require_login( "add sample" ) @@ -1054,9 +1043,9 @@ class RequestsCommon( BaseController, Us # selected sets of samples. If samples are selected, the sample_operation param # will have a value other than 'none', and the samples param will be a list of # encoded sample ids. There are currently only 2 multi-select operations; - # 'Change state' and 'Select data library and folder'. If sample_operation is - # 'none, then the samples param will be a list of sample objects. - if sample_operation == 'Change state': + # model.Sample.bulk_operations.CHANGE_STATE and model.sample.bulk_operations.SELECT_LIBRARY. + # If sample_operation is 'none, then the samples param will be a list of sample objects. + if sample_operation == trans.model.Sample.bulk_operations.CHANGE_STATE: sample_state_id = params.get( 'sample_state_id', None ) if sample_state_id in [ None, 'none' ]: message = "Select a new state from the <b>Change current state</b> list before clicking the <b>Save</b> button." @@ -1090,7 +1079,7 @@ class RequestsCommon( BaseController, Us cntrller=cntrller, action='update_request_state', request_id=trans.security.encode_id( request.id ) ) ) - elif sample_operation == 'Select data library and folder': + elif sample_operation == trans.model.sample.bulk_operations.SELECT_LIBRARY: # TODO: fix the code so that the sample_operation_select_field does not use # sample_0_library_id as it's name. it should use something like sample_operation_library_id # and sample_operation_folder_id because the name sample_0_library_id should belong to the --- a/lib/galaxy/web/controllers/forms.py +++ b/lib/galaxy/web/controllers/forms.py @@ -64,12 +64,12 @@ class FormsGrid( grids.Grid ): ] class Forms( BaseController ): - # Empty form field + # Empty TextField empty_field = { 'label': '', 'helptext': '', 'visible': True, 'required': False, - 'type': BaseField.form_field_types()[0], + 'type': model.TextField.__name__, 'selectlist': [], 'layout': 'none', 'default': '' } @@ -597,12 +597,12 @@ class Forms( BaseController ): self.selectbox_options = [] # if the form is for defining samples, then use the sample field types # which does not include TextArea & AddressField - if form_type == trans.app.model.FormDefinition.types.SAMPLE: - for ft in BaseField.sample_field_types(): - self.fieldtype.add_option(ft, ft) + if form_type == trans.model.FormDefinition.types.SAMPLE: + for ft in trans.model.Sample.supported_field_types: + self.fieldtype.add_option( ft.__name__, ft.__name__ ) else: - for ft in BaseField.form_field_types(): - self.fieldtype.add_option(ft, ft) + for ft in trans.model.Request.supported_field_types: + self.fieldtype.add_option( ft.__name__, ft__name__ ) self.required = SelectField('field_required_'+str(index), display='radio') self.required.add_option('Required', 'required') self.required.add_option('Optional', 'optional', selected=True) @@ -632,22 +632,22 @@ class Forms( BaseController ): field[ 'selectlist' ] = ['', ''] # if the form is for defining samples, then use the sample field types # which does not include TextArea & AddressField - if form_type == trans.app.model.FormDefinition.types.SAMPLE: - for ft in BaseField.sample_field_types(): - if ft == field['type']: - self.fieldtype.add_option(ft, ft, selected=True) + if form_type == trans.model.FormDefinition.types.SAMPLE: + for ft in trans.model.Sample.supported_field_types: + if ft.__name__ == field[ 'type' ]: + self.fieldtype.add_option( ft.__name__, ft__name__, selected=True ) if ft == 'SelectField': - self.selectbox_ui(field) + self.selectbox_ui( field ) else: - self.fieldtype.add_option(ft, ft) + self.fieldtype.add_option( ft.__name__, ft.__name__ ) else: - for ft in BaseField.form_field_types(): - if ft == field['type']: - self.fieldtype.add_option(ft, ft, selected=True) + for ft in trans.model.Request.supported_field_types: + if ft.__name__ == field[ 'type' ]: + self.fieldtype.add_option( ft.__name__, ft.__name__, selected=True ) if ft == 'SelectField': - self.selectbox_ui(field) + self.selectbox_ui( field ) else: - self.fieldtype.add_option(ft, ft) + self.fieldtype.add_option( ft.__name__, ft.__name__ ) # required/optional if field['required'] == 'required': self.required = SelectField('field_required_'+str(self.index), display='radio') --- a/templates/admin/requests/create_request_type.mako +++ b/templates/admin/requests/create_request_type.mako @@ -39,7 +39,7 @@ <div style="clear: both"></div></div> %endfor - <div class="toolFormTitle">Possible sample states</div> + <div class="toolFormTitle">Sample states</div> %if len(rt_states_widgets): %for index, info in enumerate(rt_states_widgets): ${render_state( index, info[0], info[1] )} --- a/templates/requests/common/common.mako +++ b/templates/requests/common/common.mako @@ -160,7 +160,7 @@ %if is_unsubmitted: <td>Unsubmitted</td> %else: - <td valign="top"><a href="${h.url_for( controller='requests_common', action='sample_events', cntrller=cntrller, sample_id=trans.security.encode_id( sample.id ) )}">${sample.state.name}</a></td> + <td valign="top"><a href="${h.url_for( controller='requests_common', action='view_sample_history', cntrller=cntrller, sample_id=trans.security.encode_id( sample.id ) )}">${sample.state.name}</a></td> %endif %else: <td></td> @@ -334,7 +334,7 @@ %if is_unsubmitted: <td>Unsubmitted</td> %else: - <td><a id="sampleState-${sample.id}" href="${h.url_for( controller='requests_common', action='sample_events', cntrller=cntrller, sample_id=trans.security.encode_id( sample.id ) )}">${render_sample_state( sample )}</a></td> + <td><a id="sampleState-${sample.id}" href="${h.url_for( controller='requests_common', action='view_sample_history', cntrller=cntrller, sample_id=trans.security.encode_id( sample.id ) )}">${render_sample_state( sample )}</a></td> %endif %if sample_widget_library and library_cntrller is not None: <td><a href="${h.url_for( controller='library_common', action='browse_library', cntrller=library_cntrller, id=trans.security.encode_id( sample_widget_library.id ) )}">${sample_widget_library.name}</a></td> --- a/test/base/twilltestcase.py +++ b/test/base/twilltestcase.py @@ -1536,7 +1536,7 @@ class TwillTestCase( unittest.TestCase ) self.visit_url( "%s/requests_common/view_request_history?cntrller=%s&id=%s" % ( self.url, cntrller, request_id ) ) self.check_page( strings_displayed, strings_displayed_count, strings_not_displayed ) def view_sample_history( self, cntrller, sample_id, strings_displayed=[], strings_displayed_count=[], strings_not_displayed=[] ): - self.visit_url( "%s/requests_common/sample_events?cntrller=%s&sample_id=%s" % ( self.url, cntrller, sample_id ) ) + self.visit_url( "%s/requests_common/view_sample_history?cntrller=%s&sample_id=%s" % ( self.url, cntrller, sample_id ) ) self.check_page( strings_displayed, strings_displayed_count, strings_not_displayed ) def edit_basic_request_info( self, cntrller, request_id, name, new_name='', new_desc='', new_fields=[], strings_displayed=[], strings_displayed_after_submit=[] ): --- a/templates/requests/common/edit_basic_request_info.mako +++ b/templates/requests/common/edit_basic_request_info.mako @@ -8,7 +8,6 @@ is_unsubmitted = request.is_unsubmitted can_add_samples = is_unsubmitted can_reject = is_admin and is_submitted - can_select_datasets = is_admin and ( is_complete or is_submitted ) can_submit_request = request.samples and is_unsubmitted %> @@ -24,9 +23,6 @@ %if can_reject: <a class="action-button" href="${h.url_for( controller='requests_admin', action='reject_request', cntrller=cntrller, id=trans.security.encode_id( request.id ) )}">Reject this request</a> %endif - %if can_select_datasets: - <a class="action-button" href="${h.url_for( controller='requests_admin', action='select_datasets_to_transfer', request_id=trans.security.encode_id( request.id ) )}">Select datasets to transfer</a> - %endif </div></ul> --- /dev/null +++ b/templates/requests/common/view_sample_history.mako @@ -0,0 +1,38 @@ +<%inherit file="/base.mako"/> +<%namespace file="/message.mako" import="render_msg" /> + +<% from galaxy.web.framework.helpers import time_ago %> + +<br/><br/> +<ul class="manage-table-actions"> + <li><a class="action-button" href="${h.url_for( controller='requests_common', action='view_request', cntrller=cntrller, id=trans.security.encode_id( sample.request.id ) )}">Browse this request</a></li> +</ul> + +%if message: + ${render_msg( message, status )} +%endif + +<h3>History of sample "${sample.name}"</h3> + +<div class="toolForm"> + <table class="grid"> + <thead> + <tr> + <th>State</th> + <th>Description</th> + <th>Last Updated</th> + <th>Comments</th> + </tr> + </thead> + <tbody> + %for event in sample.events: + <tr> + <td><b>${event.state.name}</b></td> + <td>${event.state.desc}</td> + <td>${time_ago( event.update_time )}</td> + <td>${event.comment}</td> + </tr> + %endfor + </tbody> + </table> +</div> --- a/lib/galaxy/config.py +++ b/lib/galaxy/config.py @@ -44,8 +44,6 @@ class Configuration( object ): # web API self.enable_api = string_as_bool( kwargs.get( 'enable_api', False ) ) self.enable_openid = string_as_bool( kwargs.get( 'enable_openid', False ) ) - # Communication with a sequencer - self.enable_sequencer_communication = string_as_bool( kwargs.get( 'enable_sequencer_communication', False ) ) # dataset Track files self.track_store_path = kwargs.get( "track_store_path", "${extra_files_path}/tracks") self.tool_path = resolve_path( kwargs.get( "tool_path", "tools" ), self.root ) --- a/templates/requests/common/view_request_history.mako +++ b/templates/requests/common/view_request_history.mako @@ -2,6 +2,8 @@ <%namespace file="/message.mako" import="render_msg" /><% + from galaxy.web.framework.helpers import time_ago + is_admin = cntrller == 'requests_admin' and trans.user_is_admin() is_complete = request.is_complete is_submitted = request.is_submitted @@ -41,16 +43,16 @@ <thead><tr><th>State</th> - <th>Last Update</th> + <th>Last Updated</th><th>Comments</th></tr></thead><tbody> - %for state, updated, comments in events_list: - <tr class="libraryRow libraryOrFolderRow" id="libraryRow"> - <td><b><a>${state}</a></b></td> - <td><a>${updated}</a></td> - <td><a>${comments}</a></td> + %for event in request.events: + <tr> + <td><b>${event.state}</b></td> + <td>${time_ago( event.update_time )}</td> + <td>${event.comment}</td></tr> %endfor </tbody> --- a/templates/requests/common/sample_events.mako +++ /dev/null @@ -1,44 +0,0 @@ -<%inherit file="/base.mako"/> -<%namespace file="/message.mako" import="render_msg" /> - -<%def name="title()">Events for Sample ${sample.name}</%def> - -<h2>Events for Sample "${sample.name}"</h2> -<ul class="manage-table-actions"> - <li><a class="action-button" href="${h.url_for( controller='requests_common', action='view_request', cntrller=cntrller, id=trans.security.encode_id( sample.request.id ) )}">Browse this request</a></li> -</ul> -<h3>Sequencing Request "${sample.request.name}"</h3> - -%if message: - ${render_msg( message, status )} -%endif - -<div class="toolForm"> - <div class="form-row"> - <div class="toolParamHelp" style="clear: both;"> - <b>Possible states: </b> - <% states = " > ".join([ ss.name for ss in sample.request.type.states ]) %> - ${states} - </div> - </div> - <table class="grid"> - <thead> - <tr> - <th>State</th> - <th>Description</th> - <th>Last Update</th> - <th>Comments</th> - </tr> - </thead> - <tbody> - %for state, desc, updated, comments in events_list: - <tr class="libraryRow libraryOrFolderRow" id="libraryRow"> - <td><b><a>${state}</a></b></td> - <td><a>${desc}</a></td> - <td><a>${updated}</a></td> - <td><a>${comments}</a></td> - </tr> - %endfor - </tbody> - </table> -</div>

1 0

galaxy-dist commit 918a25ed14f5: Bug fix due to my last commit - Requests do not have supported_field_types, FormDefinitions do.
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User Greg Von Kuster <greg(a)bx.psu.edu> # Date 1290008781 18000 # Node ID 918a25ed14f5427f70970b0c436159fc58fd111e # Parent 7bded9108bd8297ea609e9ec06bbe516b5f0b83a Bug fix due to my last commit - Requests do not have supported_field_types, FormDefinitions do. --- a/lib/galaxy/web/controllers/forms.py +++ b/lib/galaxy/web/controllers/forms.py @@ -601,7 +601,7 @@ class Forms( BaseController ): for ft in trans.model.Sample.supported_field_types: self.fieldtype.add_option( ft.__name__, ft.__name__ ) else: - for ft in trans.model.Request.supported_field_types: + for ft in trans.model.FormDefinition.supported_field_types: self.fieldtype.add_option( ft.__name__, ft__name__ ) self.required = SelectField('field_required_'+str(index), display='radio') self.required.add_option('Required', 'required') @@ -641,7 +641,7 @@ class Forms( BaseController ): else: self.fieldtype.add_option( ft.__name__, ft.__name__ ) else: - for ft in trans.model.Request.supported_field_types: + for ft in trans.model.FormDefinition.supported_field_types: if ft.__name__ == field[ 'type' ]: self.fieldtype.add_option( ft.__name__, ft.__name__, selected=True ) if ft == 'SelectField':

1 0

galaxy-dist commit 2e2ee0289d67: Fix BLAST+ regression from changeset 535d276c92bc (loc file columns)
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1289925107 0 # Node ID 2e2ee0289d67d244954aa05bfe315dbb5ff413eb # Parent d2d0c199c20ddf942e1e2587dc9aede8acd9cebc Fix BLAST+ regression from changeset 535d276c92bc (loc file columns) --- a/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml @@ -40,10 +40,13 @@ blastn </param><when value="db"><param name="database" type="select" label="Nucleotide BLAST database"> -  + <options from_file="blastdb.loc"> - <column name="name" index="2"/> - <column name="value" index="0"/> + <column name="name" index="1"/> + <column name="value" index="2"/></options></param><param name="subject" type="hidden" value="" /> --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -41,10 +41,13 @@ blastp </param><when value="db"><param name="database" type="select" label="Protein BLAST database"> -  + <options from_file="blastdb_p.loc"> - <column name="name" index="2"/> - <column name="value" index="0"/> + <column name="name" index="1"/> + <column name="value" index="2"/></options></param><param name="subject" type="hidden" value="" /> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -39,10 +39,13 @@ tblastx </param><when value="db"><param name="database" type="select" label="Nucleotide BLAST database"> -  + <options from_file="blastdb.loc"> - <column name="name" index="2"/> - <column name="value" index="0"/> + <column name="name" index="1"/> + <column name="value" index="2"/></options></param><param name="subject" type="hidden" value="" /> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -40,10 +40,13 @@ blastx </param><when value="db"><param name="database" type="select" label="Protein BLAST database"> -  + <options from_file="blastdb_p.loc"> - <column name="name" index="2"/> - <column name="value" index="0"/> + <column name="name" index="1"/> + <column name="value" index="2"/></options></param><param name="subject" type="hidden" value="" /> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -40,10 +40,13 @@ tblastn </param><when value="db"><param name="database" type="select" label="Nucleotide BLAST database"> -  + <options from_file="blastdb.loc"> - <column name="name" index="2"/> - <column name="value" index="0"/> + <column name="name" index="1"/> + <column name="value" index="2"/></options></param><param name="subject" type="hidden" value="" />

1 0

galaxy-dist commit 394d8186f666: tool_form: Make radio and select box labels explicitly inline. Workflow: add colons after parameter names where appropriate. Fixes #419
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User Kanwei Li <kanwei(a)gmail.com> # Date 1289929775 18000 # Node ID 394d8186f666b506cd0a93aefb7a079e0c9ec59b # Parent 1bf064c8ab88621dd58890f6cd56ad4900d10d6b tool_form: Make radio and select box labels explicitly inline. Workflow: add colons after parameter names where appropriate. Fixes #419 --- a/static/june_2007_style/base.css.tmpl +++ b/static/june_2007_style/base.css.tmpl @@ -210,6 +210,10 @@ div.form-row label { margin-bottom: .2em; } +div.form-row label.inline { + display: inline; +} + div.form-row-input { float: left; } --- a/templates/workflow/editor_tool_form.mako +++ b/templates/workflow/editor_tool_form.mako @@ -7,8 +7,8 @@ from galaxy.util.expressions import Expr <% ctx = ExpressionContext( values, ctx ) %> %for input_index, input in enumerate( inputs.itervalues() ): %if input.type == "repeat": - <div class="repeat-group"> - <div class="form-title-row"><b>${input.title_plural}</b></div> + <div class="repeat-group form-row"> + <label>${input.title_plural}:</label><% repeat_values = values[input.name] %> %for i in range( len( repeat_values ) ): <% @@ -19,7 +19,7 @@ from galaxy.util.expressions import Expr index = repeat_values[i]['__index__'] %><div class="repeat-group-item"> - <div class="form-title-row"><b>${input.title} ${i + 1}</b></div> + <div class="form-title-row"><label>${input.title} ${i + 1}</label></div> ${do_inputs( input.inputs, repeat_values[ i ], rep_errors, prefix + input.name + "_" + str(index) + "|", ctx )} <div class="form-row"><input type="submit" name="${prefix}${input.name}_${index}_remove" value="Remove ${input.title} ${i+1}"></div></div> @@ -63,7 +63,7 @@ from galaxy.util.expressions import Expr %else: %if isinstance( value, RuntimeValue ): <label> - ${param.get_label()} + ${param.get_label()}: <span class="popupmenu"><button type="submit" name="make_buildtime" value="${prefix}${param.name}">Set in advance</button></span> @@ -73,7 +73,7 @@ from galaxy.util.expressions import Expr </div> %else: <label> - ${param.get_label()} + ${param.get_label()}: %if allow_runtime: <span class="popupmenu"><button type="submit" name="make_runtime" value="${prefix}${param.name}">Set at runtime</button> --- a/lib/galaxy/web/form_builder.py +++ b/lib/galaxy/web/form_builder.py @@ -248,16 +248,16 @@ class SelectField(BaseField): >>> t.add_option( "tuti", 1 ) >>> t.add_option( "fruity", "x" ) >>> print t.get_html() - <div><input type="radio" name="foo" value="1" id="foo|1"><label for="foo|1">tuti</label></div> - <div><input type="radio" name="foo" value="x" id="foo|x"><label for="foo|x">fruity</label></div> + <div><input type="radio" name="foo" value="1" id="foo|1"><label class="inline" for="foo|1">tuti</label></div> + <div><input type="radio" name="foo" value="x" id="foo|x"><label class="inline" for="foo|x">fruity</label></div> >>> t = SelectField( "bar", multiple=True, display="checkboxes" ) >>> t.add_option( "automatic", 3 ) >>> t.add_option( "bazooty", 4, selected=True ) >>> print t.get_html() <div class="checkUncheckAllPlaceholder" checkbox_name="bar"></div> - <div><input type="checkbox" name="bar" value="3" id="bar|3"><label for="bar|3">automatic</label></div> - <div><input type="checkbox" name="bar" value="4" id="bar|4" checked='checked'><label for="bar|4">bazooty</label></div> + <div><input type="checkbox" name="bar" value="3" id="bar|3"><label class="inline" for="bar|3">automatic</label></div> + <div><input type="checkbox" name="bar" value="4" id="bar|4" checked='checked'><label class="inline" for="bar|4">bazooty</label></div> """ def __init__( self, name, multiple=None, display=None, refresh_on_change=False, refresh_on_change_values=[], size=None ): self.name = name @@ -302,7 +302,7 @@ class SelectField(BaseField): selected_text = "" if selected: selected_text = " checked='checked'" - rval.append( '<div%s><input type="checkbox" name="%s%s" value="%s" id="%s"%s%s><label for="%s">%s</label></div>' % \ + rval.append( '<div%s><input type="checkbox" name="%s%s" value="%s" id="%s"%s%s><label class="inline" for="%s">%s</label></div>' % \ ( style, prefix, self.name, escaped_value, uniq_id, selected_text, self.get_disabled_str( disabled ), uniq_id, text ) ) ctr += 1 return "\n".join( rval ) @@ -318,7 +318,7 @@ class SelectField(BaseField): selected_text = "" if selected: selected_text = " checked='checked'" - rval.append( '<div%s><input type="radio" name="%s%s"%s value="%s" id="%s"%s%s><label for="%s">%s</label></div>' % \ + rval.append( '<div%s><input type="radio" name="%s%s"%s value="%s" id="%s"%s%s><label class="inline" for="%s">%s</label></div>' % \ ( style, prefix, self.name, --- a/static/june_2007_style/blue/base.css +++ b/static/june_2007_style/blue/base.css @@ -39,6 +39,7 @@ div.form-title-row{padding:5px 10px;} div.repeat-group-item{border-left:solid #d8b365 5px;margin-left:10px;margin-bottom:10px;} div.form-row-error{background:#FFCCCC;} div.form-row label{font-weight:bold;display:block;margin-bottom:.2em;} +div.form-row label.inline{display:inline;} div.form-row-input{float:left;} div.form-row-input label{font-weight:normal;display:inline;} div.form-row-error-message{width:300px;float:left;color:red;font-weight:bold;padding:3px 0 0 1em;} --- a/lib/galaxy/tools/parameters/basic.py +++ b/lib/galaxy/tools/parameters/basic.py @@ -515,14 +515,14 @@ class SelectToolParameter( ToolParameter blah >>> print p.get_html() <div class="checkUncheckAllPlaceholder" checkbox_name="blah"></div> - <div><input type="checkbox" name="blah" value="x" id="blah|x"><label for="blah|x">I am X</label></div> - <div class="odd_row"><input type="checkbox" name="blah" value="y" id="blah|y" checked='checked'><label for="blah|y">I am Y</label></div> - <div><input type="checkbox" name="blah" value="z" id="blah|z" checked='checked'><label for="blah|z">I am Z</label></div> + <div><input type="checkbox" name="blah" value="x" id="blah|x"><label class="inline" for="blah|x">I am X</label></div> + <div class="odd_row"><input type="checkbox" name="blah" value="y" id="blah|y" checked='checked'><label class="inline" for="blah|y">I am Y</label></div> + <div><input type="checkbox" name="blah" value="z" id="blah|z" checked='checked'><label class="inline" for="blah|z">I am Z</label></div> >>> print p.get_html( value=["x","y"]) <div class="checkUncheckAllPlaceholder" checkbox_name="blah"></div> - <div><input type="checkbox" name="blah" value="x" id="blah|x" checked='checked'><label for="blah|x">I am X</label></div> - <div class="odd_row"><input type="checkbox" name="blah" value="y" id="blah|y" checked='checked'><label for="blah|y">I am Y</label></div> - <div><input type="checkbox" name="blah" value="z" id="blah|z"><label for="blah|z">I am Z</label></div> + <div><input type="checkbox" name="blah" value="x" id="blah|x" checked='checked'><label class="inline" for="blah|x">I am X</label></div> + <div class="odd_row"><input type="checkbox" name="blah" value="y" id="blah|y" checked='checked'><label class="inline" for="blah|y">I am Y</label></div> + <div><input type="checkbox" name="blah" value="z" id="blah|z"><label class="inline" for="blah|z">I am Z</label></div> >>> print p.to_param_dict_string( ["y", "z"] ) y,z """

1 0

galaxy-dist commit 02f6c9dae26e: Data libraries: Fix 'import from current history' showing metadata files that are not visible. Also fix this same issue for 'Copy history items' feature. Do this by adding new 'visible_datasets' mapping property for HDAs. Checkbox labels for both features can now be clicked.
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User Kanwei Li <kanwei(a)gmail.com> # Date 1289852143 18000 # Node ID 02f6c9dae26e9aef40a44bc151ed07b457715839 # Parent 0505090dbbe610741cacd7a9a1c2e79b8cc9ea5c Data libraries: Fix 'import from current history' showing metadata files that are not visible. Also fix this same issue for 'Copy history items' feature. Do this by adding new 'visible_datasets' mapping property for HDAs. Checkbox labels for both features can now be clicked. --- a/templates/root/index.mako +++ b/templates/root/index.mako @@ -40,7 +40,7 @@ "Show Hidden Datasets": function() { galaxy_history.location = "${h.url_for( controller='root', action='history', show_hidden=True)}"; }, - "Show structure": function() { + "Show Structure": function() { galaxy_main.location = "${h.url_for( controller='history', action='display_structured' )}"; }, "Export to File": function() { --- a/templates/library/common/common.mako +++ b/templates/library/common/common.mako @@ -427,14 +427,11 @@ <input type="hidden" name="upload_option" value="import_from_history"/><input type="hidden" name="ldda_message" value="${ldda_message}"/><% + role_ids_selected = '' if roles_select_list: - role_ids_selected = roles_select_list.get_selected( return_value=True, multi=True ) - if role_ids_selected: - role_ids_selected = ','.join( role_ids_selected ) - else: - role_ids_selected = '' - else: - role_ids_selected = '' + selected = roles_select_list.get_selected( return_value=True, multi=True ) + if selected: + role_ids_selected = ','.join( selected ) %><input type="hidden" name="roles" value="${role_ids_selected}"/> %if replace_dataset not in [ None, 'None' ]: @@ -450,9 +447,11 @@ ${render_template_field( field, render_as_hidden=True )} %endfor %endif - %for hda in history.active_datasets: + %for hda in history.visible_datasets: + <% encoded_id = trans.security.encode_id( hda.id ) %><div class="form-row"> - <input name="hda_ids" value="${trans.security.encode_id( hda.id )}" type="checkbox"/>${hda.hid}: ${hda.name} + <input name="hda_ids" id="hist_${encoded_id}" value="${encoded_id}" type="checkbox"/> + <label for="hist_${encoded_id}" style="display: inline;font-weight:normal;">${hda.hid}: ${hda.name}</label></div> %endfor <div class="form-row"> @@ -460,9 +459,7 @@ </div></form> %else: - <p/> - Your current history is empty - <p/> + <p>Your current history is empty</p> %endif </div></div> --- a/templates/dataset/copy_view.mako +++ b/templates/dataset/copy_view.mako @@ -17,22 +17,29 @@ </p> %endif <p> + <div class="infomessage">Select any number of source history items and any number of target histories and click "Copy History Items" to add a copy of each selected history item to each selected target history.</div> + <div style="clear: both"></div> +</p> +<p><div class="toolForm"><form> - <div style="float: left; width: 50%; padding: 0px 0px 0px 0px;"> + <div style="float: left; width: 50%; padding: 0px;"><div class="toolFormTitle">Source History Items</div><div class="toolFormBody"> %for data in source_datasets: <% checked = "" if data.id in source_dataset_ids: - checked = " checked" + checked = " checked='checked'" %> - <div class="form-row"><input type="checkbox" name="source_dataset_ids" value="${data.id}"${checked}/> ${data.hid}: ${data.name}</div> + <div class="form-row"> + <input type="checkbox" name="source_dataset_ids" id="dataset_${data.id}" value="${data.id}"${checked}/> + <label for="dataset_${data.id}" style="display: inline;font-weight:normal;"> ${data.hid}: ${data.name}</label> + </div> %endfor </div></div> - <div style="float: right; width: 50%; padding: 0px 0px 0px 0px;"> + <div style="float: right; width: 50%; padding: 0px;"><div class="toolFormTitle">Target Histories</div><div class="toolFormBody"> %for i, hist in enumerate( target_histories ): @@ -44,13 +51,16 @@ if hist == trans.get_history(): cur_history_text = " <strong>(current history)</strong>" %> - <div class="form-row"><input type="checkbox" name="target_history_ids" value="${hist.id}"${checked}/> ${i + 1}${cur_history_text}: ${hist.name}</div> + <div class="form-row"> + <input type="checkbox" name="target_history_ids" id="hist_${hist.id}" value="${hist.id}"${checked}/> + <label for="hist_${hist.id}" style="display: inline;font-weight:normal;">${i + 1}: ${hist.name}${cur_history_text}</label> + </div> %endfor %if trans.get_user(): <% checked = "" if "create_new_history" in target_history_ids: - checked = " checked" + checked = " checked='checked'" %><br/><div class="form-row"><input type="checkbox" name="target_history_ids" value="create_new_history"${checked}/>New history named: <input type="textbox" name="new_history_name" value="${new_history_name}"/></div> @@ -64,8 +74,3 @@ </form></div></p> -<div style="clear: both"></div> -<p> - <div class="infomessage">Select any number of source history items and any number of target histories and click "Copy History Items" to add a copy of each selected history item to each selected target history.</div> - <div style="clear: both"></div> -</p> --- a/lib/galaxy/web/controllers/dataset.py +++ b/lib/galaxy/web/controllers/dataset.py @@ -773,7 +773,7 @@ class DatasetInterface( BaseController, trans.sa_session.refresh( history ) elif create_new_history: target_history_ids.append( "create_new_history" ) - source_datasets = history.active_datasets + source_datasets = history.visible_datasets target_histories = [history] if user: target_histories = user.active_histories --- a/lib/galaxy/model/mapping.py +++ b/lib/galaxy/model/mapping.py @@ -1033,7 +1033,9 @@ assign_mapper( context, ImplicitlyConver assign_mapper( context, History, History.table, properties=dict( galaxy_sessions=relation( GalaxySessionToHistoryAssociation ), datasets=relation( HistoryDatasetAssociation, backref="history", order_by=asc(HistoryDatasetAssociation.table.c.hid) ), - active_datasets=relation( HistoryDatasetAssociation, primaryjoin=( ( HistoryDatasetAssociation.table.c.history_id == History.table.c.id ) & ( not_( HistoryDatasetAssociation.table.c.deleted ) ) ), order_by=asc( HistoryDatasetAssociation.table.c.hid ), viewonly=True ), + active_datasets=relation( HistoryDatasetAssociation, primaryjoin=( ( HistoryDatasetAssociation.table.c.history_id == History.table.c.id ) & not_( HistoryDatasetAssociation.table.c.deleted ) ), order_by=asc( HistoryDatasetAssociation.table.c.hid ), viewonly=True ), + visible_datasets=relation( HistoryDatasetAssociation, primaryjoin=( ( HistoryDatasetAssociation.table.c.history_id == History.table.c.id ) & not_( HistoryDatasetAssociation.table.c.deleted ) & HistoryDatasetAssociation.table.c.visible ), + order_by=asc( HistoryDatasetAssociation.table.c.hid ), viewonly=True ), tags=relation( HistoryTagAssociation, order_by=HistoryTagAssociation.table.c.id, backref="histories" ), annotations=relation( HistoryAnnotationAssociation, order_by=HistoryAnnotationAssociation.table.c.id, backref="histories" ), ratings=relation( HistoryRatingAssociation, order_by=HistoryRatingAssociation.table.c.id, backref="histories" ) )

1 0

galaxy-dist commit 94c2040e5825: More minor ui fixes in sample tracking
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User rc # Date 1289918776 18000 # Node ID 94c2040e58255136741d776de8401cfb4128133b # Parent 7cc69601ca2da9b6d21f980585b59d73c0133cba More minor ui fixes in sample tracking --- a/templates/requests/common/common.mako +++ b/templates/requests/common/common.mako @@ -220,7 +220,7 @@ %endif %if can_delete_samples: ## Delete button - <td valign="top"><a class="action-button" href="${h.url_for( controller='requests_common', action='delete_sample', cntrller=cntrller, request_id=trans.security.encode_id( request.id ), sample_id=sample_widget_index )}"><img src="${h.url_for('/static/images/delete_icon.png')}" style="cursor:pointer;"/></a></td> + <td valign="top"><a class="action-button" confirm="This sample is not recoverable after deletion. Click Ok to delete." href="${h.url_for( controller='requests_common', action='delete_sample', cntrller=cntrller, request_id=trans.security.encode_id( request.id ), sample_id=sample_widget_index )}"><img src="${h.url_for('/static/images/delete_icon.png')}" style="cursor:pointer;"/></a></td> %endif </%def> --- a/templates/requests/common/edit_samples.mako +++ b/templates/requests/common/edit_samples.mako @@ -12,19 +12,22 @@ <%def name="javascripts()"> ${parent.javascripts()} ${common_javascripts()} + ${local_javascripts()} </%def> -<script type="text/javascript"> - // This function stops the form from getting submitted when return key is pressed - // This is needed in this form as the barcode scanner (when in keyboard emulation mode) - // may send a return key appended to the scanned barcode string. - function stopRKey(evt) { - var evt = (evt) ? evt : ((event) ? event : null); - var node = (evt.target) ? evt.target : ((evt.srcElement) ? evt.srcElement : null); - if ((evt.keyCode == 13) && (node.type=="text")) {return false;} - } - document.onkeypress = stopRKey -</script> +<%def name="local_javascripts()"> + <script type="text/javascript"> + // This function stops the form from getting submitted when return key is pressed + // This is needed in this form as the barcode scanner (when in keyboard emulation mode) + // may send a return key appended to the scanned barcode string. + function stopRKey(evt) { + var evt = (evt) ? evt : ((event) ? event : null); + var node = (evt.target) ? evt.target : ((evt.srcElement) ? evt.srcElement : null); + if ((evt.keyCode == 13) && (node.type=="text")) {return false;} + } + document.onkeypress = stopRKey + </script> +</%def><% from galaxy.web.framework.helpers import time_ago @@ -68,7 +71,7 @@ %if request.samples_without_library_destinations: <p> - <font color="red"><b><i>Select a target data library and folder for a sample before selecting its datasets to transfer from the sequencer</i></b></font> + <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font></p> %endif --- a/templates/requests/common/view_request.mako +++ b/templates/requests/common/view_request.mako @@ -59,7 +59,7 @@ %if request.samples_without_library_destinations: <p> - <font color="red"><b><i>Select a target data library and folder for a sample before selecting its datasets to transfer from the sequencer</i></b></font> + <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font></p> %endif

1 0

galaxy-dist commit d2d0c199c20d: Improvements to annotation display when running workflows: (1) workflow annotation is shown at the top of the page; (2) step annotations are shown in the step header rather than at the bottom. Fixes Issue #420
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User jeremy goecks <jeremy.goecks(a)emory.edu> # Date 1289925819 18000 # Node ID d2d0c199c20ddf942e1e2587dc9aede8acd9cebc # Parent 5a217a7ce999bbe218432a7442751b5b78684798 Improvements to annotation display when running workflows: (1) workflow annotation is shown at the top of the page; (2) step annotations are shown in the step header rather than at the bottom. Fixes Issue #420 --- a/lib/galaxy/web/controllers/workflow.py +++ b/lib/galaxy/web/controllers/workflow.py @@ -1333,6 +1333,7 @@ class WorkflowController( BaseController # Connections by input name step.input_connections_by_name = dict( ( conn.input_name, conn ) for conn in step.input_connections ) # Render the form + stored.annotation = self.get_item_annotation_str( trans.sa_session, trans.user, stored ) return trans.fill_template( "workflow/run.mako", steps=workflow.steps, --- a/templates/workflow/run.mako +++ b/templates/workflow/run.mako @@ -20,6 +20,14 @@ margin-top: 10px; margin-bottom: 10px; } + .step-annotation { + margin-top: 0.25em; + font-weight: normal; + font-size: 97%; + } + .workflow-annotation { + margin-bottom: 1em; + } </style></%def> @@ -129,6 +137,11 @@ from galaxy.jobs.actions.post import Act </div> %endif +%if workflow.annotation: + <div class="workflow-annotation">Annotation: ${workflow.annotation}</div> + <hr/> +%endif + <form id="tool_form" name="tool_form" method="POST"> ## <input type="hidden" name="workflow_name" value="${h.to_unicode( workflow.name ) | h}" /> %for i, step in enumerate( steps ): @@ -136,7 +149,12 @@ from galaxy.jobs.actions.post import Act <% tool = app.toolbox.tools_by_id[step.tool_id] %><input type="hidden" name="${step.id}|tool_state" value="${step.state.encode( tool, app )}"><div class="toolForm"> - <div class="toolFormTitle">Step ${int(step.order_index)+1}: ${tool.name}</div> + <div class="toolFormTitle"> + Step ${int(step.order_index)+1}: ${tool.name} + % if step.annotations: + <div class="step-annotation">Annotation: ${h.to_unicode( step.annotations[0].annotation )}</div> + % endif + </div><div class="toolFormBody"> ${do_inputs( tool.inputs, step.state.inputs, errors.get( step.id, dict() ), "", step )} % if step.post_job_actions: @@ -150,27 +168,21 @@ from galaxy.jobs.actions.post import Act ${'<br/>'.join([ActionBox.get_short_str(pja) for pja in step.post_job_actions])} </div> % endif - % if step.annotations: - <hr/> - <div class='form-row'> - <label>Annotation:</label> ${h.to_unicode( step.annotations[0].annotation )} - </div> - % endif </div></div> %else: <% module = step.module %><input type="hidden" name="${step.id}|tool_state" value="${module.encode_runtime_state( t, step.state )}"><div class="toolForm"> - <div class="toolFormTitle">Step ${int(step.order_index)+1}: ${module.name}</div> + <div class="toolFormTitle"> + Step ${int(step.order_index)+1}: ${module.name} + % if step.annotations: + <div class="step-annotation">Annotation: ${step.annotations[0].annotation}</div> + % endif + + </div><div class="toolFormBody"> ${do_inputs( module.get_runtime_inputs(), step.state.inputs, errors.get( step.id, dict() ), "", step )} - % if step.annotations: - <hr/> - <div class='form-row'> - <label>Annotation:</label> ${step.annotations[0].annotation} - </div> - % endif </div></div> %endif

1 0

galaxy-dist commit 5a217a7ce999: Replaced request with 'sequencing request' in sample tracking ui.
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User rc # Date 1289922517 18000 # Node ID 5a217a7ce999bbe218432a7442751b5b78684798 # Parent 33dacaafc62eac4a8940c4bc978da1d1a6c68af9 Replaced request with 'sequencing request' in sample tracking ui. Show the request page instead of the request grid after submitting the request --- a/templates/admin/requests/edit_request_type.mako +++ b/templates/admin/requests/edit_request_type.mako @@ -28,7 +28,7 @@ </div><div class="form-row"><label> - Request Form definition: + Sequencing Request Form definition: </label><select name="form_id"> %for form in forms: --- a/templates/requests/common/edit_samples.mako +++ b/templates/requests/common/edit_samples.mako @@ -69,16 +69,16 @@ </div></ul> -%if request.samples_without_library_destinations: +%if request.is_rejected: <p> - <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font> + <font color="red"><b>${request.last_comment}</b></font></p> %endif -%if request.is_rejected: - <br/> - <font color="red"><b><i>Reason for rejection: </i></b></font><b>${request.last_comment}</b> - <br/> +%if request.samples_without_library_destinations: + <p> + <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font> + </p> %endif %if message: @@ -90,9 +90,9 @@ %if displayable_sample_widgets: <% if editing_samples: - grid_header = '<h3>Edit Current Samples of Request "%s"</h3>' % request.name + grid_header = '<h3>Edit Current Samples of Sequencing Request "%s"</h3>' % request.name else: - grid_header = '<h3>Add Samples to Request "%s"</h3>' % request.name + grid_header = '<h3>Add Samples to Sequencing Request "%s"</h3>' % request.name %> ${render_samples_grid( cntrller, request, displayable_sample_widgets, action='edit_samples', editing_samples=editing_samples, encoded_selected_sample_ids=encoded_selected_sample_ids, render_buttons=False, grid_header=grid_header )} %if editing_samples and len( sample_operation_select_field.options ) > 1 and not is_unsubmitted: --- a/lib/galaxy/web/controllers/requests_common.py +++ b/lib/galaxy/web/controllers/requests_common.py @@ -157,7 +157,7 @@ class RequestsCommon( BaseController, Us status = 'error' else: request = self.__save_request( trans, cntrller, **kwd ) - message = 'The request has been created.' + message = 'The sequencing request has been created.' if params.get( 'create_request_button', False ): return trans.response.send_redirect( web.url_for( controller=cntrller, action='browse_requests', @@ -316,7 +316,7 @@ class RequestsCommon( BaseController, Us trans.sa_session.flush() trans.sa_session.refresh( request ) # Create an event with state 'New' for this new request - comment = "Request created by %s" % trans.user.email + comment = "Sequencing request created by %s" % trans.user.email if request.user != trans.user: comment += " on behalf of %s." % request.user.email event = trans.model.RequestEvent( request, request.states.NEW, comment ) @@ -358,7 +358,7 @@ class RequestsCommon( BaseController, Us status='error', message=message ) ) # Change the request state to 'Submitted' - comment = "Request submitted by %s" % trans.user.email + comment = "Sequencing request submitted by %s" % trans.user.email if request.user != trans.user: comment += " on behalf of %s." % request.user.email event = trans.model.RequestEvent( request, request.states.SUBMITTED, comment ) @@ -373,7 +373,7 @@ class RequestsCommon( BaseController, Us # request's RequestType configured by the admin. initial_sample_state_after_request_submitted = request.type.states[0] for sample in request.samples: - event_comment = 'Request submitted and sample state set to %s.' % request.type.states[0].name + event_comment = 'Sequencing request submitted and sample state set to %s.' % request.type.states[0].name event = trans.model.SampleEvent( sample, initial_sample_state_after_request_submitted, event_comment ) @@ -381,9 +381,10 @@ class RequestsCommon( BaseController, Us trans.sa_session.add( request ) trans.sa_session.flush() request.send_email_notification( trans, initial_sample_state_after_request_submitted ) - message = 'The request has been submitted.' - return trans.response.send_redirect( web.url_for( controller=cntrller, - action='browse_requests', + message = 'The sequencing request has been submitted.' + # show the request page after submitting the request + return trans.response.send_redirect( web.url_for( controller='requests_common', + action='view_request', cntrller=cntrller, id=request_id, status=status, @@ -528,7 +529,7 @@ class RequestsCommon( BaseController, Us for s in request.samples: s.deleted = True trans.sa_session.add( s ) - comment = "Request marked deleted by %s." % trans.user.email + comment = "Sequencing request marked deleted by %s." % trans.user.email # There is no DELETED state for a request, so keep the current request state event = trans.model.RequestEvent( request, request.state, comment ) trans.sa_session.add( event ) @@ -568,7 +569,7 @@ class RequestsCommon( BaseController, Us for s in request.samples: s.deleted = False trans.sa_session.add( s ) - comment = "Request marked undeleted by %s." % trans.user.email + comment = "Sequencing request marked undeleted by %s." % trans.user.email event = trans.model.RequestEvent( request, request.state, comment ) trans.sa_session.add( event ) trans.sa_session.flush() @@ -686,11 +687,11 @@ class RequestsCommon( BaseController, Us request_type_state = request.type.final_sample_state if common_state.id == request_type_state.id: # since all the samples are in the final state, change the request state to 'Complete' - comment = "All samples of this request are in the final sample state (%s). " % request_type_state.name + comment = "All samples of this sequencing request are in the final sample state (%s). " % request_type_state.name state = request.states.COMPLETE final_state = True else: - comment = "All samples of this request are in the (%s) sample state. " % common_state.name + comment = "All samples of this sequencing request are in the (%s) sample state. " % common_state.name state = request.states.SUBMITTED event = trans.model.RequestEvent( request, state, comment ) trans.sa_session.add( event ) --- a/templates/admin/requests/view_request_type.mako +++ b/templates/admin/requests/view_request_type.mako @@ -38,7 +38,7 @@ <div style="clear: both"></div></div><div class="form-row"> - <label>Request form definition</label> + <label>Sequencing Request form definition</label> ${request_type.request_form.name} </div><div class="form-row"> --- a/lib/galaxy/web/controllers/requests_admin.py +++ b/lib/galaxy/web/controllers/requests_admin.py @@ -223,11 +223,11 @@ class RequestsAdmin( BaseController, Use status=status, message=message ) # Create an event with state 'Rejected' for this request - event_comment = "Request marked rejected by %s. Reason: %s " % ( trans.user.email, comment ) + event_comment = "Sequencing request marked rejected by %s. Reason: %s " % ( trans.user.email, comment ) event = trans.model.RequestEvent( request, request.states.REJECTED, event_comment ) trans.sa_session.add( event ) trans.sa_session.flush() - message='Request (%s) has been rejected.' % request.name + message='Sequencing request (%s) has been rejected.' % request.name return trans.response.send_redirect( web.url_for( controller='requests_admin', action='browse_requests', status=status, --- a/templates/admin/requests/reject.mako +++ b/templates/admin/requests/reject.mako @@ -5,7 +5,6 @@ ${render_msg( message, status )} %endif <br/><br/> -##<h2>Reject Sequencing Request "${request.name}"</h2><ul class="manage-table-actions"><li><a class="action-button" href="${h.url_for( controller='requests_common', action='view_request_history', cntrller=cntrller, id=trans.security.encode_id(request.id) )}">View history</a> --- a/templates/requests/common/view_request.mako +++ b/templates/requests/common/view_request.mako @@ -52,14 +52,14 @@ </ul> %if request.is_rejected: - <br/> - <font color="red"><b><i>Reason for rejection: </i></b></font><b>${request.last_comment}</b> - <br/> + <p> + <font color="red"><b>${request.last_comment}</b></font> + </p> %endif %if request.samples_without_library_destinations: <p> - <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font> + <font color="red"><b><i>Select a target data library and folder for a sample before selecting it's datasets to transfer from the sequencer</i></b></font></p> %endif --- a/templates/requests/common/common.mako +++ b/templates/requests/common/common.mako @@ -159,6 +159,8 @@ <input type="hidden" name="sample_${sample_widget_index}_bar_code" value="${sample_widget['bar_code']}"/> %endif </td> + %else: + <td></td> %endif %if sample: %if is_unsubmitted:

1 0

galaxy-dist commit def13f052a4a: Restored the function to stop the edit samples form from getting submitted when return key is pressed. This is needed in this form as the barcode scanner (when in keyboard emulation mode) may send a return key appended to the scanned barcode string.
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User rc # Date 1289853524 18000 # Node ID def13f052a4a22c46ec5be6481ad874ceb734799 # Parent 02f6c9dae26e9aef40a44bc151ed07b457715839 Restored the function to stop the edit samples form from getting submitted when return key is pressed. This is needed in this form as the barcode scanner (when in keyboard emulation mode) may send a return key appended to the scanned barcode string. --- a/scripts/galaxy_messaging/server/amqp_consumer.py +++ b/scripts/galaxy_messaging/server/amqp_consumer.py @@ -68,7 +68,7 @@ def update_sample_state( message ): api_key = get_value(dom, 'api_key') log.debug('Barcode: ' + barcode) log.debug('State: ' + state) - log.debug('api_key: ' + api_key) + log.debug('API Key: ' + api_key) # validate if not barcode or not state or not api_key: log.debug( 'Incomplete sample_state_update message received. Sample barcode, desired state and user API key is required.' ) --- a/templates/requests/common/edit_samples.mako +++ b/templates/requests/common/edit_samples.mako @@ -14,6 +14,18 @@ ${common_javascripts()} </%def> +<script type="text/javascript"> + // This function stops the form from getting submitted when return key is pressed + // This is needed in this form as the barcode scanner (when in keyboard emulation mode) + // may send a return key appended to the scanned barcode string. + function stopRKey(evt) { + var evt = (evt) ? evt : ((event) ? event : null); + var node = (evt.target) ? evt.target : ((evt.srcElement) ? evt.srcElement : null); + if ((evt.keyCode == 13) && (node.type=="text")) {return false;} + } + document.onkeypress = stopRKey +</script> + <% from galaxy.web.framework.helpers import time_ago

1 0