December 2008 - galaxy-dev - lists.galaxyproject.org

[hg] galaxy 1655: Bug fix for last commit to Tabular.set_meta()
by Greg Von Kuster 10 Dec '08

10 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/b1514bd5244e changeset: 1655:b1514bd5244e user: Dan Blankenberg <dan(a)bx.psu.edu> date: Tue Dec 09 15:51:12 2008 -0500 description: Bug fix for last commit to Tabular.set_meta() 1 file(s) affected in this change: lib/galaxy/datatypes/tabular.py diffs (12 lines): diff -r f77ec6315c7c -r b1514bd5244e lib/galaxy/datatypes/tabular.py --- a/lib/galaxy/datatypes/tabular.py Tue Dec 09 14:53:10 2008 -0500 +++ b/lib/galaxy/datatypes/tabular.py Tue Dec 09 15:51:12 2008 -0500 @@ -134,7 +134,7 @@ #Now we fill any unknown (None) column_types with data from first line for i in range( len( column_types ) ): if column_types[i] is None: - if first_line_column_types[i] is None: + if len( first_line_column_types ) <= i or first_line_column_types[i] is None: column_types[i] = default_column_type else: column_types[i] = first_line_column_types[i]

1 0

[hg] galaxy 1650: Update GMAJ help.
by Greg Von Kuster 05 Dec '08

05 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/6041065f86a9 changeset: 1650:6041065f86a9 user: Dan Blankenberg <dan(a)bx.psu.edu> date: Thu Dec 04 15:09:57 2008 -0500 description: Update GMAJ help. 1 file(s) affected in this change: tools/visualization/GMAJ.xml diffs (33 lines): diff -r 8b9cd2a1d5c2 -r 6041065f86a9 tools/visualization/GMAJ.xml --- a/tools/visualization/GMAJ.xml Thu Dec 04 11:40:42 2008 -0500 +++ b/tools/visualization/GMAJ.xml Thu Dec 04 15:09:57 2008 -0500 @@ -176,13 +176,25 @@ <data name="out_file1" format="gmaj.zip"/> </outputs> <help> -You can use this tool to view a set of MAF alignments. You may also include optional annotation data for one or more of the organisms. +.. class:: infomark + +**Reference Sequence:** +The default option, "First sequence in each block", is the correct choice for the vast majority of MAF alignments. The alternative, "Any sequence", will allow you to flip the blocks to view them with any of the MAF sequences as the reference, but this is only appropriate if the file was generated by a sequence-symmetric alignment program such as TBA_. Using "Any sequence" with an ordinary MAF will **not** give the same results as if that alignment had been run with a different reference sequence. + +.. class:: infomark + +**Annotation Style:** +The default style, "Galaxy", specifies one set of annotations for each species in the MAF file; it assumes that if you have, say, exons for several chromosomes of one species, they are all together in one file. The other style, "Basic", is more flexible but cumbersome: a separate set of files is specified for each sequence (e.g. chromosome), and you must fill in the full sequence name as it appears in the MAF. The Basic style also allows you to provide a display offset that GMAJ will add to all of the position labels for that sequence. With either style, specifying more than one set of annotations for the same sequence will result in an error message from GMAJ. + +---- + +**What it does** + +GMAJ is an interactive viewer for MAF alignments, with support for optional annotation data. In addition to browsing the alignments, you can select and export them according to a variety of criteria and send the output back to your Galaxy history. For detailed information on GMAJ, click here_. .. _here: /static/gmaj/docs/gmaj_readme.html - -Gmaj is a tool for viewing and manipulating Generalized Multiple Alignments (GMAs) produced by programs such as TBA (though it can also be used with maf-format alignments from other sources). It can display interactive graphical and text representations of the alignments, a diagram showing the locations of exons and repeats, and other annotations -- all with the user's choice of reference sequence. - +.. _TBA: http://www.bx.psu.edu/miller_lab/ </help> </tool>

1 0

[hg] galaxy 1651: Increase the version in the grouping tool due ...
by Greg Von Kuster 05 Dec '08

05 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/1734db81efb0 changeset: 1651:1734db81efb0 user: Greg Von Kuster <greg(a)bx.psu.edu> date: Fri Dec 05 09:01:22 2008 -0500 description: Increase the version in the grouping tool due to previously changed output, change the output and increase the version of the gsummary tool. 3 file(s) affected in this change: tools/stats/grouping.xml tools/stats/gsummary.py tools/stats/gsummary.xml diffs (30 lines): diff -r 6041065f86a9 -r 1734db81efb0 tools/stats/grouping.xml --- a/tools/stats/grouping.xml Thu Dec 04 15:09:57 2008 -0500 +++ b/tools/stats/grouping.xml Fri Dec 05 09:01:22 2008 -0500 @@ -1,4 +1,4 @@ -<tool id="Grouping1" name="Group" version="1.2.0"> +<tool id="Grouping1" name="Group" version="1.3.0"> <description>data by a column and perform aggregate operation on other columns.</description> <command interpreter="python"> grouping.py diff -r 6041065f86a9 -r 1734db81efb0 tools/stats/gsummary.py --- a/tools/stats/gsummary.py Thu Dec 04 15:09:57 2008 -0500 +++ b/tools/stats/gsummary.py Fri Dec 05 09:01:22 2008 -0500 @@ -100,7 +100,7 @@ stop_err( "Computation resulted in the following error: %s" % str( s ) ) summary = summary.as_py( BASIC_CONVERSION ) outfile.write( "#%s\n" % headings_str ) - outfile.write( "%s\n" % "\t".join( [ "%.3f" % ( summary[ k ] ) for k in headings ] ) ) + outfile.write( "%s\n" % "\t".join( [ "%g" % ( summary[ k ] ) for k in headings ] ) ) outfile.close() if skipped_lines: diff -r 6041065f86a9 -r 1734db81efb0 tools/stats/gsummary.xml --- a/tools/stats/gsummary.xml Thu Dec 04 15:09:57 2008 -0500 +++ b/tools/stats/gsummary.xml Fri Dec 05 09:01:22 2008 -0500 @@ -1,4 +1,4 @@ -<tool id="Summary_Statistics1" name="Summary Statistics"> +<tool id="Summary_Statistics1" name="Summary Statistics" version="1.1.0"> <description>for any numerical column</description> <command interpreter="python">gsummary.py $input $out_file1 "$cond"</command> <inputs>

1 0

[hg] galaxy 1649: Fix a couple outdated download urls
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/8b9cd2a1d5c2 changeset: 1649:8b9cd2a1d5c2 user: Nate Coraor <nate(a)bx.psu.edu> date: Thu Dec 04 11:40:42 2008 -0500 description: Fix a couple outdated download urls 1 file(s) affected in this change: eggs.ini diffs (24 lines): diff -r 682c179a2f84 -r 8b9cd2a1d5c2 eggs.ini --- a/eggs.ini Thu Dec 04 10:47:41 2008 -0500 +++ b/eggs.ini Thu Dec 04 11:40:42 2008 -0500 @@ -52,7 +52,7 @@ [tags] psycopg2 = _8.2.6_static pysqlite = _3.5.4_static -MySQL_python = _5.0.51a_static +MySQL_python = _5.0.67_static python_lzo = _static flup = .dev_r2311 bx_python = _dev_r456 @@ -61,9 +61,9 @@ ; source location, necessary for scrambling [source] bx_python = http://dist.g2.bx.psu.edu/bx-python_dist-r456.tar.bz2 -Cheetah = http://umn.dl.sourceforge.net/sourceforge/cheetahtemplate/Cheetah-1.0.tar.gz +Cheetah = http://voxel.dl.sourceforge.net/sourceforge/cheetahtemplate/Cheetah-1.0.tar… DRMAA_python = http://gridengine.sunsource.net/files/documents/7/36/DRMAA-python-0.2.tar.gz -MySQL_python = http://superb-west.dl.sourceforge.net/sourceforge/mysql-python/MySQL-python… http://mysql.mirrors.pair.com/Downloads/MySQL-5.0/mysql-5.0.51a.tar.gz +MySQL_python = http://superb-west.dl.sourceforge.net/sourceforge/mysql-python/MySQL-python… http://mysql.mirrors.pair.com/Downloads/MySQL-5.0/mysql-5.0.67.tar.gz pbs_python = http://ftp.sara.nl/pub/outgoing/pbs_python-2.9.4.tar.gz psycopg2 = http://initd.org/pub/software/psycopg/PSYCOPG-2-0/psycopg2-2.0.6.tar.gz http://ftp8.us.postgresql.org/postgresql/source/v8.2.6/postgresql-8.2.6.tar… pycrypto = http://www.amk.ca/files/python/crypto/pycrypto-2.0.1.tar.gz

1 0

[hg] galaxy 1643: Call set_size() before set_peek() on datasets, ...
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/74e392ea6ae8 changeset: 1643:74e392ea6ae8 user: Greg Von Kuster <greg(a)bx.psu.edu> date: Tue Dec 02 10:50:54 2008 -0500 description: Call set_size() before set_peek() on datasets, changes to set_peek() to not read entire files for some datatypes. 14 file(s) affected in this change: lib/galaxy/datatypes/images.py lib/galaxy/datatypes/qualityscore.py lib/galaxy/datatypes/registry.py lib/galaxy/datatypes/sequence.py lib/galaxy/model/__init__.py lib/galaxy/tools/__init__.py lib/galaxy/tools/actions/upload.py lib/galaxy/web/controllers/root.py tools/data_source/encode_import_code.py tools/data_source/gbrowse_filter_code.py tools/data_source/hbvar_filter.py tools/data_source/microbial_import_code.py tools/data_source/ucsc_filter.py tools/maf/maf_to_bed_code.py diffs (385 lines): diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/datatypes/images.py --- a/lib/galaxy/datatypes/images.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/datatypes/images.py Tue Dec 02 10:50:54 2008 -0500 @@ -15,8 +15,8 @@ file_ext = "ab1" def set_peek( self, dataset ): export_url = "/history_add_to?"+urlencode({'history_id':dataset.history_id,'ext':'ab1','name':'ab1 sequence','info':'Sequence file','dbkey':dataset.dbkey}) - dataset.peek = "Binary ab1 sequence file (%s)" % ( data.nice_size( dataset.get_size() ) ) - dataset.blurb = "Binary ab1 sequence file" + dataset.peek = "Binary ab1 sequence file" + dataset.blurb = data.nice_size( dataset.get_size() ) def display_peek(self, dataset): try: return dataset.peek @@ -28,8 +28,8 @@ file_ext = "scf" def set_peek( self, dataset ): export_url = "/history_add_to?"+urlencode({'history_id':dataset.history_id,'ext':'scf','name':'scf sequence','info':'Sequence file','dbkey':dataset.dbkey}) - dataset.peek = "Binary scf sequence file (%s)" % ( data.nice_size( dataset.get_size() ) ) - dataset.blurb = "Binary scf sequence file" + dataset.peek = "Binary scf sequence file" + dataset.blurb = data.nice_size( dataset.get_size() ) def display_peek(self, dataset): try: return dataset.peek @@ -42,8 +42,8 @@ def set_peek( self, dataset ): zip_file = zipfile.ZipFile( dataset.file_name, "r" ) num_files = len( zip_file.namelist() ) - dataset.peek = "Binary sequence file archive (%s)" % ( data.nice_size( dataset.get_size() ) ) - dataset.blurb = 'Zip archive of %s binary sequence files' % ( str( num_files ) ) + dataset.peek = "Archive of %s binary sequence files" % ( str( num_files ) ) + dataset.blurb = data.nice_size( dataset.get_size() ) def display_peek(self, dataset): try: return dataset.peek @@ -59,8 +59,8 @@ def set_peek( self, dataset ): zip_file = zipfile.ZipFile( dataset.file_name, "r" ) num_files = len( zip_file.namelist() ) - dataset.peek = "Text sequence file archive (%s)" % ( data.nice_size( dataset.get_size() ) ) - dataset.blurb = 'Zip archive of %s text sequence files' % ( str( num_files ) ) + dataset.peek = "Archive of %s text sequence files" % ( str( num_files ) ) + dataset.blurb = data.nice_size( dataset.get_size() ) def display_peek(self, dataset): try: return dataset.peek @@ -73,8 +73,8 @@ class Image( data.Data ): """Class describing an image""" def set_peek( self, dataset ): - dataset.peek = 'Image in %s format (%s)' % ( dataset.extension, data.nice_size( dataset.get_size() ) ) - dataset.blurb = 'image' + dataset.peek = 'Image in %s format' % dataset.extension + dataset.blurb = data.nice_size( dataset.get_size() ) def create_applet_tag_peek( class_name, archive, params ): text = """ @@ -147,7 +147,7 @@ """Class describing an html file""" file_ext = "html" def set_peek( self, dataset ): - dataset.peek = "HTML file (%s)" % ( data.nice_size( dataset.get_size() ) ) + dataset.peek = "HTML file" dataset.blurb = data.nice_size( dataset.get_size() ) def get_mime(self): """Returns the mime type of the datatype""" diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/datatypes/qualityscore.py --- a/lib/galaxy/datatypes/qualityscore.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/datatypes/qualityscore.py Tue Dec 02 10:50:54 2008 -0500 @@ -18,7 +18,7 @@ def set_peek( self, dataset, line_count=None ): dataset.peek = data.get_file_peek( dataset.file_name ) if line_count is None: - dataset.blurb = "%s lines, Quality score file" % util.commaify( str( data.get_line_count( dataset.file_name ) ) ) + dataset.blurb = data.nice_size( dataset.get_size() ) else: dataset.blurb = "%s lines, Quality score file" % util.commaify( str( line_count ) ) diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/datatypes/registry.py --- a/lib/galaxy/datatypes/registry.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/datatypes/registry.py Tue Dec 02 10:50:54 2008 -0500 @@ -191,6 +191,7 @@ # being converted *to* will handle any metadata copying and # initialization. if data.has_data(): + data.set_size() data.init_meta( copy_from=data ) data.set_meta( overwrite = False ) data.set_peek() diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/datatypes/sequence.py --- a/lib/galaxy/datatypes/sequence.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/datatypes/sequence.py Tue Dec 02 10:50:54 2008 -0500 @@ -32,17 +32,7 @@ def set_peek( self, dataset ): dataset.peek = data.get_file_peek( dataset.file_name ) - count = size = 0 - for line in file( dataset.file_name ): - if line and line[0] == ">": - count += 1 - else: - line = line.strip() - size += len(line) - if count == 1: - dataset.blurb = '%d bases' % size - else: - dataset.blurb = '%d sequences' % count + dataset.blurb = data.nice_size( dataset.get_size() ) def sniff(self, filename): """ @@ -96,17 +86,7 @@ def set_peek( self, dataset ): dataset.peek = data.get_file_peek( dataset.file_name ) - count = size = 0 - for line in file( dataset.file_name ): - if line and line[0] == ">": - count += 1 - else: - line = line.strip() - size += len(line) - if count == 1: - dataset.blurb = '%d bases' % size - else: - dataset.blurb = '%d sequences' % count + dataset.blurb = data.nice_size( dataset.get_size() ) def sniff( self, filename ): """ @@ -128,18 +108,7 @@ def set_peek( self, dataset ): dataset.peek = data.get_file_peek( dataset.file_name ) - count = size = 0 - bases_regexp = re.compile("^[NGTAC]*$") - for i, line in enumerate(file( dataset.file_name )): - if line and line[0] == "@" and i % 4 == 0: - count += 1 - elif bases_regexp.match(line): - line = line.strip() - size += len(line) - if count == 1: - dataset.blurb = '%d bases' % size - else: - dataset.blurb = '%d sequences' % count + dataset.blurb = data.nice_size( dataset.get_size() ) def sniff( self, filename ): """ diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/model/__init__.py --- a/lib/galaxy/model/__init__.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/model/__init__.py Tue Dec 02 10:50:54 2008 -0500 @@ -289,6 +289,7 @@ def copy( self, copy_children = False, parent_id = None ): des = HistoryDatasetAssociation( hid=self.hid, name=self.name, info=self.info, blurb=self.blurb, peek=self.peek, extension=self.extension, dbkey=self.dbkey, dataset = self.dataset, visible=self.visible, deleted=self.deleted, parent_id=parent_id, copied_from_history_dataset_association = self ) des.flush() + des.set_size() des.metadata = self.metadata #need to set after flushed, as MetadataFiles require dataset.id if copy_children: for child in self.children: @@ -467,7 +468,8 @@ def set_size( self ): """Returns the size of the data on disk""" try: - self.file_size = os.path.getsize( self.file_name ) + if not self.file_size: + self.file_size = os.path.getsize( self.file_name ) except OSError: self.file_size = 0 def has_data( self ): diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/tools/__init__.py --- a/lib/galaxy/tools/__init__.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/tools/__init__.py Tue Dec 02 10:50:54 2008 -0500 @@ -1189,6 +1189,7 @@ # tag set in the tool config. if self.tool_type == 'data_source': name, data = out_data.items()[0] + data.set_size() if data.state == data.states.OK: data.name = param_dict.get( 'name', data.name ) data.info = param_dict.get( 'info', data.name ) @@ -1202,7 +1203,6 @@ if data.missing_meta(): data = app.datatypes_registry.change_datatype( data, 'tabular' ) data.set_peek() - data.set_size() data.flush() def collect_associated_files( self, output ): @@ -1234,12 +1234,12 @@ # Move data from temp location to dataset location shutil.move( filename, child_dataset.file_name ) child_dataset.flush() + child_dataset.set_size() child_dataset.name = "Secondary Dataset (%s)" % ( designation ) child_dataset.state = child_dataset.states.OK child_dataset.init_meta() child_dataset.set_meta() child_dataset.set_peek() - child_dataset.set_size() child_dataset.flush() # Add child to return dict children[name][designation] = child_dataset @@ -1270,13 +1270,13 @@ primary_data.flush() # Move data from temp location to dataset location shutil.move( filename, primary_data.file_name ) + primary_data.set_size() primary_data.name = dataset.name primary_data.info = dataset.info primary_data.state = primary_data.states.OK primary_data.init_meta( copy_from=dataset ) primary_data.set_meta() primary_data.set_peek() - primary_data.set_size() primary_data.flush() outdata.history.add_dataset( primary_data ) # Add dataset to return dict diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/tools/actions/upload.py --- a/lib/galaxy/tools/actions/upload.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/tools/actions/upload.py Tue Dec 02 10:50:54 2008 -0500 @@ -210,6 +210,7 @@ data.flush() shutil.move( temp_name, data.file_name ) data.state = data.states.OK + data.set_size() data.init_meta() if self.line_count is not None: try: @@ -218,7 +219,6 @@ data.set_peek() else: data.set_peek() - data.set_size() # validate incomming data """ diff -r 499eed864ab3 -r 74e392ea6ae8 lib/galaxy/web/controllers/root.py --- a/lib/galaxy/web/controllers/root.py Mon Dec 01 14:07:36 2008 -0500 +++ b/lib/galaxy/web/controllers/root.py Tue Dec 02 10:50:54 2008 -0500 @@ -647,13 +647,13 @@ data_file.write( file_data.file.read() ) data_file.close() data.state = data.states.OK + data.set_size() data.init_meta() data.set_meta() data.flush() history.add_dataset( data ) history.flush() data.set_peek() - data.set_size() data.flush() trans.log_event("Added dataset %d to history %d" %(data.id, trans.history.id)) if self.app.memory_usage: diff -r 499eed864ab3 -r 74e392ea6ae8 tools/data_source/encode_import_code.py --- a/tools/data_source/encode_import_code.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/data_source/encode_import_code.py Tue Dec 02 10:50:54 2008 -0500 @@ -19,6 +19,7 @@ dbkey = fields[2] file_type = fields[3] name, data = out_data.items()[0] + data.set_size() basic_name = data.name data.name = data.name + " (" + description + ")" data.dbkey = dbkey @@ -26,7 +27,6 @@ data = app.datatypes_registry.change_datatype( data, file_type ) data.init_meta() data.set_peek() - data.set_size() app.model.flush() elif fields[0] == "#NewFile": description = fields[1] @@ -34,6 +34,7 @@ filepath = fields[3] file_type = fields[4] newdata = app.model.HistoryDatasetAssociation( create_dataset = True ) #This import should become a library + newdata.set_size() newdata.extension = file_type newdata.name = basic_name + " (" + description + ")" history.add_dataset( newdata ) @@ -48,5 +49,4 @@ newdata.dbkey = dbkey newdata.set_meta() newdata.set_peek() - newdata.set_size() app.model.flush() diff -r 499eed864ab3 -r 74e392ea6ae8 tools/data_source/gbrowse_filter_code.py --- a/tools/data_source/gbrowse_filter_code.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/data_source/gbrowse_filter_code.py Tue Dec 02 10:50:54 2008 -0500 @@ -24,11 +24,11 @@ def exec_after_process( app, inp_data, out_data, param_dict, tool=None, stdout=None, stderr=None ): """Verifies the data after the run""" name, data = out_data.items()[0] + data.set_size() if data.state == data.states.OK: data.info = data.name if data.extension == 'txt': data_type = sniff.guess_ext( data.file_name, sniff_order=app.datatypes_registry.sniff_order ) data = app.datatypes_registry.change_datatype( data, data_type ) data.set_peek() - data.set_size() data.flush() diff -r 499eed864ab3 -r 74e392ea6ae8 tools/data_source/hbvar_filter.py --- a/tools/data_source/hbvar_filter.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/data_source/hbvar_filter.py Tue Dec 02 10:50:54 2008 -0500 @@ -71,6 +71,6 @@ else: data = app.datatypes_registry.change_datatype(data, 'tabular') + data.set_size() data.set_peek() - data.set_size() data.flush() diff -r 499eed864ab3 -r 74e392ea6ae8 tools/data_source/microbial_import_code.py --- a/tools/data_source/microbial_import_code.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/data_source/microbial_import_code.py Tue Dec 02 10:50:54 2008 -0500 @@ -114,6 +114,7 @@ dbkey = fields[3] file_type = fields[4] name, data = out_data.items()[0] + data.set_size() basic_name = data.name data.name = data.name + " (" + microbe_info[kingdom][org]['chrs'][chr]['data'][description]['feature'] +" for " + microbe_info[kingdom][org]['name'] + ":" + chr + ")" data.dbkey = dbkey @@ -121,7 +122,6 @@ data = app.datatypes_registry.change_datatype( data, file_type ) data.init_meta() data.set_peek() - data.set_size() app.model.flush() elif fields[0] == "#NewFile": description = fields[1] @@ -130,6 +130,7 @@ filepath = fields[4] file_type = fields[5] newdata = app.model.HistoryDatasetAssociation( create_dataset = True ) #This import should become a library + newdata.set_size() newdata.extension = file_type newdata.name = basic_name + " (" + microbe_info[kingdom][org]['chrs'][chr]['data'][description]['feature'] +" for "+microbe_info[kingdom][org]['name']+":"+chr + ")" newdata.flush() @@ -145,5 +146,4 @@ newdata.dbkey = dbkey newdata.init_meta() newdata.set_peek() - newdata.set_size() app.model.flush() diff -r 499eed864ab3 -r 74e392ea6ae8 tools/data_source/ucsc_filter.py --- a/tools/data_source/ucsc_filter.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/data_source/ucsc_filter.py Tue Dec 02 10:50:54 2008 -0500 @@ -43,6 +43,7 @@ """Verifies the data after the run""" items = out_data.items() for name, data in items: + data.set_size() try: err_msg, err_flag = 'Errors:', False line_count = 0 @@ -65,4 +66,3 @@ except Exception, exc: data.info = data.info + "\n" + str(exc) data.blurb = "error" - data.set_size() diff -r 499eed864ab3 -r 74e392ea6ae8 tools/maf/maf_to_bed_code.py --- a/tools/maf/maf_to_bed_code.py Mon Dec 01 14:07:36 2008 -0500 +++ b/tools/maf/maf_to_bed_code.py Tue Dec 02 10:50:54 2008 -0500 @@ -29,6 +29,7 @@ filepath = fields[2] newdata = app.model.HistoryDatasetAssociation( create_dataset = True ) + newdata.set_size() newdata.extension = "bed" newdata.name = basic_name + " (" + dbkey + ")" newdata.flush() @@ -46,7 +47,6 @@ newdata.dbkey = dbkey newdata.init_meta() newdata.set_peek() - newdata.set_size() app.model.flush() output_data_list.append(newdata) else:

1 0

[hg] galaxy 1644: Bug fixes for compare, Group and filter tools.
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/ab46f22b4624 changeset: 1644:ab46f22b4624 user: guru date: Tue Dec 02 11:41:25 2008 -0500 description: Bug fixes for compare, Group and filter tools. 3 file(s) affected in this change: tools/filters/compare.xml tools/stats/filtering.py tools/stats/grouping.py diffs (51 lines): diff -r 74e392ea6ae8 -r ab46f22b4624 tools/filters/compare.xml --- a/tools/filters/compare.xml Tue Dec 02 10:50:54 2008 -0500 +++ b/tools/filters/compare.xml Tue Dec 02 11:41:25 2008 -0500 @@ -3,9 +3,13 @@ <command interpreter="python">joinWrapper.py $input1 $input2 $field1 $field2 $mode $out_file1</command> <inputs> <param format="tabular" name="input1" type="data" label="Compare"/> - <param name="field1" label="Using column" type="data_column" data_ref="input1" /> + <param name="field1" label="Using column" type="data_column" data_ref="input1"> + <validator type="no_options" message="Invalid column choice. Please try again after editing metadata of your input dataset by clicking on the pencil icon next to it."/> + </param> <param format="tabular" name="input2" type="data" label="against" /> - <param name="field2" label="and column" type="data_column" data_ref="input2" /> + <param name="field2" label="and column" type="data_column" data_ref="input2"> + <validator type="no_options" message="Invalid column choice. Please try again after editing metadata of your input dataset by clicking on the pencil icon next to it."/> + </param> <param name="mode" type="select" label="To find" help="See examples below for explanation of these options"> <option value="N">Matching rows of 1st query</option> <option value="V">Non Matching rows of 1st query</option> diff -r 74e392ea6ae8 -r ab46f22b4624 tools/stats/filtering.py --- a/tools/stats/filtering.py Tue Dec 02 10:50:54 2008 -0500 +++ b/tools/stats/filtering.py Tue Dec 02 11:41:25 2008 -0500 @@ -25,6 +25,7 @@ cond_text = sys.argv[3] try: in_columns = int( sys.argv[4] ) + assert sys.argv[5] #check to see that the column types varaible isn't null in_column_types = sys.argv[5].split( ',' ) except: stop_err( "Data does not appear to be tabular. This tool can only be used with tab-delimited data." ) diff -r 74e392ea6ae8 -r ab46f22b4624 tools/stats/grouping.py --- a/tools/stats/grouping.py Tue Dec 02 10:50:54 2008 -0500 +++ b/tools/stats/grouping.py Tue Dec 02 11:41:25 2008 -0500 @@ -128,7 +128,7 @@ if op not in ['c','length','unique','random']: for j, elem in enumerate( prev_vals[i] ): prev_vals[i][j] = float( elem ) - rout = "%f" %( eval( rfunc )( prev_vals[i] )) + rout = "%g" %( eval( rfunc )( prev_vals[i] )) if rounds[i] == 'yes': rout = int(round(float(rout))) else: @@ -179,7 +179,7 @@ if op not in ['c','length','unique','random']: for j, elem in enumerate( prev_vals[i] ): prev_vals[i][j] = float( elem ) - rout = '%f' %( eval( rfunc )( prev_vals[i] )) + rout = '%g' %( eval( rfunc )( prev_vals[i] )) if rounds[i] == 'yes': rout = int(round(float(rout))) else:

1 0

[hg] galaxy 1645: imported patch job-queue-sessions
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/1dc78a13070c changeset: 1645:1dc78a13070c user: James Taylor <james(a)jamestaylor.org> date: Tue Dec 02 13:49:29 2008 -0500 description: imported patch job-queue-sessions 1 file(s) affected in this change: lib/galaxy/jobs/__init__.py diffs (229 lines): diff -r ab46f22b4624 -r 1dc78a13070c lib/galaxy/jobs/__init__.py --- a/lib/galaxy/jobs/__init__.py Tue Dec 02 11:41:25 2008 -0500 +++ b/lib/galaxy/jobs/__init__.py Tue Dec 02 13:49:29 2008 -0500 @@ -63,9 +63,8 @@ def __init__( self, app, dispatcher ): """Start the job manager""" self.app = app - # Should we use IPC to communicate (needed if forking) + # Should we read jobs form the database, or use an in memory queue self.track_jobs_in_database = app.config.get_bool( 'track_jobs_in_database', False ) - # Check if any special scheduling policy should be used. If not, default is FIFO. sched_policy = app.config.get('job_scheduler_policy', 'FIFO') # Parse the scheduler policy string. The policy class implements a special queue. @@ -104,13 +103,13 @@ self.sleeper = Sleeper() self.running = True self.dispatcher = dispatcher - self.monitor_thread = threading.Thread( target=self.monitor ) + self.monitor_thread = threading.Thread( target=self.__monitor ) self.monitor_thread.start() log.info( "job manager started" ) if app.config.get_bool( 'enable_job_recovery', True ): - self.check_jobs_at_startup() + self.__check_jobs_at_startup() - def check_jobs_at_startup( self ): + def __check_jobs_at_startup( self ): """ Checks all jobs that are in the 'running' or 'queued' state in the database and requeues or cleans up as necessary. Only run as the @@ -125,10 +124,10 @@ for job in model.Job.filter( (model.Job.c.state == model.Job.states.RUNNING) | (model.Job.c.state == model.Job.states.QUEUED) ).all(): if job.job_runner_name is not None: # why are we passing the queue to the wrapper? - job_wrapper = JobWrapper( job.id, self.app.toolbox.tools_by_id[ job.tool_id ], self ) + job_wrapper = JobWrapper( job, self.app.toolbox.tools_by_id[ job.tool_id ], self ) self.dispatcher.recover( job, job_wrapper ) - def monitor( self ): + def __monitor( self ): """ Continually iterate the waiting jobs, checking is each is ready to run and dispatching if so. @@ -137,13 +136,13 @@ time.sleep( 10 ) while self.running: try: - self.monitor_step() + self.__monitor_step() except: log.exception( "Exception in monitor_step" ) # Sleep self.sleeper.sleep( 1 ) - def monitor_step( self ): + def __monitor_step( self ): """ Called repeatedly by `monitor` to process waiting jobs. Gets any new jobs (either from the database or from its own queue), then iterates @@ -153,12 +152,13 @@ it is marked as having errors and removed from the queue. Otherwise, the job is dispatched. """ + # Get an orm session + session = mapping.Session() # Pull all new jobs from the queue at once new_jobs = [] if self.track_jobs_in_database: - model = self.app.model - for j in model.Job.filter( model.Job.c.state==model.Job.states.NEW ).all(): - job = JobWrapper( j.id, self.app.toolbox.tools_by_id[ j.tool_id ], self ) + for j in session.query( model.Job ).filter( model.Job.c.state == model.Job.states.NEW ).all(): + job = JobWrapper( j, self.app.toolbox.tools_by_id[ j.tool_id ], self ) new_jobs.append( job ) else: try: @@ -169,18 +169,26 @@ # Unpack the message job_id, tool_id = message # Create a job wrapper from it - job = JobWrapper( job_id, self.app.toolbox.tools_by_id[ tool_id ], self ) + job_entity = session.query( model.Job ).get( job_id ) + job = JobWrapper( job_entity, self.app.toolbox.tools_by_id[ tool_id ], self ) # Append to watch queue new_jobs.append( job ) except Empty: - pass + pass # Iterate over new and waiting jobs and look for any that are # ready to run new_waiting = [] for job in ( new_jobs + self.waiting ): try: + # Clear the session for each job so we get fresh states for + # job and all datasets + session.clear() + # Get the real job entity corresponding to the wrapper (if we + # are tracking in the database this is probably cached in + # the session from the origianl query above) + job_entity = session.query( model.Job ).get( job.job_id ) # Check the job's dependencies, requeue if they're not done - job_state = job.check_if_ready_to_run() + job_state = self.__check_if_ready_to_run( job, job_entity ) if job_state == JOB_WAIT: if not self.track_jobs_in_database: new_waiting.append( job ) @@ -195,7 +203,7 @@ if self.use_policy : self.squeue.put( job ) log.debug( "job %d put in policy queue" % job.job_id ) - else : # or dispatch the job directly + else: # or dispatch the job directly self.dispatcher.put( job ) log.debug( "job %d dispatched" % job.job_id) elif job_state == JOB_DELETED: @@ -225,6 +233,43 @@ except Exception, e: # if something else breaks while dispatching job.fail( "failure running job %d: %s" % ( sjob.job_id, str( e ) ) ) log.exception( "failure running job %d" % sjob.job_id ) + # Done with the session + mapping.Session.remove() + + def __check_if_ready_to_run( self, job_wrapper, job ): + """ + Check if a job is ready to run by verifying that each of its input + datasets is ready (specifically in the OK state). If any input dataset + has an error, fail the job and return JOB_INPUT_ERROR. If any input + dataset is deleted, fail the job and return JOB_INPUT_DELETED. If all + input datasets are in OK state, return JOB_READY indicating that the + job can be dispatched. Otherwise, return JOB_WAIT indicating that input + datasets are still being prepared. + """ + if self.app.memory_usage: + # Keep track of memory usage + m0 = self.app.memory_usage.memory() + for dataset_assoc in job.input_datasets: + idata = dataset_assoc.dataset + if not idata: + continue + # don't run jobs for which the input dataset was deleted + if idata.deleted: + job_wrapper.fail( "input data %d (file: %s) was deleted before the job started" % ( idata.hid, idata.file_name ) ) + return JOB_INPUT_DELETED + # an error in the input data causes us to bail immediately + elif idata.state == idata.states.ERROR: + job_wrapper.fail( "input data %d (file: %s) is in an error state" % ( idata.hid, idata.file_name ) ) + return JOB_INPUT_ERROR + elif idata.state != idata.states.OK: + # need to requeue + return JOB_WAIT + if self.app.memory_usage: + m1 = self.app.memory_usage.memory( m0, pretty=True ) + log.info("End of check_if_ready_to_run for job id %d, memory used increased by %s" % ( job.id, m1 ) ) + if job.state == model.Job.states.DELETED: + return JOB_DELETED + return JOB_READY def put( self, job_id, tool ): """Add a job to the queue (by job identifier)""" @@ -251,8 +296,10 @@ Wraps a 'model.Job' with convience methods for running processes and state management. """ - def __init__(self, job_id, tool, queue ): - self.job_id = job_id + def __init__(self, job, tool, queue ): + self.job_id = job.id + # This is immutable, we cache it for the scheduling policy to use if needed + self.session_id = job.session_id self.tool = tool self.queue = queue self.app = queue.app @@ -401,45 +448,6 @@ job.job_runner_name = runner_url job.job_runner_external_id = external_id job.flush() - - def check_if_ready_to_run( self ): - """ - Check if a job is ready to run by verifying that each of its input - datasets is ready (specifically in the OK state). If any input dataset - has an error, fail the job and return JOB_INPUT_ERROR. If any input - dataset is deleted, fail the job and return JOB_INPUT_DELETED. If all - input datasets are in OK state, return JOB_READY indicating that the - job can be dispatched. Otherwise, return JOB_WAIT indicating that input - datasets are still being prepared. - """ - if self.app.memory_usage: - # Keep track of memory usage - m0 = self.app.memory_usage.memory() - job = model.Job.get( self.job_id ) - job.refresh() - for dataset_assoc in job.input_datasets: - idata = dataset_assoc.dataset - if not idata: - continue - idata.refresh() - idata.dataset.refresh() #we need to refresh the base Dataset, since that is where 'state' is stored - # don't run jobs for which the input dataset was deleted - if idata.deleted: - self.fail( "input data %d (file: %s) was deleted before the job started" % ( idata.hid, idata.file_name ) ) - return JOB_INPUT_DELETED - # an error in the input data causes us to bail immediately - elif idata.state == idata.states.ERROR: - self.fail( "input data %d (file: %s) is in an error state" % ( idata.hid, idata.file_name ) ) - return JOB_INPUT_ERROR - elif idata.state != idata.states.OK: - # need to requeue - return JOB_WAIT - if self.app.memory_usage: - m1 = self.app.memory_usage.memory( m0, pretty=True ) - log.info("End of check_if_ready_to_run for job id %d, memory used increased by %s" % ( job.id, m1 ) ) - if job.state == model.Job.states.DELETED: - return JOB_DELETED - return JOB_READY def finish( self, stdout, stderr ): """ @@ -538,8 +546,7 @@ return self.command_line def get_session_id( self ): - job = model.Job.get( self.job_id ) - return job.session_id + return self.session_id def get_input_fnames( self ): job = model.Job.get( self.job_id )

1 0

[hg] galaxy 1646: imported patch job-eager-load
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/f242b5a3fedc changeset: 1646:f242b5a3fedc user: James Taylor <james(a)jamestaylor.org> date: Tue Dec 02 13:49:32 2008 -0500 description: imported patch job-eager-load 1 file(s) affected in this change: lib/galaxy/model/mapping.py diffs (28 lines): diff -r 1dc78a13070c -r f242b5a3fedc lib/galaxy/model/mapping.py --- a/lib/galaxy/model/mapping.py Tue Dec 02 13:49:29 2008 -0500 +++ b/lib/galaxy/model/mapping.py Tue Dec 02 13:49:32 2008 -0500 @@ -305,19 +305,19 @@ ) ) assign_mapper( context, JobToInputDatasetAssociation, JobToInputDatasetAssociation.table, - properties=dict( job=relation( Job ), dataset=relation( HistoryDatasetAssociation ) ) ) + properties=dict( job=relation( Job ), dataset=relation( HistoryDatasetAssociation, lazy=False ) ) ) assign_mapper( context, JobToOutputDatasetAssociation, JobToOutputDatasetAssociation.table, - properties=dict( job=relation( Job ), dataset=relation( HistoryDatasetAssociation ) ) ) + properties=dict( job=relation( Job ), dataset=relation( HistoryDatasetAssociation, lazy=False ) ) ) assign_mapper( context, JobParameter, JobParameter.table ) assign_mapper( context, Job, Job.table, properties=dict( galaxy_session=relation( GalaxySession ), history=relation( History ), - parameters=relation( JobParameter ), - input_datasets=relation( JobToInputDatasetAssociation ), - output_datasets=relation( JobToOutputDatasetAssociation ) ) ) + parameters=relation( JobParameter, lazy=False ), + input_datasets=relation( JobToInputDatasetAssociation, lazy=False ), + output_datasets=relation( JobToOutputDatasetAssociation, lazy=False ) ) ) assign_mapper( context, Event, Event.table, properties=dict( history=relation( History ),

1 0

[hg] galaxy 1648: Let UCSC through w/o authentication when use_r...
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/682c179a2f84 changeset: 1648:682c179a2f84 user: Nate Coraor <nate(a)bx.psu.edu> date: Thu Dec 04 10:47:41 2008 -0500 description: Let UCSC through w/o authentication when use_remote_user is enabled. 2 file(s) affected in this change: lib/galaxy/web/buildapp.py lib/galaxy/web/framework/middleware/remoteuser.py diffs (60 lines): diff -r 15bf910890d5 -r 682c179a2f84 lib/galaxy/web/buildapp.py --- a/lib/galaxy/web/buildapp.py Tue Dec 02 17:17:23 2008 -0500 +++ b/lib/galaxy/web/buildapp.py Thu Dec 04 10:47:41 2008 -0500 @@ -95,7 +95,7 @@ # upstream server if asbool(conf.get( 'use_remote_user', False )): from galaxy.web.framework.middleware.remoteuser import RemoteUser - app = RemoteUser( app, maildomain=conf.get( 'remote_user_maildomain', None ) ) + app = RemoteUser( app, maildomain=conf.get( 'remote_user_maildomain', None ), ucsc_display_sites=conf.get( 'ucsc_display_sites', [] ) ) log.debug( "Enabling 'remote user' middleware" ) # The recursive middleware allows for including requests in other # requests or forwarding of requests, all on the server side. diff -r 15bf910890d5 -r 682c179a2f84 lib/galaxy/web/framework/middleware/remoteuser.py --- a/lib/galaxy/web/framework/middleware/remoteuser.py Tue Dec 02 17:17:23 2008 -0500 +++ b/lib/galaxy/web/framework/middleware/remoteuser.py Thu Dec 04 10:47:41 2008 -0500 @@ -1,6 +1,8 @@ """ Middleware for handling $REMOTE_USER if use_remote_user is enabled. """ + +import socket errorpage = """ <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> @@ -33,11 +35,34 @@ </html> """ +UCSC_SERVERS = ( + 'hgw1.cse.ucsc.edu', + 'hgw2.cse.ucsc.edu', + 'hgw3.cse.ucsc.edu', + 'hgw4.cse.ucsc.edu', + 'hgw5.cse.ucsc.edu', + 'hgw6.cse.ucsc.edu', + 'hgw7.cse.ucsc.edu', + 'hgw8.cse.ucsc.edu', +) + class RemoteUser( object ): - def __init__( self, app, maildomain=None ): + def __init__( self, app, maildomain=None, ucsc_display_sites=[] ): self.app = app self.maildomain = maildomain + self.allow_ucsc = False + if len( ucsc_display_sites ): + self.allow_ucsc = True def __call__( self, environ, start_response ): + # Allow through UCSC if the UCSC display links are enabled + if self.allow_ucsc and environ.has_key( 'REMOTE_ADDR' ): + try: + host = socket.gethostbyaddr( environ[ 'REMOTE_ADDR' ] )[0] + except( socket.error, socket.herror, socket.gaierror, socket.timeout ): + # in the event of a lookup failure, deny access + host = None + if host in UCSC_SERVERS: + return self.app( environ, start_response ) # Apache sets REMOTE_USER to the string '(null)' when using the # Rewrite* method for passing REMOTE_USER and a user is # un-authenticated. Any other possible values need to go here as well.

1 0

[hg] galaxy 1647: allow users to specify that label for input da...
by Nate Coraor 04 Dec '08

04 Dec '08

details: http://www.bx.psu.edu/hg/galaxy/rev/15bf910890d5 changeset: 1647:15bf910890d5 user: James Taylor <james(a)jamestaylor.org> date: Tue Dec 02 17:17:23 2008 -0500 description: allow users to specify that label for input dataset modules. 4 file(s) affected in this change: lib/galaxy/web/controllers/workflow.py lib/galaxy/workflow/modules.py templates/workflow/editor_generic_form.mako templates/workflow/editor_tool_form.mako diffs (140 lines): diff -r f242b5a3fedc -r 15bf910890d5 lib/galaxy/web/controllers/workflow.py --- a/lib/galaxy/web/controllers/workflow.py Tue Dec 02 13:49:32 2008 -0500 +++ b/lib/galaxy/web/controllers/workflow.py Tue Dec 02 17:17:23 2008 -0500 @@ -166,7 +166,7 @@ return trans.fill_template( "workflow/editor.mako", workflow_id=id ) @web.json - def editor_tool_form( self, trans, type='tool', tool_id=None, **incoming ): + def editor_form_post( self, trans, type='tool', tool_id=None, **incoming ): """ Accepts a tool state and incoming values, and generates a new tool form and some additional information, packed into a json dictionary. diff -r f242b5a3fedc -r 15bf910890d5 lib/galaxy/workflow/modules.py --- a/lib/galaxy/workflow/modules.py Tue Dec 02 13:49:32 2008 -0500 +++ b/lib/galaxy/workflow/modules.py Tue Dec 02 17:17:23 2008 -0500 @@ -5,6 +5,7 @@ from galaxy.tools import DefaultToolState from galaxy.tools.parameters.grouping import Repeat, Conditional from galaxy.util.bunch import Bunch +from galaxy.util.json import from_json_string, to_json_string class WorkflowModule( object ): @@ -78,20 +79,48 @@ class InputDataModule( WorkflowModule ): type = "data_input" name = "Input dataset" - _runtime_inputs = { - 'input' : DataToolParameter( None, Element( "param", name="input", label="Input Dataset", type="data", format="data" ) ) - } - + + @classmethod + def new( Class, trans, tool_id=None ): + module = Class( trans ) + module.state = dict( name="Input Dataset" ) + return module + @classmethod + def from_dict( Class, trans, d ): + module = Class( trans ) + state = from_json_string( d["tool_state"] ) + module.state = dict( name=state.get( "name", "Input Dataset" ) ) + return module + @classmethod + def from_workflow_step( Class, trans, step ): + module = Class( trans ) + module.state = dict( name="Input Dataset" ) + if step.tool_inputs and "name" in step.tool_inputs: + module.state['name'] = step.tool_inputs[ 'name' ] + return module + def save_to_step( self, step ): + step.type = self.type + step.tool_id = None + step.tool_inputs = self.state + def get_data_inputs( self ): return [] def get_data_outputs( self ): return [ dict( name='output', extension='input' ) ] def get_config_form( self ): + form = web.FormBuilder( title=self.name ) \ + .add_text( "name", "Name", value=self.state['name'] ) return self.trans.fill_template( "workflow/editor_generic_form.mako", - form = web.FormBuilder( title=self.name ) ) + module=self, form=form ) + def get_state( self ): + return to_json_string( self.state ) + + def update_state( self, incoming ): + self.state['name'] = incoming.get( 'name', 'Input Dataset' ) def get_runtime_inputs( self ): - return self._runtime_inputs + label = self.state.get( "name", "Input Dataset" ) + return dict( input=DataToolParameter( None, Element( "param", name="input", label=label, type="data", format="data" ) ) ) def get_runtime_state( self ): state = DefaultToolState() state.inputs = dict( input=None ) @@ -106,7 +135,7 @@ return state def update_runtime_state( self, trans, state, values ): errors = {} - for name, param in self._runtime_inputs.iteritems(): + for name, param in self.get_runtime_inputs().iteritems(): value, error = check_param( trans, param, values.get( name, None ), values ) state.inputs[ name ] = value if error: @@ -146,7 +175,6 @@ tool_id = step.tool_id module = Class( trans, tool_id ) module.state = DefaultToolState() - print step.tool_inputs module.state.inputs = module.tool.params_from_strings( step.tool_inputs, trans.app, ignore_errors=True ) module.errors = step.tool_errors return module @@ -229,4 +257,4 @@ type = step.type return self.module_types[type].from_workflow_step( trans, step ) -module_factory = WorkflowModuleFactory( dict( data_input=InputDataModule, tool=ToolModule ) ) \ No newline at end of file +module_factory = WorkflowModuleFactory( dict( data_input=InputDataModule, tool=ToolModule ) ) diff -r f242b5a3fedc -r 15bf910890d5 templates/workflow/editor_generic_form.mako --- a/templates/workflow/editor_generic_form.mako Tue Dec 02 13:49:32 2008 -0500 +++ b/templates/workflow/editor_generic_form.mako Tue Dec 02 17:17:23 2008 -0500 @@ -1,8 +1,8 @@ <div class="toolForm"> <div class="toolFormTitle">${form.title}</div> <div class="toolFormBody"> - <form name="$form.name" action="${h.url_for(form.action)}" method="post"> - <table cellpadding="0" cellspacing="0" border="0"> + <form name="${form.name}" action="${h.url_for( action='editor_form_post' )}" method="post"> + <input type="hidden" name="type" value="${module.type}" /> %if form.inputs: %for input in form.inputs: <% @@ -33,9 +33,9 @@ </div> %endfor - <tr><td></td><td><input type="submit" value="${form.submit_text}"> + <div class="form-row"><input type="submit" value="${form.submit_text}"></div> %else: - <tr><td colspan="2"><i>No options</i></td></tr> + <div class="form-row"><i>No options</i></div> %endif </table> </form> diff -r f242b5a3fedc -r 15bf910890d5 templates/workflow/editor_tool_form.mako --- a/templates/workflow/editor_tool_form.mako Tue Dec 02 13:49:32 2008 -0500 +++ b/templates/workflow/editor_tool_form.mako Tue Dec 02 17:17:23 2008 -0500 @@ -56,7 +56,7 @@ <div class="toolForm"> <div class="toolFormTitle">Tool: ${tool.name}</div> <div class="toolFormBody"> - <form method="get" action="${h.url_for( action='editor_tool_form' )}"> + <form method="post" action="${h.url_for( action='editor_form_post' )}"> <input type="hidden" name="tool_id" value="${tool.id}" /> %for i, inputs in enumerate( tool.inputs_by_page ): %if tool.has_multiple_pages:

1 0