1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/6face40d6883/
changeset: 6face40d6883
user: greg
date: 2012-07-03 22:06:11
summary: Filter out unwanted tool shed repositores from the list of valid repositories in the tool shed.
affected #: 1 file
diff -r ab1e5f08593151b35979b7371d001b50d0d3b39f -r 6face40d68836de96bf92d46c0d6e6bf32cdb616 lib/galaxy/webapps/community/controllers/repository.py
--- a/lib/galaxy/webapps/community/controllers/repository.py
+++ b/lib/galaxy/webapps/community/controllers/repository.py
@@ -245,6 +245,19 @@
filterable="standard" ) )
operations = []
def build_initial_query( self, trans, **kwd ):
+ # The clause_list approach is to filter out those repositories that include metadata, but only because they contain 'invalid_tools' in
+ # the metadata (i.e., they don't have valid tools, datatypes or workflows). Is there a better approach?
+ clause_list = []
+ for repository_metadata in trans.sa_session.query( trans.model.RepositoryMetadata ) \
+ .filter( trans.model.RepositoryMetadata.table.c.malicious == False ):
+ metadata = repository_metadata.metadata
+ if 'datatypes' in metadata or'tools' in metadata or 'workflows' in metadata:
+ clause_list.append( trans.model.RepositoryMetadata.table.c.id == repository_metadata.id )
+ if clause_list:
+ return trans.sa_session.query( self.model_class ) \
+ .join( model.RepositoryMetadata.table ) \
+ .join( model.User.table ) \
+ .filter( or_( *clause_list ) )
return trans.sa_session.query( self.model_class ) \
.join( model.RepositoryMetadata.table ) \
.join( model.User.table )
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/4bea5ec54ec4/
changeset: 4bea5ec54ec4
user: greg
date: 2012-07-03 20:42:52
summary: Fix definition of missing tool dependencies.
affected #: 1 file
diff -r c4bdfbf9b3270809754fc075bf0af9b9a3d49f3c -r 4bea5ec54ec4022da1fd49bb616304e4e4b1ec6c lib/galaxy/model/__init__.py
--- a/lib/galaxy/model/__init__.py
+++ b/lib/galaxy/model/__init__.py
@@ -2720,9 +2720,7 @@
"""Return the repository's tool dependencies that are not currently installed, and may not ever have been installed."""
missing_dependencies = []
for tool_dependency in self.tool_dependencies:
- if tool_dependency.status in [ ToolDependency.installation_status.NEVER_INSTALLED,
- ToolDependency.installation_status.ERROR,
- ToolDependency.installation_status.UNINSTALLED ]:
+ if tool_dependency.status not in [ ToolDependency.installation_status.INSTALLED ]:
missing_dependencies.append( tool_dependency )
return missing_dependencies
@property
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/c4bdfbf9b327/
changeset: c4bdfbf9b327
user: greg
date: 2012-07-03 20:03:46
summary: Fix column layout for tool dependencies.
affected #: 1 file
diff -r 31564ea924e7911a04eecc9157d1817d68febd97 -r c4bdfbf9b3270809754fc075bf0af9b9a3d49f3c templates/webapps/community/repository/common.mako
--- a/templates/webapps/community/repository/common.mako
+++ b/templates/webapps/community/repository/common.mako
@@ -105,8 +105,8 @@
<table class="grid"><tr><td><b>name</b></td>
+ <td><b>version</b></td><td><b>type</b></td>
- <td><b>version</b></td></tr>
%for dependency_key, requirements_dict in tool_dependencies.items():
<%
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/3965354dda0b/
changeset: 3965354dda0b
user: greg
date: 2012-07-03 17:38:48
summary: Fixes for inspecting tool dependencies associated with a specified installed tool shed repository.
affected #: 2 files
diff -r 8fd408407f7e48b917d14803c8ef61eaf10ca62c -r 3965354dda0b11768ae0c8c1ff5c33313bf98ee4 lib/galaxy/util/shed_util.py
--- a/lib/galaxy/util/shed_util.py
+++ b/lib/galaxy/util/shed_util.py
@@ -975,6 +975,16 @@
def get_tool_dependency( trans, id ):
"""Get a tool_dependency from the database via id"""
return trans.sa_session.query( trans.model.ToolDependency ).get( trans.security.decode_id( id ) )
+def get_tool_dependency_ids( as_string=False, **kwd ):
+ tool_dependency_id = kwd.get( 'tool_dependency_id', None )
+ tool_dependency_ids = util.listify( kwd.get( 'tool_dependency_ids', None ) )
+ if not tool_dependency_ids:
+ tool_dependency_ids = util.listify( kwd.get( 'id', None ) )
+ if tool_dependency_id and tool_dependency_id not in tool_dependency_ids:
+ tool_dependency_ids.append( tool_dependency_id )
+ if as_string:
+ return ','.join( tool_dependency_ids )
+ return tool_dependency_ids
def get_tool_panel_config_tool_path_install_dir( app, repository ):
# Return shed-related tool panel config, the tool_path configured in it, and the relative path to the directory where the
# repository is installed. This method assumes all repository tools are defined in a single shed-related tool panel config.
diff -r 8fd408407f7e48b917d14803c8ef61eaf10ca62c -r 3965354dda0b11768ae0c8c1ff5c33313bf98ee4 lib/galaxy/web/controllers/admin_toolshed.py
--- a/lib/galaxy/web/controllers/admin_toolshed.py
+++ b/lib/galaxy/web/controllers/admin_toolshed.py
@@ -262,7 +262,7 @@
model.ToolDependency.installation_status.ERROR ] ) )
]
def build_initial_query( self, trans, **kwd ):
- tool_dependency_ids = util.listify( kwd.get( 'tool_dependency_ids', None ) )
+ tool_dependency_ids = get_tool_dependency_ids( as_string=False, **kwd )
if tool_dependency_ids:
clause_list = []
for tool_dependency_id in tool_dependency_ids:
@@ -1067,12 +1067,7 @@
params = util.Params( kwd )
message = util.restore_text( params.get( 'message', '' ) )
status = params.get( 'status', 'done' )
- tool_dependency_id = params.get( 'tool_dependency_id', None )
- tool_dependency_ids = util.listify( params.get( 'tool_dependency_ids', None ) )
- if not tool_dependency_ids:
- tool_dependency_ids = util.listify( params.get( 'id', None ) )
- if tool_dependency_id and tool_dependency_id not in tool_dependency_ids:
- tool_dependency_ids.append( tool_dependency_id )
+ tool_dependency_ids = get_tool_dependency_ids( as_string=False, **kwd )
# We need a tool_shed_repository, so get it from one of the tool_dependencies.
tool_dependency = get_tool_dependency( trans, tool_dependency_ids[ 0 ] )
tool_shed_repository = tool_dependency.tool_shed_repository
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/cf4b47cde5e5/
changeset: cf4b47cde5e5
user: greg
date: 2012-07-03 16:47:50
summary: Fixes for finding installed tool dependencies.
affected #: 2 files
diff -r bd24fd95ae9726e789d314bac2433ed07d0e1abe -r cf4b47cde5e5505a4f7fd1e9557ef4187ecea491 lib/galaxy/tools/__init__.py
--- a/lib/galaxy/tools/__init__.py
+++ b/lib/galaxy/tools/__init__.py
@@ -2358,7 +2358,7 @@
"""
commands = []
if self.tool_shed_repository:
- installed_tool_dependencies = self.tool_shed_repository.tool_dependencies
+ installed_tool_dependencies = self.tool_shed_repository.installed_tool_dependencies
else:
installed_tool_dependencies = None
for requirement in self.requirements:
@@ -2371,8 +2371,6 @@
version=requirement.version,
type=requirement.type,
installed_tool_dependencies=installed_tool_dependencies )
- if requirement.type == 'package':
- script_file, base_path, version = self.app.toolbox.dependency_manager.find_dep( requirement.name, requirement.version )
if script_file is None and base_path is None:
log.warn( "Failed to resolve dependency on '%s', ignoring", requirement.name )
elif script_file is None:
diff -r bd24fd95ae9726e789d314bac2433ed07d0e1abe -r cf4b47cde5e5505a4f7fd1e9557ef4187ecea491 lib/galaxy/tools/deps/__init__.py
--- a/lib/galaxy/tools/deps/__init__.py
+++ b/lib/galaxy/tools/deps/__init__.py
@@ -45,10 +45,9 @@
installed_dependency = None
if installed_tool_dependencies:
for installed_tool_dependency in installed_tool_dependencies:
- if not installed_tool_dependency.uninstalled:
- if installed_tool_dependency.name==name and installed_tool_dependency.version==version and installed_tool_dependency.type==type:
- installed_dependency = installed_tool_dependency
- break
+ if installed_tool_dependency.name==name and installed_tool_dependency.version==version and installed_tool_dependency.type==type:
+ installed_dependency = installed_tool_dependency
+ break
for base_path in self.base_paths:
if installed_dependency:
tool_shed_repository = installed_dependency.tool_shed_repository
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/changeset/bd24fd95ae97/
changeset: bd24fd95ae97
user: greg
date: 2012-07-03 16:19:00
summary: Template bug fix introduced in my last change set.
affected #: 1 file
diff -r b1cdad4c77fa52d939901b1afb56f910f0753088 -r bd24fd95ae9726e789d314bac2433ed07d0e1abe templates/admin/tool_shed_repository/tool_dependency_installation_status.mako
--- a/templates/admin/tool_shed_repository/tool_dependency_installation_status.mako
+++ b/templates/admin/tool_shed_repository/tool_dependency_installation_status.mako
@@ -10,7 +10,7 @@
elif tool_dependency.status in [ trans.model.ToolDependency.installation_status.INSTALLED ]:
bgcolor = trans.model.ToolDependency.states.OK
rval = '<div class="count-box state-color-%s" id="ToolDependencyStatus-%s">%s</div>' % \
- ( bgcolor, trans.security.encode_id( tool_dependency.id, tool_dependency.status ) )
+ ( bgcolor, trans.security.encode_id( tool_dependency.id ), tool_dependency.status )
return rval
%>
${rval}
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.