1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/a60d756aeb5d/
Changeset: a60d756aeb5d
User: carlfeberhard
Date: 2013-08-28 20:22:27
Summary: Datatypes: temporarily remove graph datatype sniffers (f3a985005267) until they can be made more discriminating
Affected #: 1 file
diff -r 22a4f03c1fe40dedcb7e6f11510d58ada8e9c458 -r a60d756aeb5d40c62854fda8a5f5be274762cd86 datatypes_conf.xml.sample
--- a/datatypes_conf.xml.sample
+++ b/datatypes_conf.xml.sample
@@ -285,9 +285,6 @@
<sniffer type="galaxy.datatypes.tabular:Sam"/><sniffer type="galaxy.datatypes.data:Newick"/><sniffer type="galaxy.datatypes.data:Nexus"/>
- <sniffer type="galaxy.datatypes.graph:Xgmml"/>
- <sniffer type="galaxy.datatypes.graph:Sif"/>
- <sniffer type="galaxy.datatypes.graph:Rdf"/><sniffer type="galaxy.datatypes.images:Jpg"/><sniffer type="galaxy.datatypes.images:Png"/><sniffer type="galaxy.datatypes.images:Tiff"/>
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/22a4f03c1fe4/
Changeset: 22a4f03c1fe4
User: Dave Bouvier
Date: 2013-08-28 15:54:45
Summary: Handle the case where the repository being installed has a newer downloadable changeset revision available. (Generally restricted to the new tool_dependency_definition repository type)
Affected #: 1 file
diff -r 29110e49c311339c521525f0b0884ce8eb172129 -r 22a4f03c1fe40dedcb7e6f11510d58ada8e9c458 lib/tool_shed/galaxy_install/repository_util.py
--- a/lib/tool_shed/galaxy_install/repository_util.py
+++ b/lib/tool_shed/galaxy_install/repository_util.py
@@ -214,24 +214,39 @@
def get_repo_info_dict( trans, repository_id, changeset_revision ):
repository = suc.get_repository_in_tool_shed( trans, repository_id )
+ repo_dir = repository.repo_path( trans.app )
+ repo = hg.repository( suc.get_configured_ui(), repo_dir )
repository_clone_url = suc.generate_clone_url_for_repository_in_tool_shed( trans, repository )
repository_metadata = suc.get_repository_metadata_by_changeset_revision( trans, repository_id, changeset_revision )
- metadata = repository_metadata.metadata
- if 'tools' in metadata:
- includes_tools = True
+ if not repository_metadata:
+ # The received changeset_revision is no longer installable, so get the next changeset_revision in the repository's changelog.
+ # This generally occurs only with repositories of type tool_dependency_definition.
+ next_downloadable_changeset_revision = suc.get_next_downloadable_changeset_revision( repository, repo, changeset_revision )
+ if next_downloadable_changeset_revision:
+ repository_metadata = suc.get_repository_metadata_by_changeset_revision( trans, repository_id, next_downloadable_changeset_revision )
+ if repository_metadata:
+ # For now, we'll always assume that we'll get repository_metadata, but if we discover our assumption is not valid we'll have to
+ # enhance the callers to handle repository_metadata values of None in the returned repo_info_dict.
+ metadata = repository_metadata.metadata
+ if 'tools' in metadata:
+ includes_tools = True
+ else:
+ includes_tools = False
+ includes_tools_for_display_in_tool_panel = repository_metadata.includes_tools_for_display_in_tool_panel
+ if 'repository_dependencies' in metadata:
+ has_repository_dependencies = True
+ else:
+ has_repository_dependencies = False
+ if 'tool_dependencies' in metadata:
+ includes_tool_dependencies = True
+ else:
+ includes_tool_dependencies = False
else:
+ # Here's where we may have to handle enhancements to the callers. See above comment.
includes_tools = False
- includes_tools_for_display_in_tool_panel = repository_metadata.includes_tools_for_display_in_tool_panel
- if 'repository_dependencies' in metadata:
- has_repository_dependencies = True
- else:
has_repository_dependencies = False
- if 'tool_dependencies' in metadata:
- includes_tool_dependencies = True
- else:
includes_tool_dependencies = False
- repo_dir = repository.repo_path( trans.app )
- repo = hg.repository( suc.get_configured_ui(), repo_dir )
+ includes_tools_for_display_in_tool_panel = False
ctx = suc.get_changectx_for_changeset( repo, changeset_revision )
repo_info_dict = create_repo_info_dict( trans=trans,
repository_clone_url=repository_clone_url,
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/29110e49c311/
Changeset: 29110e49c311
User: dan
Date: 2013-08-27 22:21:16
Summary: Add pipe (|) to the set of VALID_CHARS in shed_util_common.py. Fixes an issue with e.g. ReST display. TODO: Revisit this method and its usage throughout the toolshed and the toolshed interaction with Galaxy: e.g. is it still needed everywhere it is being used, and is it still doing what it is supposed to be doing?
Affected #: 1 file
diff -r f8b3dbe32435516af63e449cedb2e2fc9eb5bf26 -r 29110e49c311339c521525f0b0884ce8eb172129 lib/tool_shed/util/shed_util_common.py
--- a/lib/tool_shed/util/shed_util_common.py
+++ b/lib/tool_shed/util/shed_util_common.py
@@ -37,7 +37,7 @@
INITIAL_CHANGELOG_HASH = '000000000000'
MAX_CONTENT_SIZE = 1048576
MAX_DISPLAY_SIZE = 32768
-VALID_CHARS = set( string.letters + string.digits + "'\"-=_.()/+*^,:?!#[]%\\$@;{}&<>" )
+VALID_CHARS = set( string.letters + string.digits + "'\"-=_.()/+*^,:?!#[]%\\$@;{}&<>|" )
DATATYPES_CONFIG_FILENAME = 'datatypes_conf.xml'
REPOSITORY_DATA_MANAGER_CONFIG_FILENAME = 'data_manager_conf.xml'
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/6dfd50e1cfd1/
Changeset: 6dfd50e1cfd1
User: Dave Bouvier
Date: 2013-08-27 19:50:30
Summary: Correctly handle the case where a repository installs correctly, but it depends on a repository with a tool dependency that is in an error state.
Affected #: 1 file
diff -r 6439459c265ea7748ff9a16706fa5af5cc224269 -r 6dfd50e1cfd1e2b9f356cb9e9319f85caf6a74f3 test/install_and_test_tool_shed_repositories/functional_tests.py
--- a/test/install_and_test_tool_shed_repositories/functional_tests.py
+++ b/test/install_and_test_tool_shed_repositories/functional_tests.py
@@ -269,6 +269,14 @@
url += '&%s' % params
return url
+def get_failed_tool_dependencies( repository ):
+ missing_dependencies = repository.missing_tool_dependencies
+ for repository_dependency in repository.repository_dependencies:
+ if not repository_dependency.includes_tool_dependencies:
+ continue
+ missing_dependencies.extend( get_failed_tool_dependencies( repository_dependency ) )
+ return missing_dependencies
+
def get_latest_downloadable_changeset_revision( url, name, owner ):
api_url_parts = [ 'api', 'repositories', 'get_ordered_installable_revisions' ]
params = urllib.urlencode( dict( name=name, owner=owner ) )
@@ -459,7 +467,7 @@
Update the repository metadata tool_test_results and appropriate flags using the API.
'''
params[ 'tool_test_results' ] = test_results_dict
- if '-info_only' in sys.argv:
+ if '-info_only' in sys.argv or 'GALAXY_INSTALL_TEST_INFO_ONLY' in os.environ:
return {}
else:
return update( tool_shed_api_key, '%s' % ( url_join( galaxy_tool_shed_url, 'api', 'repository_revisions', metadata_id ) ), params, return_formatted=False )
@@ -914,7 +922,7 @@
# "reason": "The Galaxy development team has determined that this repository should not be installed and tested by the automated framework."
# }
# }
- failed_tool_dependencies = repository.includes_tool_dependencies and repository.tool_dependencies_with_installation_errors
+ failed_tool_dependencies = get_failed_tool_dependencies( repository )
failed_repository_dependencies = repository.repository_dependencies_with_installation_errors
if 'missing_test_components' not in repository_status:
repository_status[ 'missing_test_components' ] = []
@@ -958,7 +966,7 @@
log.error( 'One or more tool dependencies of this repository are marked as missing.' )
log.error( 'Updating repository and skipping functional tests.' )
# In keeping with the standard display layout, add the error message to the dict for each tool individually.
- for dependency in repository.tool_dependencies_with_installation_errors:
+ for dependency in failed_tool_dependencies:
test_result = dict( type=dependency.type,
name=dependency.name,
version=dependency.version,
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.