1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/16bf4453c97a/
Changeset: 16bf4453c97a
User: jmchilton
Date: 2014-05-24 00:20:55
Summary: Add some more colllection creation logging.
Bug report from takadonet of collection request with 280 items only creating 60 - want to know if request got chopped off by proxy or paste, there was some logic error in my code, or if it hit some sort of db/transaction limit. This logging should help dianose that (hopefully). If I find the bug, I will remove this extra logging.
Affected #: 2 files
diff -r f04bc600a672c5495dc7c7356bffcf436f843a93 -r 16bf4453c97a108105930e7f5d6cbf39151316fd lib/galaxy/dataset_collections/__init__.py
--- a/lib/galaxy/dataset_collections/__init__.py
+++ b/lib/galaxy/dataset_collections/__init__.py
@@ -76,6 +76,7 @@
trans.sa_session.add( output_dataset )
dataset_collection_instance.implicit_output_name = implicit_collection_info[ "implicit_output_name" ]
+ log.debug("Created collection with %d elements" % ( len( dataset_collection_instance.collection.elements ) ) )
# Handle setting hid
parent.add_dataset_collection( dataset_collection_instance )
elif isinstance( parent, model.LibraryFolder ):
diff -r f04bc600a672c5495dc7c7356bffcf436f843a93 -r 16bf4453c97a108105930e7f5d6cbf39151316fd lib/galaxy/dataset_collections/util.py
--- a/lib/galaxy/dataset_collections/util.py
+++ b/lib/galaxy/dataset_collections/util.py
@@ -2,6 +2,9 @@
from galaxy import web
from galaxy import model
+import logging
+log = logging.getLogger( __name__ )
+
ERROR_MESSAGE_UNKNOWN_SRC = "Unknown dataset source (src) %s."
ERROR_MESSAGE_NO_NESTED_IDENTIFIERS = "Dataset source new_collection requires nested element_identifiers for new collection."
ERROR_MESSAGE_NO_NAME = "Cannot load invalid dataset identifier - missing name - %s"
@@ -32,6 +35,7 @@
""" Scan through the list of element identifiers supplied by the API consumer
and verify the structure is valid.
"""
+ log.debug( "Validating %d element identifiers for collection creation." % len( element_identifiers ) )
for element_identifier in element_identifiers:
if "__object__" in element_identifier:
message = ERROR_MESSAGE_INVALID_PARAMETER_FOUND % ( "__model_object__", element_identifier )
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/1a38b9cf737f/
Changeset: 1a38b9cf737f
User: dannon
Date: 2014-05-23 18:42:29
Summary: Add noqa comments to prevent pep8 from asking folks to change == to 'is' here.
Affected #: 1 file
diff -r 1283375984ac83ce18e5a78259b12d49cf86d58d -r 1a38b9cf737f9b54a992e973b124daf73cf32acc lib/galaxy/webapps/galaxy/api/users.py
--- a/lib/galaxy/webapps/galaxy/api/users.py
+++ b/lib/galaxy/webapps/galaxy/api/users.py
@@ -30,12 +30,12 @@
if f_email:
query = query.filter(trans.app.model.User.email.like("%%%s%%" % f_email))
if deleted:
- query = query.filter( trans.app.model.User.table.c.deleted == True )
+ query = query.filter( trans.app.model.User.table.c.deleted == True ) # noqa
# only admins can see deleted users
if not trans.user_is_admin():
return []
else:
- query = query.filter( trans.app.model.User.table.c.deleted == False )
+ query = query.filter( trans.app.model.User.table.c.deleted == False ) # noqa
# special case: user can see only their own user
if not trans.user_is_admin():
item = trans.user.to_dict( value_mapper={ 'id': trans.security.encode_id } )
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.