- galaxy-commits - lists.galaxyproject.org

galaxy-dist commit c0feb970e48d: sample tracking bug fixes
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User rc # Date 1287000426 14400 # Node ID c0feb970e48de8b713a9a516cad61950ed0641b5 # Parent 77e13329ab8b9e69089400259eb70cda9525ec80 sample tracking bug fixes --- a/templates/admin/requests/rename_datasets.mako +++ b/templates/admin/requests/rename_datasets.mako @@ -3,15 +3,14 @@ <% from galaxy.web.controllers.requests_admin import build_rename_datasets_for_sample_select_field %> -<br/><br/> -<font color="red"><b><i>A dataset can be renamed only if its status is "Not Started"</i></b></font> +<h3>Rename datasets for Sample "${sample.name}"</h3><ul class="manage-table-actions"><li><a class="action-button" href="${h.url_for( controller='requests_admin', action='manage_datasets', sample_id=trans.security.encode_id( sample.id ) )}">Browse datasets</a></li><li> - <a class="action-button" href="${h.url_for( controller='requests_common', action='manage_request', cntrller=cntrller, id=trans.security.encode_id( sample.request.id ) )}">Browse this request</a> + <a class="action-button" href="${h.url_for( controller='requests_common', action='manage_request', cntrller='requests_admin', id=trans.security.encode_id( sample.request.id ) )}">Browse this request</a></li></ul> @@ -19,40 +18,39 @@ ${render_msg( message, status )} %endif +${render_msg( 'A dataset can be renamed only if it is in <b>Not Started</b> state.', 'warning' )} <div class="toolForm"> - <div class="toolFormTitle">Rename datasets for Sample "${sample.name}"</div> - <div class="toolFormBody"> - <form name="rename_datasets" id="rename_datasets" action="${h.url_for( controller='requests_admin', action='rename_datasets', id_list=id_list, sample_id=trans.security.encode_id( sample.id ) )}" method="post" > - <table class="grid"> - <thead> - <tr> - <th>Prepend directory name</th> - <th>Name</th> - <th>Path on sequencer</th> - </tr> - <thead> - <tbody> - %for sample_dataset in sample_datasets: - %if sample_dataset.status == trans.app.model.Sample.transfer_status.NOT_STARTED: - <tr> - <td> - <% rename_datasets_for_sample_select_field = build_rename_datasets_for_sample_select_field( trans, sample_dataset ) %> - ${rename_datasets_for_sample_select_field} - </td> - <td> - <input type="text" name="new_name_${trans.security.encode_id( sample_dataset.id} )" value="${sample_dataset.name}" size="100"/> - </td> - <td>${sample_dataset.file_path}</td> - </tr> - %endif - %endfor - </tbody> - </table> - <br/> - <div class="form-row"> - <input type="submit" name="rename_datasets_button" value="Save"/> - <input type="submit" name="cancel_rename_datasets_button" value="Close"/> - </div> - </form> - </div> + <form name="rename_datasets" id="rename_datasets" action="${h.url_for( controller='requests_admin', action='rename_datasets', id_list=id_list, sample_id=trans.security.encode_id( sample.id ) )}" method="post" > + <table class="grid"> + <thead> + <tr> + <th>Prepend directory name</th> + <th>Name</th> + <th>Path on sequencer</th> + </tr> + <thead> + <tbody> + %for id in id_list: + <% sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( id ) ) %> + %if sample_dataset.status == trans.app.model.Sample.transfer_status.NOT_STARTED: + <tr> + <td> + <% rename_datasets_for_sample_select_field = build_rename_datasets_for_sample_select_field( trans, sample_dataset ) %> + ${rename_datasets_for_sample_select_field.get_html()} + </td> + <td> + <input type="text" name="new_name_${trans.security.encode_id( sample_dataset.id ) }" value="${sample_dataset.name}" size="100"/> + </td> + <td>${sample_dataset.file_path}</td> + </tr> + %endif + %endfor + </tbody> + </table> + <br/> + <div class="form-row"> + <input type="submit" name="rename_datasets_button" value="Save"/> + <input type="submit" name="cancel_rename_datasets_button" value="Close"/> + </div> + </form></div> --- a/lib/galaxy/web/controllers/requests_common.py +++ b/lib/galaxy/web/controllers/requests_common.py @@ -105,8 +105,7 @@ class RequestsGrid( grids.Grid ): class RequestsCommon( BaseController, UsesFormDefinitionWidgets ): @web.json - def sample_state_updates( self, trans, ids=None, states=None, cntrller=None ): - # TODO fix this mthod - cntrller is required in the signature. + def sample_state_updates( self, trans, cntrller, ids=None, states=None ): # Avoid caching trans.response.headers['Pragma'] = 'no-cache' trans.response.headers['Expires'] = '0' @@ -424,13 +423,19 @@ class RequestsCommon( BaseController, Us except: invalid_id_redirect( trans, cntrller, folder_id ) for sample_id in selected_samples: - sample = trans.sa_session.query( trans.model.Sample ).get( sample_id ) + sample = trans.sa_session.query( trans.model.Sample ).get( trans.security.decode_id( sample_id ) ) sample.library = library sample.folder = folder trans.sa_session.add( sample ) trans.sa_session.flush() trans.sa_session.refresh( request ) message = 'Changes made to the selected samples have been saved. ' + return trans.response.send_redirect( web.url_for( controller='requests_common', + action='manage_request', + cntrller=cntrller, + id=request_id, + status=status, + message=message ) ) elif params.get( 'cancel_change_lib_button', False ): return trans.response.send_redirect( web.url_for( controller='requests_common', action='manage_request', @@ -859,7 +864,7 @@ class RequestsCommon( BaseController, Us # The user has selected a sample to copy. library_id = current_samples[ copy_sample_index][ 'library_select_field' ].get_selected( return_value=True ) folder_id = current_samples[ copy_sample_index ][ 'folder_select_field' ].get_selected( return_value=True ) - name = current_samples[ copy_sample_index ][ 'name' ] + '_%i' % ( index+1 ) + name = current_samples[ copy_sample_index ][ 'name' ] + '_%i' % ( len( current_samples ) + 1 ) library_id = 'none' folder_id = 'none' field_values = [ val for val in current_samples[ copy_sample_index ][ 'field_values' ] ] @@ -867,7 +872,7 @@ class RequestsCommon( BaseController, Us # The user has not selected a sample to copy (may just be adding a sample). library_id = None folder_id = None - name = 'Sample_%i' % ( sample_index+1 ) + name = 'Sample_%i' % ( len( current_samples ) + 1 ) field_values = [ '' for field in request.type.sample_form.fields ] # Build the library_select_field and folder_select_field for the new sample being added. library_select_field, folder_select_field = self.__build_library_and_folder_select_fields( trans, --- a/lib/galaxy/web/controllers/requests_admin.py +++ b/lib/galaxy/web/controllers/requests_admin.py @@ -9,11 +9,13 @@ import logging, os, pexpect, ConfigParse log = logging.getLogger( __name__ ) -class UserColumn( grids.TextColumn ): - def get_value( self, trans, grid, request ): - return request.user.email + class AdminRequestsGrid( RequestsGrid ): + class UserColumn( grids.TextColumn ): + def get_value( self, trans, grid, request ): + return request.user.email + # Grid definition columns = [ col for col in RequestsGrid.columns ] columns.append( UserColumn( "User", model_class=model.User, @@ -180,7 +182,7 @@ class RequestsAdmin( BaseController, Use @web.json def get_file_details( self, trans, id, folder_path ): def print_ticks( d ): - # TODO: why is this method here? Add comments! + # pexpect timeout method pass # Avoid caching trans.response.headers['Pragma'] = 'no-cache' @@ -243,16 +245,20 @@ class RequestsAdmin( BaseController, Use if not sample_dataset_id: return invalid_id_redirect( trans, 'requests_admin', sample_dataset_id ) id_list = util.listify( sample_dataset_id ) + selected_sample_datasets = [] + for sample_dataset_id in id_list: + try: + selected_sample_datasets.append( trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( sample_dataset_id ) ) ) + except: + return invalid_id_redirect( trans, 'requests_admin', sample_dataset_id ) if operation == "view": - sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( sample_dataset_id ) ) return trans.fill_template( '/admin/requests/dataset.mako', - sample_dataset=sample_dataset ) + sample_dataset=selected_sample_datasets[0] ) elif operation == "delete": not_deleted = [] - for sample_dataset_id in id_list: - sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( sample_dataset_id ) ) - sample_id = sample_dataset.sample_id - if sample_dataset.status == sample_dataset.sample.transfer_status.NOT_STARTED: + for sample_dataset in selected_sample_datasets: + sample_id = sample_dataset.sample.id + if sample_dataset.status == trans.app.model.Sample.transfer_status.NOT_STARTED: trans.sa_session.delete( sample_dataset ) trans.sa_session.flush() else: @@ -267,13 +273,26 @@ class RequestsAdmin( BaseController, Use status=status, message=message ) ) elif operation == "rename": - sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( sample_dataset_id ) ) + # if none of the selected sample datasets are in the NOT_STARTED state, + # then display error message + flag = True + for sd in selected_sample_datasets: + if sd.status == trans.app.model.Sample.transfer_status.NOT_STARTED: + flag = False + break + if flag: + status = 'error' + message = 'A dataset can be renamed only if it is in the <b>Not Started</b> state.' + return trans.response.send_redirect( web.url_for( controller='requests_admin', + action='manage_datasets', + sample_id=trans.security.encode_id( selected_sample_datasets[0].sample.id ), + status=status, + message=message ) ) return trans.fill_template( '/admin/requests/rename_datasets.mako', - sample=sample_dataset.sample, + sample=selected_sample_datasets[0].sample, id_list=id_list ) elif operation == "start transfer": - sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( sample_dataset_id ) ) - self.__start_datatx( trans, sample_dataset.sample, id_list ) + self.__start_datatx( trans, selected_sample_datasets[0].sample, selected_sample_datasets ) # Render the grid view sample_id = params.get( 'sample_id', None ) try: @@ -340,7 +359,7 @@ class RequestsAdmin( BaseController, Use message = 'Changes saved successfully.' return trans.fill_template( '/admin/requests/rename_datasets.mako', sample=sample, - sample_datasets=sample_datasets, + id_list=id_list, message=message, status=status ) return trans.response.send_redirect( web.url_for( controller='requests_admin', @@ -353,38 +372,48 @@ class RequestsAdmin( BaseController, Use message = util.restore_text( params.get( 'message', '' ) ) status = params.get( 'status', 'done' ) request_id = kwd.get( 'request_id', None ) + files = [] try: request = trans.sa_session.query( trans.model.Request ).get( trans.security.decode_id( request_id ) ) except: return invalid_id_redirect( trans, 'requests_admin', request_id ) - files_list = util.listify( params.get( 'files_list', [] ) ) + selected_files = util.listify( params.get( 'files_list', [] ) ) folder_path = util.restore_text( params.get( 'folder_path', request.type.datatx_info[ 'data_dir' ] ) ) - selected_value = kwd.get( 'sample_id', 'none' ) - sample_id_select_field = self.__build_sample_id_select_field( request, selected_value ) + selected_sample_id = kwd.get( 'sample_id', 'none' ) + sample_id_select_field = self.__build_sample_id_select_field( trans, request, selected_sample_id ) # The __get_files() method redirects here with a status of 'error' and a message if there # was a problem retrieving the files. if folder_path and status != 'error': folder_path = self.__check_path( folder_path ) - sample_id = params.get( 'sample_id', None ) - try: - sample = trans.sa_session.query( trans.model.Sample ).get( trans.security.decode_id( sample_id ) ) - except: - return invalid_id_redirect( trans, 'requests_admin', sample_id ) - # Get the filenames from the remote host - files = self.__get_files( trans, request, folder_path ) - if params.get( 'open_folder', False ): - if len( files_list ) == 1: - folder_path = os.path.join( folder_path, files_list[0] ) - folder_path = self.__check_path( folder_path ) + if params.get( 'folder_up', False ): + if folder_path[-1] == os.sep: + folder_path = os.path.dirname(folder_path[:-1]) + folder_path = self.__check_path( folder_path ) elif params.get( 'select_show_datasets_button', False ) or params.get( 'select_more_button', False ): - sample_dataset_file_names = self.__save_sample_datasets( trans, sample, files_list, folder_path ) + # get the sample these datasets are associated with + try: + sample = trans.sa_session.query( trans.model.Sample ).get( trans.security.decode_id( selected_sample_id ) ) + sample.library.id and sample.folder.id + except: + # if no sample (with associated library & folder) has been selected + status = 'error' + message = 'Select a sample with associated data library and folder before selecting the dataset(s).' + return trans.response.send_redirect( web.url_for( controller='requests_admin', + action='get_data', + request_id=trans.security.encode_id( request.id ), + folder_path=folder_path, + status=status, + message=message ) ) + # save the sample datasets + sample_dataset_file_names = self.__save_sample_datasets( trans, sample, selected_files, folder_path ) if sample_dataset_file_names: message = 'Datasets (%s) have been selected for sample (%s)' % \ ( str( sample_dataset_file_names )[1:-1].replace( "'", "" ), sample.name ) if params.get( 'select_show_datasets_button', False ): return trans.response.send_redirect( web.url_for( controller='requests_admin', action='manage_datasets', - sample_id=sample_id, + request_id=request_id, + sample_id=trans.security.encode_id( sample.id ), message=message, status=status ) ) else: # 'select_more_button' was clicked @@ -392,11 +421,13 @@ class RequestsAdmin( BaseController, Use action='get_data', request_id=request_id, folder_path=folder_path, - sample_id=sample_id, + sample_id=sample.id, open_folder=True, message=message, status=status ) ) - return trans.fill_template( '/admin/requests/dataset_transfer.mako', + # Get the filenames from the remote host + files = self.__get_files( trans, request, folder_path ) + return trans.fill_template( '/admin/requests/get_data.mako', cntrller='requests_admin', request=request, sample_id_select_field=sample_id_select_field, @@ -434,20 +465,20 @@ class RequestsAdmin( BaseController, Use if ok: return output.splitlines() return trans.response.send_redirect( web.url_for( controller='requests_admin', - action='get_data', - request_id=trans.security.encode_id( request.id ), - folder_path=folder_path, - status=status, - message=message ) ) + action='get_data', + request_id=trans.security.encode_id( request.id ), + folder_path=folder_path, + status=status, + message=message ) ) def __check_path( self, a_path ): # Return a valid folder_path if a_path and not a_path.endswith( os.sep ): a_path += os.sep return a_path - def __save_sample_datasets( self, trans, sample, files_list, folder_path ): + def __save_sample_datasets( self, trans, sample, selected_files, folder_path ): sample_dataset_file_names = [] - if files_list: - for f in files_list: + if selected_files: + for f in selected_files: filepath = os.path.join( folder_path, f ) if f[-1] == os.sep: # FIXME: The selected item is a folder so transfer all the folder contents @@ -522,7 +553,7 @@ class RequestsAdmin( BaseController, Use trans.sa_session.add( lfp ) trans.sa_session.flush() return datatx_user - def __send_message( self, trans, datatx_info, sample, id_list ): + def __send_message( self, trans, datatx_info, sample, selected_sample_datasets ): """Ceates an xml message and sends it to the rabbitmq server""" # Create the xml message based on the following template xml = \ @@ -542,8 +573,7 @@ class RequestsAdmin( BaseController, Use <file>%(FILE)s</file></dataset>''' datasets = '' - for id in id_list: - sample_dataset = trans.sa_session.query( trans.model.SampleDataset ).get( trans.security.decode_id( id ) ) + for sample_dataset in selected_sample_datasets: if sample_dataset.status == sample.transfer_status.NOT_STARTED: datasets = datasets + dataset_xml % dict( ID=str( sample_dataset.id ), NAME=sample_dataset.name, @@ -574,7 +604,7 @@ class RequestsAdmin( BaseController, Use routing_key=trans.app.config.amqp['routing_key'] ) chan.close() conn.close() - def __start_datatx( self, trans, sample, id_list ): + def __start_datatx( self, trans, sample, selected_sample_datasets ): datatx_user = self.__setup_datatx_user( trans, sample.library, sample.folder ) # Validate sequencer information datatx_info = sample.request.type.datatx_info @@ -582,8 +612,8 @@ class RequestsAdmin( BaseController, Use message = "Error in sequencer login information." status = "error" else: - self.__send_message( trans, datatx_info, sample, id_list ) - message = "%i datasets have been queued for transfer from the sequencer. Click the Refresh button above to see the latest transfer status." % len( id_list ) + self.__send_message( trans, datatx_info, sample, selected_sample_datasets ) + message = "%i datasets have been queued for transfer from the sequencer. Click the Refresh button above to see the latest transfer status." % len( selected_sample_datasets ) status = "done" return trans.response.send_redirect( web.url_for( controller='requests_admin', action='manage_datasets', @@ -599,6 +629,14 @@ class RequestsAdmin( BaseController, Use obj_id = kwd.get( 'id', None ) if operation == "view_form_definition": return self.view_form_definition( trans, **kwd ) + elif operation == "view": + return self.view_request_type( trans, **kwd ) + elif operation == "delete": + return self.delete_request_type( trans, **kwd ) + elif operation == "undelete": + return self.undelete_request_type( trans, **kwd ) + elif operation == "permissions": + return self.request_type_permissions( trans, **kwd ) # Render the grid view return self.requesttype_grid( trans, **kwd ) @web.expose @@ -655,26 +693,26 @@ class RequestsAdmin( BaseController, Use message=message, status=status ) def __create_request_type_form( self, trans, **kwd ): - request_form_definitionss = self.get_all_forms( trans, + request_form_definitions = self.get_all_forms( trans, filter=dict( deleted=False ), form_type=trans.model.FormDefinition.types.REQUEST ) sample_form_definitions = self.get_all_forms( trans, filter=dict( deleted=False ), form_type=trans.model.FormDefinition.types.SAMPLE ) - if not request_form_definitionss or not sample_form_definitions: + if not request_form_definitions or not sample_form_definitions: return [],[] params = util.Params( kwd ) request_form_id = params.get( 'request_form_id', 'none' ) sample_form_id = params.get( 'sample_form_id', 'none' ) request_form_id_select_field = build_select_field( trans, - objs=request_form_definitionss, - label_attr='id', + objs=request_form_definitions, + label_attr='name', select_field_name='request_form_id', selected_value=request_form_id, refresh_on_change=False ) sample_form_id_select_field = build_select_field( trans, objs=sample_form_definitions, - label_attr='id', + label_attr='name', select_field_name='sample_form_id', selected_value=sample_form_id, refresh_on_change=False ) @@ -826,7 +864,7 @@ class RequestsAdmin( BaseController, Use status=status, message=message ) # ===== Methods for building SelectFields used on various admin_requests forms - def __build_sample_id_select_field( self, request, selected_value ): + def __build_sample_id_select_field( self, trans, request, selected_value ): return build_select_field( trans, request.samples, 'name', 'sample_id', selected_value=selected_value, refresh_on_change=False ) def __build_rename_dataset_select_field( self, trans, request_type=None ): if request_type: --- a/templates/admin/requests/get_data.mako +++ b/templates/admin/requests/get_data.mako @@ -68,13 +68,6 @@ } </script> -<style type="text/css"> -.msg_head { - padding: 0px 0px; - cursor: pointer; -} -</style> - <br/><br/><ul class="manage-table-actions"> @@ -92,7 +85,7 @@ <div class="toolForm"><div class="toolFormTitle">Select files for transfer</div> - <form name="get_data" id="get_data" action="${h.url_for( controller='requests_admin', action='get_data', cntrller=cntrller, request_id=trans.security.encode_id( request.id )}" method="post" > + <form name="get_data" id="get_data" action="${h.url_for( controller='requests_admin', action='get_data', cntrller=cntrller, request_id=trans.security.encode_id( request.id ))}" method="post" ><div class="form-row"><label>Sample:</label> ${sample_id_select_field.get_html()} --- a/templates/requests/common/manage_request.mako +++ b/templates/requests/common/manage_request.mako @@ -62,7 +62,7 @@ // Build request data var ids = [] var states = [] - $.each( sample_states, function ( id, state ) { + $.each( sample_states, function ( id, state, cntrller ) { ids.push( id ); states.push( state ); }); @@ -73,7 +73,7 @@ dataType: "json", data: { ids: ids.join( "," ), states: states.join( "," ) }, success : function ( data ) { - $.each( data, function(id, val, cntrller ) { + $.each( data, function( cntrller, id, val ) { // Replace HTML var cell1 = $("#sampleState-" + id); cell1.html( val.html_state ); @@ -146,8 +146,6 @@ </div><br/><br/> -<font color="red"><b><i>A dataset can be renamed only if its status is "Not Started"</i></b></font> - <ul class="manage-table-actions"><li><a class="action-button" id="seqreq-${request.id}-popup" class="menubutton">Sequencing Request Actions</a></li><div popupmenu="seqreq-${request.id}-popup">

1 0

galaxy-dist commit c4c2b6eea3e1: Added support for BLAST+ -max_target_seqs option
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286381268 -3600 # Node ID c4c2b6eea3e11ee8a024b32f58419f7b1d36f114 # Parent 9bf65ebafa8fc89115a5b42ebb9865ed99c1cf84 Added support for BLAST+ -max_target_seqs option --- a/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml @@ -3,7 +3,8 @@ <command> ## The command is a Cheetah template which allows some Python based syntax. ## Lines starting hash hash are comments. Galaxy will turn newlines into spaces -blastn -query "$query" +blastn +-query "$query" #if $db_opts.db_opts_selector == "db": -db "$db_opts.database" #else: @@ -16,6 +17,11 @@ blastn -query "$query" -out $output1 -outfmt $out_format -num_threads 8 +## Need int(str(...)) because $adv_opts.max_hits is an InputValueWrapper object not a string +## Note -max_target_seqs overrides -num_descriptions and -num_alignments +#if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): +-max_target_seqs $adv_opts.max_hits +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -62,6 +68,7 @@ blastn -query "$query" <when value="basic"><param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /> + <param name="max_hits" type="hidden" value="" /></when><when value="advanced"> @@ -71,6 +78,10 @@ blastn -query "$query" <option value="-strand plus">Plus (forward)</option><option value="-strand minus">Minus (reverse complement)</option></param> +  + <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -17,6 +17,11 @@ blastp -out $output1 -outfmt $out_format -num_threads 8 +## Need int(str(...)) because $adv_opts.max_hits is an InputValueWrapper object not a string +## Note -max_target_seqs overrides -num_descriptions and -num_alignments +#if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): +-max_target_seqs $adv_opts.max_hits +#end if </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/> @@ -60,6 +65,7 @@ blastp <when value="basic"><param name="filter_query" type="hidden" value="" /><param name="matrix" type="hidden" value="" /> + <param name="max_hits" type="hidden" value="" /></when><when value="advanced"> @@ -74,6 +80,10 @@ blastp <option value="-matrix PAM70">PAM70</option><option value="-matrix PAM30">PAM30</option></param> +  + <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -17,6 +17,11 @@ tblastx -out $output1 -outfmt $out_format -num_threads 8 +## Need int(str(...)) because $adv_opts.max_hits is an InputValueWrapper object not a string +## Note -max_target_seqs overrides -num_descriptions and -num_alignments +#if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): +-max_target_seqs $adv_opts.max_hits +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -57,6 +62,7 @@ tblastx <param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /><param name="matrix" type="hidden" value="" /> + <param name="max_hits" type="hidden" value="" /></when><when value="advanced"> @@ -76,6 +82,10 @@ tblastx <option value="-matrix PAM70">PAM70</option><option value="-matrix PAM30">PAM30</option></param> +  + <param name="max_hits" type="integer" value="0" lable="Maximum hits to show (in plain text output)" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -17,6 +17,11 @@ blastx -out $output1 -outfmt $out_format -num_threads 8 +## Need int(str(...)) because $adv_opts.max_hits is an InputValueWrapper object not a string +## Note -max_target_seqs overrides -num_descriptions and -num_alignments +#if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): +-max_target_seqs $adv_opts.max_hits +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -57,6 +62,7 @@ blastx <param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /><param name="matrix" type="hidden" value="" /> + <param name="max_hits" type="hidden" value="" /></when><when value="advanced"> @@ -76,7 +82,10 @@ blastx <option value="-matrix PAM70">PAM70</option><option value="-matrix PAM30">PAM30</option></param> - +  + <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -16,6 +16,11 @@ tblastn -out $output1 -outfmt $out_format -num_threads 8 +## Need int(str(...)) because $adv_opts.max_hits is an InputValueWrapper object not a string +## Note -max_target_seqs overrides -num_descriptions and -num_alignments +#if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): +-max_target_seqs $adv_opts.max_hits +#end if </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/> @@ -55,6 +60,7 @@ tblastn <when value="basic"><param name="filter_query" type="hidden" value="" /><param name="matrix" type="hidden" value="" /> + <param name="max_hits" type="hidden" value="" /></when><when value="advanced"> @@ -69,6 +75,10 @@ tblastn <option value="-matrix PAM70">PAM70</option><option value="-matrix PAM30">PAM30</option></param> +  + <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs>

1 0

galaxy-dist commit 8979b429d769: Adding a Python script for converting BLAST XML to 12 column tabular
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286551276 -3600 # Node ID 8979b429d7691f4121afb368a05e6b9d0ea40706 # Parent b2906cd2d484a25f80134f432b7c36ed18747bb5 Adding a Python script for converting BLAST XML to 12 column tabular --- /dev/null +++ b/tools/ncbi_blast_plus/blastxml_to_tabular.xml @@ -0,0 +1,41 @@ +<tool id="blastxml_to_tabular" name="BLAST XML to tabular" version="0.0.1"> + <description>Convert BLAST XML output to tabular</description> + <command interpreter="python"> + blastxml_to_tabular.py $blastxml_file $tabular_file + </command> + <inputs> + <param name="blastxml_file" type="data" format="blastxml" label="BLAST results as XML"/> + </inputs> + <outputs> + <data name="tabular_file" format="tabular" label="BLAST results as tabular" /> + </outputs> + <requirements> + </requirements> + <tests> + </tests> + <help> + +**What it does** + +NCBI BLAST+ (and the older NCBI 'legacy' BLAST) can output in a range of formats including +tabular and a more detailed XML format. A complex workflow may need both the XML and the +tabular output. + +This tool takes the BLAST XML output and converts it into the 12 column tabular equivalent: + +1. Id of your sequence +2. GI of the database hit +3. % identity +4. Alignment length +5. # mismatches +6. # gaps +7. Start position in your sequence +8. End position in your sequence +9. Start position in database hit +10. End position in database hit +11. E-value +12. Bit score + + + </help> +</tool> --- /dev/null +++ b/tools/ncbi_blast_plus/blastxml_to_tabular.py @@ -0,0 +1,123 @@ +#!/usr/bin/env python +"""Convert a BLAST XML file to 12 column tabular output + +Takes two command line options, input BLAST XML filename and output tabular +BLAST filename. + +The 12 colums output are 'qseqid sseqid pident length mismatch gapopen qstart +qend sstart send evalue bitscore' which mean: + + * qseqid - Query Seq-id + * sseqid - Subject Seq-id + * pident - Percentage of identical matches + * length - Alignment length + * mismatch - Number of mismatches + * gapopen - Number of gap openings + * qstart - Start of alignment in query + * qend - End of alignment in query + * sstart - Start of alignment in subject + * send - End of alignment in subject + * evalue - Expect value + * bitscore - Bit score + +Most of these fields are given explicitly in the XML file, others some like +the percentage identity and the number of gap openings must be calculated. + +This script attempts to produce idential output to what BLAST+ would have done. +However, check this with "diff -b ..." since BLAST+ sometimes includes an extra +space character (probably a bug). +""" +import sys + +#Parse Command Line +in_file, out_file = sys.argv[1:] + +assert sys.version_info[:2] >= ( 2, 4 ) +if sys.version_info[:2] >= ( 2, 5 ): + import xml.etree.cElementTree as cElementTree +else: + import cElementTree + +def stop_err( msg ): + sys.stderr.write("%s\n" % msg) + sys.exit(1) + +tags = ["Hsp_identity", + "Hsp_align-len", + "Hsp_gaps", + "Hsp_query-from", + "Hsp_query-to", + "Hsp_hit-from", + "Hsp_hit-to", + "Hsp_evalue", + "Hsp_bit-score"] + +# get an iterable +try: + context = cElementTree.iterparse(in_file, events=("start", "end")) +except: + stop_err("Invalid data format.") +# turn it into an iterator +context = iter(context) +# get the root element +try: + event, root = context.next() +except: + stop_err( "Invalid data format." ) + +outfile = open(out_file, 'w') +for event, elem in context: + # for every <Iteration> tag + if event == "end" and elem.tag == "Iteration": + qseqid = elem.findtext("Iteration_query-def").split(None,1)[0] + # for every <Hit> within <Iteration> + for hit in elem.findall("Iteration_hits/Hit/"): + sseqid = hit.findtext("Hit_id").split(None,1)[0] + # for every <Hsp> within <Hit> + for hsp in hit.findall("Hit_hsps/Hsp"): + identity = hsp.findtext("Hsp_identity") + length = hsp.findtext("Hsp_align-len") + pident = "%0.2f" % (100*float(identity)/float(length)) + + q_seq = hsp.findtext("Hsp_qseq") + h_seq = hsp.findtext("Hsp_hseq") + assert len(q_seq) == len(h_seq) == int(length) + gapopen = str(len(q_seq.replace('-', ' ').split())-1 + \ + len(h_seq.replace('-', ' ').split())-1) + mismatch = str(len(q_seq) - sum(1 for q,h in zip(q_seq, h_seq) \ + if q == h or q == "-" or h == "-")) + assert int(identity) == sum(1 for q,h in zip(q_seq, h_seq) if q == h) + + evalue = hsp.findtext("Hsp_evalue") + if evalue == "0": + evalue = "0.0" + else: + evalue = "%0.0e" % float(evalue) + + bitscore = float(hsp.findtext("Hsp_bit-score")) + if bitscore < 100: + #Seems to show one decimal place for lower scores + bitscore = "%0.1f" % bitscore + else: + #Note BLAST does not round to nearest int, it truncates + bitscore = "%i" % bitscore + + values = [qseqid, + sseqid, + pident, + length, #hsp.findtext("Hsp_align-len") + mismatch, + gapopen, + hsp.findtext("Hsp_query-from"), #qstart, + hsp.findtext("Hsp_query-to"), #qend, + hsp.findtext("Hsp_hit-from"), #sstart, + hsp.findtext("Hsp_hit-to"), #send, + evalue, #hsp.findtext("Hsp_evalue") in scientific notation + bitscore, #hsp.findtext("Hsp_bit-score") rounded + ] + #print "\t".join(values) + outfile.write("\t".join(values) + "\n") + # prevents ElementTree from growing large datastructure + root.clear() + elem.clear() +outfile.close()

1 0

galaxy-dist commit b0286178f81d: Fixed silly typo
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286383905 -3600 # Node ID b0286178f81dfcfbfd03e64b2b4fdb347ee75607 # Parent f5f74df868f1dfb369ec723ef2cb9f0926eaa760 Fixed silly typo --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -83,7 +83,7 @@ tblastx <option value="-matrix PAM30">PAM30</option></param> - <param name="max_hits" type="integer" value="0" lable="Maximum hits to show (in plain text output)" help="Use zero for default limits"> + <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"><validator type="in_range" min="0" /></param></when>

1 0

galaxy-dist commit 6273161e76c3: Make BLOSUM62 the default with sensible sorting (tip from Ross Lazarus on mailing list)
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286293953 -3600 # Node ID 6273161e76c33f807145d9b12eafa0a6e414bbf1 # Parent dd7a3707f323bbf38689a24bfcb0b337c3494569 Make BLOSUM62 the default with sensible sorting (tip from Ross Lazarus on mailing list) --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -63,9 +63,9 @@ <param name="filter_query" type="boolean" label="Filter out low complexity regions (with SEG)" truevalue="-seg yes" falsevalue="-seg no" checked="true" /><param name="matrix" type="select" label="Scoring matrix"> - <option value="-matrix BLOSUM62">BLOSUM62 (default)</option><option value="-matrix BLOSUM90">BLOSUM90</option><option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM62" selected="true">BLOSUM62 (default)</option><option value="-matrix BLOSUM50">BLOSUM50</option><option value="-matrix BLOSUM45">BLOSUM45</option><option value="-matrix PAM250">PAM250</option> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -65,9 +65,9 @@ <option value="-strand minus">Minus (reverse complement)</option></param><param name="matrix" type="select" label="Scoring matrix"> - <option value="-matrix BLOSUM62">BLOSUM62 (default)</option><option value="-matrix BLOSUM90">BLOSUM90</option><option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM62" selected="true">BLOSUM62 (default)</option><option value="-matrix BLOSUM50">BLOSUM50</option><option value="-matrix BLOSUM45">BLOSUM45</option><option value="-matrix PAM250">PAM250</option> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -65,15 +65,16 @@ <option value="-strand minus">Minus (reverse complement)</option></param><param name="matrix" type="select" label="Scoring matrix"> - <option value="-matrix BLOSUM62">BLOSUM62 (default)</option><option value="-matrix BLOSUM90">BLOSUM90</option><option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM62" selected="true">BLOSUM62 (default)</option><option value="-matrix BLOSUM50">BLOSUM50</option><option value="-matrix BLOSUM45">BLOSUM45</option><option value="-matrix PAM250">PAM250</option><option value="-matrix PAM70">PAM70</option><option value="-matrix PAM30">PAM30</option></param> + </when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -58,9 +58,9 @@ <param name="filter_query" type="boolean" label="Filter out low complexity regions (with SEG)" truevalue="-seg yes" falsevalue="-seg no" checked="true" /><param name="matrix" type="select" label="Scoring matrix"> - <option value="-matrix BLOSUM62">BLOSUM62 (default)</option><option value="-matrix BLOSUM90">BLOSUM90</option><option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM62" selected="true">BLOSUM62 (default)</option><option value="-matrix BLOSUM50">BLOSUM50</option><option value="-matrix BLOSUM45">BLOSUM45</option><option value="-matrix PAM250">PAM250</option>

1 0

galaxy-dist commit 9bf65ebafa8f: Reduce whitespace in <command> tag (there are OS limits on command line length)
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286366018 -3600 # Node ID 9bf65ebafa8fc89115a5b42ebb9865ed99c1cf84 # Parent 6273161e76c33f807145d9b12eafa0a6e414bbf1 Reduce whitespace in <command> tag (there are OS limits on command line length) --- a/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml @@ -1,20 +1,21 @@ <tool id="ncbi_blastn_wrapper" name="NCBI BLAST+ blastn" version="0.0.1"><description>Search nucleotide database with nucleotide query sequence(s)</description><command> - blastn - -query "$query" +## The command is a Cheetah template which allows some Python based syntax. +## Lines starting hash hash are comments. Galaxy will turn newlines into spaces +blastn -query "$query" #if $db_opts.db_opts_selector == "db": - -db "$db_opts.database" + -db "$db_opts.database" #else: - -subject "$db_opts.subject" + -subject "$db_opts.subject" #end if - -task $blast_type - -evalue $evalue_cutoff - $adv_opts.filter_query - $adv_opts.strand - -out $output1 - -outfmt $out_format - -num_threads 8 +-task $blast_type +-evalue $evalue_cutoff +$adv_opts.filter_query +$adv_opts.strand +-out $output1 +-outfmt $out_format +-num_threads 8 </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -1,20 +1,22 @@ <tool id="ncbi_blastp_wrapper" name="NCBI BLAST+ blastp" version="0.0.1"><description>Search protein database with protein query sequence(s)</description><command> - blastp - -query "$query" +## The command is a Cheetah template which allows some Python based syntax. +## Lines starting hash hash are comments. Galaxy will turn newlines into spaces +blastp +-query "$query" #if $db_opts.db_opts_selector == "db": - -db "$db_opts.database" + -db "$db_opts.database" #else: - -subject "$db_opts.subject" + -subject "$db_opts.subject" #end if - -task $blast_type - -evalue $evalue_cutoff - $adv_opts.filter_query - $adv_opts.matrix - -out $output1 - -outfmt $out_format - -num_threads 8 +-task $blast_type +-evalue $evalue_cutoff +$adv_opts.filter_query +$adv_opts.matrix +-out $output1 +-outfmt $out_format +-num_threads 8 </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -1,20 +1,22 @@ <tool id="ncbi_tblastx_wrapper" name="NCBI BLAST+ tblastx" version="0.0.1"><description>Search translated nucleotide database with translated nucleotide query sequence(s)</description><command> - tblastx - -query "$query" +## The command is a Cheetah template which allows some Python based syntax. +## Lines starting hash hash are comments. Galaxy will turn newlines into spaces +tblastx +-query "$query" #if $db_opts.db_opts_selector == "db": - -db "$db_opts.database" + -db "$db_opts.database" #else: - -subject "$db_opts.subject" + -subject "$db_opts.subject" #end if - -evalue $evalue_cutoff - $adv_opts.filter_query - $adv_opts.strand - $adv_opts.matrix - -out $output1 - -outfmt $out_format - -num_threads 8 +-evalue $evalue_cutoff +$adv_opts.filter_query +$adv_opts.strand +$adv_opts.matrix +-out $output1 +-outfmt $out_format +-num_threads 8 </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -1,20 +1,22 @@ <tool id="ncbi_blastx_wrapper" name="NCBI BLAST+ blastx" version="0.0.1"><description>Search protein database with translated nucleotide query sequence(s)</description><command> - blastx - -query "$query" +## The command is a Cheetah template which allows some Python based syntax. +## Lines starting hash hash are comments. Galaxy will turn newlines into spaces +blastx +-query "$query" #if $db_opts.db_opts_selector == "db": - -db "$db_opts.database" + -db "$db_opts.database" #else: - -subject "$db_opts.subject" + -subject "$db_opts.subject" #end if - -evalue $evalue_cutoff - $adv_opts.filter_query - $adv_opts.strand - $adv_opts.matrix - -out $output1 - -outfmt $out_format - -num_threads 8 +-evalue $evalue_cutoff +$adv_opts.filter_query +$adv_opts.strand +$adv_opts.matrix +-out $output1 +-outfmt $out_format +-num_threads 8 </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -1,19 +1,21 @@ <tool id="ncbi_tblastn_wrapper" name="NCBI BLAST+ tblastn" version="0.0.1"><description>Search translated nucleotide database with protein query sequence(s)</description><command> - tblastn - -query "$query" +## The command is a Cheetah template which allows some Python based syntax. +## Lines starting hash hash are comments. Galaxy will turn newlines into spaces +tblastn +-query "$query" #if $db_opts.db_opts_selector == "db": - -db "$db_opts.database" + -db "$db_opts.database" #else: - -subject "$db_opts.subject" + -subject "$db_opts.subject" #end if - -evalue $evalue_cutoff - $adv_opts.filter_query - $adv_opts.matrix - -out $output1 - -outfmt $out_format - -num_threads 8 +-evalue $evalue_cutoff +$adv_opts.filter_query +$adv_opts.matrix +-out $output1 +-outfmt $out_format +-num_threads 8 </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/>

1 0

galaxy-dist commit b2906cd2d484: Add -word_size as an advanced argument (ideally would be an optional integer with validation)
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286538540 -3600 # Node ID b2906cd2d484a25f80134f432b7c36ed18747bb5 # Parent b0286178f81dfcfbfd03e64b2b4fdb347ee75607 Add -word_size as an advanced argument (ideally would be an optional integer with validation) --- a/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml @@ -22,6 +22,9 @@ blastn #if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): -max_target_seqs $adv_opts.max_hits #end if +#if (str($adv_opts.word_size) and int(str($adv_opts.word_size)) > 0): +-word_size $adv_opts.word_size +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -72,6 +75,7 @@ blastn <param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /><param name="max_hits" type="hidden" value="" /> + <param name="word_size" type="hidden" value="" /></when><when value="advanced"> @@ -82,7 +86,11 @@ blastn <option value="-strand minus">Minus (reverse complement)</option></param> - <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param> +  + <param name="word_size" type="integer" value="0" label="Word size for wordfinder algorithm" help="Use zero for default, otherwise minimum 4."><validator type="in_range" min="0" /></param></when> --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -22,6 +22,9 @@ blastp #if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): -max_target_seqs $adv_opts.max_hits #end if +#if (str($adv_opts.word_size) and int(str($adv_opts.word_size)) > 0): +-word_size $adv_opts.word_size +#end if </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/> @@ -66,6 +69,7 @@ blastp <param name="filter_query" type="hidden" value="" /><param name="matrix" type="hidden" value="" /><param name="max_hits" type="hidden" value="" /> + <param name="word_size" type="hidden" value="" /></when><when value="advanced"> @@ -81,7 +85,11 @@ blastp <option value="-matrix PAM30">PAM30</option></param> - <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param> +  + <param name="word_size" type="integer" value="0" label="Word size for wordfinder algorithm" help="Use zero for default, otherwise minimum 2."><validator type="in_range" min="0" /></param></when> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -22,6 +22,9 @@ tblastx #if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): -max_target_seqs $adv_opts.max_hits #end if +#if (str($adv_opts.word_size) and int(str($adv_opts.word_size)) > 0): +-word_size $adv_opts.word_size +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -63,6 +66,7 @@ tblastx <param name="strand" type="hidden" value="" /><param name="matrix" type="hidden" value="" /><param name="max_hits" type="hidden" value="" /> + <param name="word_size" type="hidden" value="" /></when><when value="advanced"> @@ -86,6 +90,10 @@ tblastx <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"><validator type="in_range" min="0" /></param> +  + <param name="word_size" type="integer" value="0" label="Word size for wordfinder algorithm" help="Use zero for default, otherwise minimum 2."> + <validator type="in_range" min="0" /> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -22,6 +22,9 @@ blastx #if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): -max_target_seqs $adv_opts.max_hits #end if +#if (str($adv_opts.word_size) and int(str($adv_opts.word_size)) > 0): +-word_size $adv_opts.word_size +#end if </command><inputs><param name="query" type="data" format="fasta" label="Nucleotide query sequence(s)"/> @@ -63,6 +66,7 @@ blastx <param name="strand" type="hidden" value="" /><param name="matrix" type="hidden" value="" /><param name="max_hits" type="hidden" value="" /> + <param name="word_size" type="hidden" value="" /></when><when value="advanced"> @@ -83,7 +87,11 @@ blastx <option value="-matrix PAM30">PAM30</option></param> - <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param> +  + <param name="word_size" type="integer" value="0" label="Word size for wordfinder algorithm" help="Use zero for default, otherwise minimum 2."><validator type="in_range" min="0" /></param></when> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -21,6 +21,9 @@ tblastn #if (str($adv_opts.max_hits) and int(str($adv_opts.max_hits)) > 0): -max_target_seqs $adv_opts.max_hits #end if +#if (str($adv_opts.word_size) and int(str($adv_opts.word_size)) > 0): +-word_size $adv_opts.word_size +#end if </command><inputs><param name="query" type="data" format="fasta" label="Protein query sequence(s)"/> @@ -61,6 +64,7 @@ tblastn <param name="filter_query" type="hidden" value="" /><param name="matrix" type="hidden" value="" /><param name="max_hits" type="hidden" value="" /> + <param name="word_size" type="hidden" value="" /></when><when value="advanced"> @@ -76,7 +80,11 @@ tblastn <option value="-matrix PAM30">PAM30</option></param> - <param name="max_hits" type="integer" value="0" lable="Maximum hits to show" help="Use zero for default limits"> + <param name="max_hits" type="integer" value="0" label="Maximum hits to show" help="Use zero for default limits"> + <validator type="in_range" min="0" /> + </param> +  + <param name="word_size" type="integer" value="0" label="Word size for wordfinder algorithm" help="Use zero for default, otherwise minimum 2."><validator type="in_range" min="0" /></param></when>

1 0

galaxy-dist commit 477eb3cceae7: Updated a caption for consistency, removed an old comment
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1285944657 -3600 # Node ID 477eb3cceae79d93be845a8540572033f208ae73 # Parent 36086d5bd8fa174ce88443eeeefec52b8fada5bd Updated a caption for consistency, removed an old comment --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -33,7 +33,7 @@ </when><when value="file"><param name="database" type="hidden" value="" /> - <param name="subject" type="data" format="fasta" label="Protein subject sequence(s)"/> + <param name="subject" type="data" format="fasta" label="Protein FASTA file to use as database"/></when></conditional><param name="evalue_cutoff" type="float" size="15" value="0.001" label="set expectation value cutoff" /> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -59,7 +59,6 @@ </conditional></inputs><outputs> - <data name="output1" format="tabular" label="tblastn on ${db_opts.db_opts_selector}"><change_format><when input="out_format" value="0" format="txt"/>

1 0

galaxy-dist commit 1c8a5958c748: Use dropdown (default) rather than radio for BLAST databases as could be lots of them
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1285945041 -3600 # Node ID 1c8a5958c7481e53e862dbdf44d5367b6f3fc271 # Parent 477eb3cceae79d93be845a8540572033f208ae73 Use dropdown (default) rather than radio for BLAST databases as could be lots of them --- a/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastn_wrapper.xml @@ -24,7 +24,7 @@ <option value="file">FASTA file</option></param><when value="db"> - <param name="database" type="select" display="radio" label="Nucleotide BLAST database"> + <param name="database" type="select" label="Nucleotide BLAST database"><options from_file="blastdb.loc"><column name="name" index="0"/><column name="value" index="1"/> --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -23,7 +23,7 @@ <option value="file">FASTA file</option></param><when value="db"> - <param name="database" type="select" display="radio" label="Protein BLAST database"> + <param name="database" type="select" label="Protein BLAST database"><options from_file="blastdb_p.loc"><column name="name" index="0"/><column name="value" index="1"/> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -23,7 +23,7 @@ <option value="file">FASTA file</option></param><when value="db"> - <param name="database" type="select" display="radio" label="Nucleotide BLAST database"> + <param name="database" type="select" label="Nucleotide BLAST database"><options from_file="blastdb.loc"><column name="name" index="0"/><column name="value" index="1"/> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -23,7 +23,7 @@ <option value="file">FASTA file</option></param><when value="db"> - <param name="database" type="select" display="radio" label="Protein BLAST database"> + <param name="database" type="select" label="Protein BLAST database"><options from_file="blastdb_p.loc"><column name="name" index="0"/><column name="value" index="1"/> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -22,7 +22,7 @@ <option value="file">FASTA file</option></param><when value="db"> - <param name="database" type="select" display="radio" label="Nucleotide BLAST database"> + <param name="database" type="select" label="Nucleotide BLAST database"><options from_file="blastdb.loc"><column name="name" index="0"/><column name="value" index="1"/>

1 0

galaxy-dist commit dd7a3707f323: Add -matrix option to BLASTP, BLASTX, TBLASTN and TBLASTX (doesn't apply to BLASTN)
by commits-noreply＠bitbucket.org 20 Nov '10

20 Nov '10

# HG changeset patch -- Bitbucket.org # Project galaxy-dist # URL http://bitbucket.org/galaxy/galaxy-dist/overview # User peterjc <p.j.a.cock(a)googlemail.com> # Date 1286293730 -3600 # Node ID dd7a3707f323bbf38689a24bfcb0b337c3494569 # Parent 1c8a5958c7481e53e862dbdf44d5367b6f3fc271 Add -matrix option to BLASTP, BLASTX, TBLASTN and TBLASTX (doesn't apply to BLASTN) --- a/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastp_wrapper.xml @@ -11,6 +11,7 @@ -task $blast_type -evalue $evalue_cutoff $adv_opts.filter_query + $adv_opts.matrix -out $output1 -outfmt $out_format -num_threads 8 @@ -56,10 +57,21 @@ </param><when value="basic"><param name="filter_query" type="hidden" value="" /> + <param name="matrix" type="hidden" value="" /></when><when value="advanced"><param name="filter_query" type="boolean" label="Filter out low complexity regions (with SEG)" truevalue="-seg yes" falsevalue="-seg no" checked="true" /> + <param name="matrix" type="select" label="Scoring matrix"> + <option value="-matrix BLOSUM62">BLOSUM62 (default)</option> + <option value="-matrix BLOSUM90">BLOSUM90</option> + <option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM50">BLOSUM50</option> + <option value="-matrix BLOSUM45">BLOSUM45</option> + <option value="-matrix PAM250">PAM250</option> + <option value="-matrix PAM70">PAM70</option> + <option value="-matrix PAM30">PAM30</option> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastx_wrapper.xml @@ -11,6 +11,7 @@ -evalue $evalue_cutoff $adv_opts.filter_query $adv_opts.strand + $adv_opts.matrix -out $output1 -outfmt $out_format -num_threads 8 @@ -53,6 +54,7 @@ <when value="basic"><param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /> + <param name="matrix" type="hidden" value="" /></when><when value="advanced"> @@ -62,6 +64,16 @@ <option value="-strand plus">Plus (forward)</option><option value="-strand minus">Minus (reverse complement)</option></param> + <param name="matrix" type="select" label="Scoring matrix"> + <option value="-matrix BLOSUM62">BLOSUM62 (default)</option> + <option value="-matrix BLOSUM90">BLOSUM90</option> + <option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM50">BLOSUM50</option> + <option value="-matrix BLOSUM45">BLOSUM45</option> + <option value="-matrix PAM250">PAM250</option> + <option value="-matrix PAM70">PAM70</option> + <option value="-matrix PAM30">PAM30</option> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_blastx_wrapper.xml @@ -11,6 +11,7 @@ -evalue $evalue_cutoff $adv_opts.filter_query $adv_opts.strand + $adv_opts.matrix -out $output1 -outfmt $out_format -num_threads 8 @@ -53,6 +54,7 @@ <when value="basic"><param name="filter_query" type="hidden" value="" /><param name="strand" type="hidden" value="" /> + <param name="matrix" type="hidden" value="" /></when><when value="advanced"> @@ -62,6 +64,16 @@ <option value="-strand plus">Plus (forward)</option><option value="-strand minus">Minus (reverse complement)</option></param> + <param name="matrix" type="select" label="Scoring matrix"> + <option value="-matrix BLOSUM62">BLOSUM62 (default)</option> + <option value="-matrix BLOSUM90">BLOSUM90</option> + <option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM50">BLOSUM50</option> + <option value="-matrix BLOSUM45">BLOSUM45</option> + <option value="-matrix PAM250">PAM250</option> + <option value="-matrix PAM70">PAM70</option> + <option value="-matrix PAM30">PAM30</option> + </param></when></conditional></inputs> --- a/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml +++ b/tools/ncbi_blast_plus/ncbi_tblastn_wrapper.xml @@ -10,6 +10,7 @@ #end if -evalue $evalue_cutoff $adv_opts.filter_query + $adv_opts.matrix -out $output1 -outfmt $out_format -num_threads 8 @@ -51,10 +52,21 @@ </param><when value="basic"><param name="filter_query" type="hidden" value="" /> + <param name="matrix" type="hidden" value="" /></when><when value="advanced"><param name="filter_query" type="boolean" label="Filter out low complexity regions (with SEG)" truevalue="-seg yes" falsevalue="-seg no" checked="true" /> + <param name="matrix" type="select" label="Scoring matrix"> + <option value="-matrix BLOSUM62">BLOSUM62 (default)</option> + <option value="-matrix BLOSUM90">BLOSUM90</option> + <option value="-matrix BLOSUM80">BLOSUM80</option> + <option value="-matrix BLOSUM50">BLOSUM50</option> + <option value="-matrix BLOSUM45">BLOSUM45</option> + <option value="-matrix PAM250">PAM250</option> + <option value="-matrix PAM70">PAM70</option> + <option value="-matrix PAM30">PAM30</option> + </param></when></conditional></inputs>

1 0