- galaxy-dev - lists.galaxyproject.org

[hg] galaxy 2833: Bug fix for adding a new folder template ( fix...
by Greg Von Kuster 06 Oct '09

06 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/40ab85150694 changeset: 2833:40ab85150694 user: Greg Von Kuster <greg(a)bx.psu.edu> date: Tue Oct 06 14:13:31 2009 -0400 description: Bug fix for adding a new folder template ( fixes # 193 ), more functioanl test coverage for folder templates, more code mering and cleanup in the library controllers, shortened the table buttons on the brose library grid and template. 8 file(s) affected in this change: lib/galaxy/web/controllers/library.py lib/galaxy/web/controllers/library_common.py templates/admin/library/browse_library.mako templates/admin/library/select_info_template.mako templates/library/browse_library.mako templates/library/select_info_template.mako test/base/twilltestcase.py test/functional/test_security_and_libraries.py diffs (389 lines): diff -r a7a7376cf8e9 -r 40ab85150694 lib/galaxy/web/controllers/library.py --- a/lib/galaxy/web/controllers/library.py Tue Oct 06 13:20:24 2009 -0400 +++ b/lib/galaxy/web/controllers/library.py Tue Oct 06 14:13:31 2009 -0400 @@ -70,7 +70,7 @@ trans.app.security_agent.permitted_actions.LIBRARY_MANAGE ] # The authorized_libraries dictionary looks like: { library : '1,2' }, library : '3' } # Its keys are the libraries that should be displayed for the current user and whose values are a - # string of comma-separated folder ids, of the associated folders the should NOT be displayed. + # string of comma-separated folder ids of the associated folders that should NOT be displayed. # The folders that should not be displayed may not be a complete list, but it is ultimately passed # to the browse_library() method and the browse_library.mako template to keep from re-checking the # same folders when the library is rendered. diff -r a7a7376cf8e9 -r 40ab85150694 lib/galaxy/web/controllers/library_common.py --- a/lib/galaxy/web/controllers/library_common.py Tue Oct 06 13:20:24 2009 -0400 +++ b/lib/galaxy/web/controllers/library_common.py Tue Oct 06 14:13:31 2009 -0400 @@ -211,7 +211,7 @@ messagetype='error' ) ) @web.expose def info_template( self, trans, cntrller, library_id, response_action='library', obj_id=None, folder_id=None, ldda_id=None, **kwd ): - # Only adding a new templAte to a library or folder is currently allowed. Editing an existing template is + # Only adding a new template to a library or folder is currently allowed. Editing an existing template is # a future enhancement. The response_action param is the name of the method to which this method will redirect # if a new template is being added to a library or folder. params = util.Params( kwd ) @@ -241,7 +241,6 @@ msg += "try again to add the information template to the %s." % library_item_desc trans.response.send_redirect( web.url_for( controller='forms', action='new', - new=True, msg=msg, messagetype='done' ) ) if params.get( 'add_info_template_button', False ): @@ -260,19 +259,17 @@ trans.response.send_redirect( web.url_for( controller=cntrller, action=response_action, obj_id=response_id, + library_id=library_id, msg=msg, message_type='done' ) ) - # TODO: handle this better - if cntrller == 'library_admin': - tmplt = '/admin/library/select_info_template.mako' - else: - tmplt = '/library/select_info_template.mako' - return trans.fill_template( tmplt, + return trans.fill_template( '/library/select_info_template.mako', + controller=cntrller, library_item_name=library_item.name, library_item_desc=library_item_desc, library_id=library_id, folder_id=folder_id, ldda_id=ldda_id, + obj_id=response_id, forms=forms, msg=msg, messagetype=messagetype ) diff -r a7a7376cf8e9 -r 40ab85150694 templates/admin/library/browse_library.mako --- a/templates/admin/library/browse_library.mako Tue Oct 06 13:20:24 2009 -0400 +++ b/templates/admin/library/browse_library.mako Tue Oct 06 14:13:31 2009 -0400 @@ -244,10 +244,10 @@ <ul class="manage-table-actions"> %if not deleted: <li> - <a class="action-button" href="${h.url_for( controller='library_admin', action='upload_library_dataset', library_id=library.id, folder_id=library.root_folder.id )}"><span>Add datasets to this data library</span></a> + <a class="action-button" href="${h.url_for( controller='library_admin', action='upload_library_dataset', library_id=library.id, folder_id=library.root_folder.id )}"><span>Add datasets</span></a> </li> <li> - <a class="action-button" href="${h.url_for( controller='library_admin', action='folder', new=True, obj_id=library.root_folder.id, library_id=library.id )}">Add a folder to this data library</a> + <a class="action-button" href="${h.url_for( controller='library_admin', action='folder', new=True, obj_id=library.root_folder.id, library_id=library.id )}">Add folder</a> </li> %endif </ul> diff -r a7a7376cf8e9 -r 40ab85150694 templates/admin/library/select_info_template.mako --- a/templates/admin/library/select_info_template.mako Tue Oct 06 13:20:24 2009 -0400 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,44 +0,0 @@ -<%inherit file="/base.mako"/> -<%namespace file="/message.mako" import="render_msg" /> - -<br/><br/> -<ul class="manage-table-actions"> - <li> - <a class="action-button" href="${h.url_for( controller='library_admin', action='browse_library', obj_id=library_id )}"><span>Browse this data library</span></a> - </li> -</ul> - -%if msg: - ${render_msg( msg, messagetype )} -%endif - -<div class="toolForm"> - <div class="toolFormTitle">Select a form on which to base the template for the ${library_item_desc} '${library_item_name}'</div> - <form name="new_info_template" action="${h.url_for( controller='library_common', action='info_template', cntrller='library_admin' )}" method="post" > - <div class="toolFormBody"> - <div class="form-row"> - <input type="hidden" name="library_id" value="${library_id}"/> - %if library_dataset_id: - <input type="hidden" name="library_dataset_id" value="${library_dataset_id}"/> - <input type="hidden" name="response_action" value="ldda_edit_info"/> - %elif folder_id: - <input type="hidden" name="folder_id" value="${folder_id}"/> - <input type="hidden" name="response_action" value="folder"/> - %elif ldda_id: - <input type="hidden" name="ldda_id" value="${ldda_id}"/> - <input type="hidden" name="response_action" value="ldda_edit_info"/> - %endif - <label>Template:</label> - <select name="form_id"> - %for form in forms: - <option value="${form.id}">${form.name}</option> - %endfor - </select> - </div> - <div style="clear: both"></div> - <div class="form-row"> - <input type="submit" name="add_info_template_button" value="Add template to ${library_item_desc}"/> - </div> - </div> - </form> -</div> diff -r a7a7376cf8e9 -r 40ab85150694 templates/library/browse_library.mako --- a/templates/library/browse_library.mako Tue Oct 06 13:20:24 2009 -0400 +++ b/templates/library/browse_library.mako Tue Oct 06 14:13:31 2009 -0400 @@ -215,6 +215,8 @@ if created_ldda_ids: created_ldda_ids = [ int( ldda_id ) for ldda_id in util.listify( created_ldda_ids ) ] can_add = trans.app.security_agent.can_add_library_item( user, roles, folder ) + if can_add: + info_association, inherited = folder.get_info_association( restrict=True ) can_modify = trans.app.security_agent.can_modify_library_item( user, roles, folder ) can_manage = trans.app.security_agent.can_manage_library_item( user, roles, folder ) my_row = None @@ -245,7 +247,7 @@ %else: <a class="action-button" href="${h.url_for( controller='library', action='folder', information=True, obj_id=folder.id, library_id=library_id )}">View this folder's information</a> %endif - %if can_add and forms and not folder.info_association: + %if can_add and not info_association: <a class="action-button" href="${h.url_for( controller='library_common', action='info_template', cntrller='library', library_id=library.id, response_action='folder', folder_id=folder.id )}">Add an information template to this folder</a> %endif %if can_manage: @@ -280,6 +282,8 @@ <% can_add = trans.app.security_agent.can_add_library_item( user, roles, library ) + if can_add: + info_association, inherited = library.get_info_association() can_modify = trans.app.security_agent.can_modify_library_item( user, roles, library ) can_manage = trans.app.security_agent.can_manage_library_item( user, roles, library ) %> @@ -287,22 +291,22 @@ <ul class="manage-table-actions"> %if can_add: <li> - <a class="action-button" href="${h.url_for( controller='library', action='upload_library_dataset', library_id=library.id, folder_id=library.root_folder.id )}"><span>Add datasets to this data library</span></a> + <a class="action-button" href="${h.url_for( controller='library', action='upload_library_dataset', library_id=library.id, folder_id=library.root_folder.id )}"><span>Add datasets</span></a> </li> <li> - <a class="action-button" href="${h.url_for( controller='library', action='folder', new=True, obj_id=library.root_folder.id, library_id=library.id )}">Add a folder to this data library</a> + <a class="action-button" href="${h.url_for( controller='library', action='folder', new=True, obj_id=library.root_folder.id, library_id=library.id )}">Add folder</a> </li> %endif %if can_modify: - <li><a class="action-button" href="${h.url_for( controller='library', action='library', information=True, obj_id=library.id )}">Edit this data library's information</a></li> + <li><a class="action-button" href="${h.url_for( controller='library', action='library', information=True, obj_id=library.id )}">Edit information</a></li> %else: - <li><a class="action-button" href="${h.url_for( controller='library', action='library', information=True, obj_id=library.id )}">View this data library's information</a></li> + <li><a class="action-button" href="${h.url_for( controller='library', action='library', information=True, obj_id=library.id )}">View information</a></li> %endif - %if can_add and forms and not library.info_association: - <a class="action-button" href="${h.url_for( controller='library_common', action='info_template', cntrller='library', library_id=library.id, response_action='browse_library' )}">Add an information template to this data library</a> + %if can_add and not info_association: + <a class="action-button" href="${h.url_for( controller='library_common', action='info_template', cntrller='library', library_id=library.id, response_action='browse_library' )}">Add template</a> %endif %if can_manage: - <li><a class="action-button" href="${h.url_for( controller='library', action='library', permissions=True, obj_id=library.id )}">Edit this data library's permissions</a></li> + <li><a class="action-button" href="${h.url_for( controller='library', action='library', permissions=True, obj_id=library.id )}">Edit permissions</a></li> %endif </ul> diff -r a7a7376cf8e9 -r 40ab85150694 templates/library/select_info_template.mako --- a/templates/library/select_info_template.mako Tue Oct 06 13:20:24 2009 -0400 +++ b/templates/library/select_info_template.mako Tue Oct 06 14:13:31 2009 -0400 @@ -4,7 +4,7 @@ <br/><br/> <ul class="manage-table-actions"> <li> - <a class="action-button" href="${h.url_for( controller='library', action='browse_library', obj_id=library_id )}"><span>Browse this data library</span></a> + <a class="action-button" href="${h.url_for( controller=controller, action='browse_library', obj_id=library_id )}"><span>Browse this data library</span></a> </li> </ul> @@ -14,7 +14,7 @@ <div class="toolForm"> <div class="toolFormTitle">Select a form on which to base the template for the ${library_item_desc} '${library_item_name}'</div> - <form name="new_info_template" action="${h.url_for( controller='library_common', action='info_template', cntrller='library' )}" method="post" > + <form name="new_info_template" action="${h.url_for( controller='library_common', action='info_template', cntrller=controller )}" method="post" > <div class="toolFormBody"> <div class="form-row"> <input type="hidden" name="library_id" value="${library_id}"/> diff -r a7a7376cf8e9 -r 40ab85150694 test/base/twilltestcase.py --- a/test/base/twilltestcase.py Tue Oct 06 13:20:24 2009 -0400 +++ b/test/base/twilltestcase.py Tue Oct 06 14:13:31 2009 -0400 @@ -1171,8 +1171,8 @@ check_str = "Library '%s' has been renamed to '%s'" % ( old_name, name ) self.check_page_for_string( check_str ) self.home() - def add_library_info_template( self, cntrller, library_id, library_name, form_id, form_name ): - """Add a new info template to a library""" + def add_library_info_template( self, cntrller, library_id, form_id, form_name ): + """Add a new info template to a library item""" self.home() url = "%s/library_common/info_template?cntrller=%s&library_id=%s&response_action='browse_library'" % ( self.url, cntrller, library_id ) self.visit_url( url ) @@ -1209,25 +1209,16 @@ check_str = "Information template '%s' has been updated" % name self.check_page_for_string( check_str ) self.home() - def add_folder_info_template( self, controller, cntrller, library_id, library_name, folder_id, folder_name, num_fields='2', - name='Folder Template 1', ele_name_0='Fu', ele_help_0='', ele_name_1='Bar', ele_help_1='' ): + def add_folder_info_template( self, cntrller, library_id, folder_id, form_id, form_name ): """Add a new info template to a folder""" self.home() - url = "%s/%s/info_template?cntrller=%s&library_id=%s&response_action='folder'&create_info_template_button=Go" % \ - ( self.url, controller, cntrller, library_id, folder_id ) - self.home() + url = "%s/library_common/info_template?cntrller=%s&library_id=%s&folder_id=%s&response_action='folder'" % \ + ( self.url, cntrller, library_id, folder_id ) self.visit_url( url ) - check_str = "Create a new information template for folder '%s'" % folder_name - self.check_page_for_string ( check_str ) + self.check_page_for_string ( "Select a form on which to base the template" ) tc.fv( '1', 'library_id', library_id ) - tc.fv( '1', 'folder_id', folder_id ) - tc.fv( '1', 'set_num_fields', num_fields ) - tc.fv( '1', 'name', name ) - tc.fv( '1', 'new_element_name_0', ele_name_0 ) - tc.fv( '1', 'new_element_description_0', ele_help_0.replace( '+', ' ' ) ) - tc.fv( '1', 'new_element_name_1', ele_name_1 ) - tc.fv( '1', 'new_element_description_1', ele_help_1.replace( '+', ' ' ) ) - tc.submit( 'new_info_template_button' ) + tc.submit( 'add_info_template_button' ) + self.check_page_for_string = 'An information template based on the form "%s" has been added to this folder.' % form_name self.home() def add_folder( self, controller, library_id, folder_id, name='Folder One', description='This is Folder One' ): """Create a new folder""" @@ -1239,17 +1230,26 @@ tc.fv( "1", "description", description ) # form field 2 is the field named description... tc.submit( "new_folder_button" ) self.home() - def edit_folder_info( self, controller, folder_id, library_id, name, new_name, description ): + def edit_folder_info( self, controller, folder_id, library_id, name, new_name, description, contents='', field_name='' ): """Add information to a library using an existing template with 2 elements""" self.home() self.visit_url( "%s/%s/folder?obj_id=%s&library_id=%s&information=True" % \ ( self.url, controller, folder_id, library_id) ) - self.check_page_for_string( "Edit folder name and description" ) + # Twill cannot handle the following call for some reason - it's buggy + # self.check_page_for_string( "Edit folder name and description" ) tc.fv( '1', "name", new_name ) tc.fv( '1', "description", description ) tc.submit( 'rename_folder_button' ) - check_str = "Folder '%s' has been renamed to '%s'" % ( name, new_name ) - self.check_page_for_string( check_str ) + # Twill cannot handle the following call for some reason - it's buggy + # check_str = "Folder '%s' has been renamed to '%s'" % ( name, new_name ) + # self.check_page_for_string( check_str ) + if contents and field_name: + # We have an information template associated with the folder, so + # there are 2 forms on this page and the template is the 2nd form + tc.fv( '2', field_name, contents ) + tc.submit( 'edit_info_button' ) + # Twill cannot handle the following call for some reason - it's buggy + # self.check_page_for_string( 'The information has been updated.' ) self.home() def rename_folder( self, library_id, folder_id, old_name, name='Folder One Renamed', description='This is Folder One Re-described' ): """Rename a Folder""" diff -r a7a7376cf8e9 -r 40ab85150694 test/functional/test_security_and_libraries.py --- a/test/functional/test_security_and_libraries.py Tue Oct 06 13:20:24 2009 -0400 +++ b/test/functional/test_security_and_libraries.py Tue Oct 06 14:13:31 2009 -0400 @@ -497,7 +497,6 @@ template_name = 'Library Template 1' self.add_library_info_template( 'library_admin', str( library_one.id ), - library_one.name, str( form_one.id ), form_one.name ) # Make sure the template fields are displayed on the library information page @@ -1622,6 +1621,7 @@ self.visit_page( 'library_admin/browse_libraries' ) self.check_page_for_string( name ) self.check_page_for_string( description ) + global library_three library_three = galaxy.model.Library.filter( and_( galaxy.model.Library.table.c.name==name, galaxy.model.Library.table.c.description==description, galaxy.model.Library.table.c.deleted==False ) ).first() @@ -1658,20 +1658,41 @@ description = "This is the root folder's Folder X" self.add_folder( 'library', str( library_three.id ), - str( library_three.root_folder.id ), + str( library_three.root_folder.id ), name=name, description=description ) + global folder_x folder_x = galaxy.model.LibraryFolder.filter( and_( galaxy.model.LibraryFolder.table.c.parent_id==library_three.root_folder.id, galaxy.model.LibraryFolder.table.c.name==name, galaxy.model.LibraryFolder.table.c.description==description ) ).first() + # Add an information template to the folder + template_name = 'Folder Template 1' + self.add_folder_info_template( 'library', + str( library_one.id ), + str( folder_x.id ), + str( form_one.id ), + form_one.name ) # Modify the folder's information + contents = '%s folder contents' % form_one_field_label new_name = "Root Folder's Folder Y" new_description = "This is the root folder's Folder Y" - self.edit_folder_info( 'library', str( folder_x.id ), str( library_three.id ), name, new_name, new_description ) + self.edit_folder_info( 'library', + str( folder_x.id ), + str( library_three.id ), + name, + new_name, + new_description, + contents=contents, + field_name=form_one_field_name ) + # Twill barfs when self.check_page_for_string() is called after dealing with an information template, + # the exception is: TypeError: 'str' object is not callable + # the work-around it to end this method so any calls are in the next method. + def test_265_template_features_and_permissions( self ): + """Test library template and more permissions behavior from the Data Libraries view""" + # Logged in as regular_user2 folder_x.refresh() # Add a dataset to the folder - name2 = "Folder Y subfolder" - description2 = "Folder Y subfolder description" + message = 'Testing adding 2.bed to Library Three root folder' self.add_library_dataset( 'library', '2.bed', str( library_three.id ), @@ -1681,21 +1702,41 @@ dbkey='hg18', message=message.replace( ' ', '+' ), root=False ) + global ldda_x ldda_x = galaxy.model.LibraryDatasetDatasetAssociation.query() \ .order_by( desc( galaxy.model.LibraryDatasetDatasetAssociation.table.c.create_time ) ).first() assert ldda_x is not None, 'Problem retrieving ldda_x from the database' - # Log in as regular_user1 + # Add an information template to the library + template_name = 'Library Template 3' + self.add_library_info_template( 'library', + str( library_three.id ), + str( form_one.id ), + form_one.name ) + # Add information to the library using the template + contents = '%s library contents' % form_one_field_label + self.visit_url( '%s/library/library?obj_id=%s&information=True' % ( self.url, str( library_three.id ) ) ) + # There are 2 forms on this page and the template is the 2nd form + tc.fv( '2', form_one_field_name, contents ) + tc.submit( 'edit_info_button' ) + # For some reason, the following check: + # self.check_page_for_string ( 'The information has been updated.' ) + # ...throws the following exception - I have not idea why! + # TypeError: 'str' object is not callable + # The work-around is to not make ANY self.check_page_for_string() calls until the next method + def test_270_permissions_as_different_regular_user( self ): + """Test library template and more permissions behavior from the Data Libraries view as a different user""" + # Log in as regular_user2 self.logout() self.login( email=regular_user1.email ) self.visit_url( '%s/library/browse_library?obj_id=%s' % ( self.url, str( library_three.id ) ) ) self.check_page_for_string( ldda_x.name ) + def test_275_reset_data_for_later_test_runs( self ): + """Reseting data to enable later test runs to pass""" + # Logged in as regular_user2 self.logout() self.login( email=admin_user.email ) self.delete_library_item( str( library_three.id ), str( library_three.id ), library_three.name, library_item_type='library' ) self.purge_library( str( library_three.id ), library_three.name ) - def test_265_reset_data_for_later_test_runs( self ): - """Reseting data to enable later test runs to pass""" - # Logged in as admin_user ################## # Eliminate all non-private roles ##################

1 0

[hg] galaxy 2827: Improved paging UI for history grid and added ...
by Greg Von Kuster 06 Oct '09

06 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/f648d6dec544 changeset: 2827:f648d6dec544 user: jeremy goecks <jeremy.goecks(a)emory.edu> date: Mon Oct 05 15:07:20 2009 -0400 description: Improved paging UI for history grid and added keyword 'all' for page varible. Specifying 'page=all' in URL string shows all items on single page. 3 file(s) affected in this change: lib/galaxy/web/controllers/history.py lib/galaxy/web/framework/helpers/grids.py templates/history/grid.mako diffs (148 lines): diff -r e93da066b847 -r f648d6dec544 lib/galaxy/web/controllers/history.py --- a/lib/galaxy/web/controllers/history.py Mon Oct 05 10:35:39 2009 -0400 +++ b/lib/galaxy/web/controllers/history.py Mon Oct 05 15:07:20 2009 -0400 @@ -125,6 +125,7 @@ grids.GridColumnFilter( "All", args=dict( deleted='All' ) ), ] default_filter = dict( deleted="False", tags="All" ) + num_rows_per_page = 50 preserve_state = False use_paging = True def get_current_item( self, trans ): diff -r e93da066b847 -r f648d6dec544 lib/galaxy/web/framework/helpers/grids.py --- a/lib/galaxy/web/framework/helpers/grids.py Mon Oct 05 10:35:39 2009 -0400 +++ b/lib/galaxy/web/framework/helpers/grids.py Mon Oct 05 15:07:20 2009 -0400 @@ -25,7 +25,7 @@ preserve_state = False use_paging = False - num_rows_per_page = 10 + num_rows_per_page = 25 # Set preference names. cur_filter_pref_name = ".filter" @@ -123,15 +123,23 @@ # Process page number. if self.use_paging: if 'page' in kwargs: - page_num = int( kwargs['page'] ) + if kwargs['page'] == 'all': + page_num = 0 + else: + page_num = int( kwargs['page'] ) else: page_num = 1 - # Before modifying query, get the total number of rows that query returns so that the total number of pages can - # be computed. - total_num_rows = query.count() - query = query.limit( self.num_rows_per_page ).offset( ( page_num-1 ) * self.num_rows_per_page ) - num_pages = int ( math.ceil( float( total_num_rows ) / self.num_rows_per_page ) ) + if page_num == 0: + # Show all rows in page. + total_num_rows = query.count() + num_pages = 1 + else: + # Show a limited number of rows. Before modifying query, get the total number of rows that query + # returns so that the total number of pages can be computed. + total_num_rows = query.count() + query = query.limit( self.num_rows_per_page ).offset( ( page_num-1 ) * self.num_rows_per_page ) + num_pages = int ( math.ceil( float( total_num_rows ) / self.num_rows_per_page ) ) else: # Defaults. page_num = 1 diff -r e93da066b847 -r f648d6dec544 templates/history/grid.mako --- a/templates/history/grid.mako Mon Oct 05 10:35:39 2009 -0400 +++ b/templates/history/grid.mako Mon Oct 05 15:07:20 2009 -0400 @@ -92,9 +92,8 @@ t.autocomplete("${h.url_for( controller='tag', action='tag_autocomplete_data', item_class='History' )}", autocomplete_options); - //t.addClass("tag-input"); - - return t; + + $("#page-select").change(navigate_to_page); }); ## Can this be moved into base.mako? %if refresh_frames: @@ -141,6 +140,18 @@ %> var url_base = "${url( url_args )}"; var url = url_base.replace("TAGNAME", tag_name); + self.location = url; + } + + // + // Initiate navigation when user selects a page to view. + // + function navigate_to_page() + { + page_num = $(this).val(); + <% url_args = {"page" : "PAGE"} %> + var url_base = "${url( url_args )}"; + var url = url_base.replace("PAGE", page_num); self.location = url; } @@ -207,6 +218,7 @@ </form> </div> <form name="history_actions" action="${url()}" method="post" > + <input type="hidden" name="page" value="${cur_page_num}"> <table class="grid"> <thead> <tr> @@ -300,19 +312,42 @@ %endfor </tbody> <tfoot> + ## Row for navigating among pages. %if num_pages > 1: <tr> <td></td> - <td colspan="100" style="text-align: right"> - Page: - %for page_index in range(1, num_pages + 1): - %if page_index == cur_page_num: - <span style="font-style: italic">${page_index}</span> - %else: - <% args = { "page" : page_index } %> - <span><a href="${url( args )}">${page_index}</a></span> - %endif - %endfor + <td colspan="100"> + Page ${cur_page_num} of ${num_pages} +     Go to: + ## Next page link. + %if cur_page_num != num_pages: + <% args = { "page" : cur_page_num+1 } %> + <span><a href="${url( args )}">Next</a></span> + %endif + ## Previous page link. + %if cur_page_num != 1: + <span>|</span> + <% args = { "page" : cur_page_num-1 } %> + <span><a href="${url( args )}">Previous</a></span> + %endif + ## Go to page select box. + <span>| Select:</span> + <select id="page-select" onchange="navigate_to_page()"> + <option value=""></option> + %for page_index in range(1, num_pages + 1): + %if page_index == cur_page_num: + continue + %else: + <% args = { "page" : page_index } %> + <option value='${page_index}'>Page ${page_index}</option> + %endif + %endfor + </select> + ## Show all link. + <% args = { "page" : "all" } %> + <span>| <a href="${url( args )}">Show all histories on one page</a></span> + + </td> </tr> %endif

1 0

[hg] galaxy 2828: Bug fixed in \"compare two queries\" tool. Spe...
by Greg Von Kuster 06 Oct '09

06 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/ca273cc16b60 changeset: 2828:ca273cc16b60 user: guru date: Mon Oct 05 16:33:32 2009 -0400 description: Bug fixed in \"compare two queries\" tool. Specified tab as delimiter for sorting and joining. 2 file(s) affected in this change: tools/filters/compare.xml tools/filters/joinWrapper.py diffs (35 lines): diff -r f648d6dec544 -r ca273cc16b60 tools/filters/compare.xml --- a/tools/filters/compare.xml Mon Oct 05 15:07:20 2009 -0400 +++ b/tools/filters/compare.xml Mon Oct 05 16:33:32 2009 -0400 @@ -1,4 +1,4 @@ -<tool id="comp1" name="Compare two Queries"> +<tool id="comp1" name="Compare two Queries" version="1.0.1"> <description>to find common or distinct rows</description> <command interpreter="python">joinWrapper.py $input1 $input2 $field1 $field2 $mode $out_file1</command> <inputs> diff -r f648d6dec544 -r ca273cc16b60 tools/filters/joinWrapper.py --- a/tools/filters/joinWrapper.py Mon Oct 05 15:07:20 2009 -0400 +++ b/tools/filters/joinWrapper.py Mon Oct 05 16:33:32 2009 -0400 @@ -22,8 +22,8 @@ try: #Sort the two files based on specified fields - os.system("sort -k %d -o %s %s" %(field1, tmpfile1.name, infile1)) - os.system("sort -k %d -o %s %s" %(field2, tmpfile2.name, infile2)) + os.system("sort -t $'\t' -k %d -o %s %s" %(field1, tmpfile1.name, infile1)) + os.system("sort -t $'\t' -k %d -o %s %s" %(field2, tmpfile2.name, infile2)) except Exception, exc: stop_err( 'Initialization error -> %s' %str(exc) ) @@ -40,9 +40,9 @@ break if mode == "V": - cmdline = 'join -v 1 -o %s -1 %d -2 %d %s %s | tr " " "\t" > %s' %(option, field1, field2, tmpfile1.name, tmpfile2.name, outfile) + cmdline = "join -t $'\t' -v 1 -o %s -1 %d -2 %d %s %s > %s" %(option, field1, field2, tmpfile1.name, tmpfile2.name, outfile) else: - cmdline = 'join -o %s -1 %d -2 %d %s %s | tr " " "\t" > %s' %(option, field1, field2, tmpfile1.name, tmpfile2.name, outfile) + cmdline = "join -t $'\t' -o %s -1 %d -2 %d %s %s > %s" %(option, field1, field2, tmpfile1.name, tmpfile2.name, outfile) try: os.system(cmdline)

1 0

[hg] galaxy 2826: Several small changes to Samtools pileup tool ...
by Greg Von Kuster 06 Oct '09

06 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/e93da066b847 changeset: 2826:e93da066b847 user: Kelly Vincent <kpvincent(a)bx.psu.edu> date: Mon Oct 05 10:35:39 2009 -0400 description: Several small changes to Samtools pileup tool to get it to work with user-supplied reference genome 1 file(s) affected in this change: tools/samtools/sam_pileup.py diffs (39 lines): diff -r a60c55fb0d76 -r e93da066b847 tools/samtools/sam_pileup.py --- a/tools/samtools/sam_pileup.py Sun Oct 04 10:55:43 2009 -0400 +++ b/tools/samtools/sam_pileup.py Mon Oct 05 10:35:39 2009 -0400 @@ -68,14 +68,16 @@ stop_err( "No sequences are available for '%s', request them by reporting this error." % options.dbkey ) cmd3 = cmd3 % (opts, seq_path, tmpf0bam, options.output1) elif options.ref == 'history': - cmd1 = 'cp %s %s; cp %s.fai %s' % (options.ownFile, tmpf1.name, options.ownFile, tmpf1fai) + cmd1 = 'cp %s %s; samtools faidx %s' % (options.ownFile, tmpf1.name, tmpf1.name) cmd3 = cmd3 % (opts, tmpf1.name, tmpf0bam, options.output1) # index reference if necessary if cmd1: try: os.system(cmd1) + if options.ref == 'history' and not os.path.exists( tmpf1fai ): + stop_err( "Problem creating index file from history item." ) except Exception, eq: - stop_err('Error moving reference sequence\n' + str(eq)) + stop_err('Error handling reference sequence\n' + str(eq)) # copy bam index to working directory try: os.system(cmd2) @@ -85,7 +87,7 @@ try: os.system(cmd3) except Exception, eq: - stop_err('Error running SAMtools merge tool\n' + str(eq)) + stop_err('Error running SAMtools pileup tool\n' + str(eq)) # clean up temp files tmpf1.close() tmpf0.close() @@ -94,6 +96,6 @@ if os.path.exists(tmpf0bambai): os.remove(tmpf0bambai) if os.path.exists(tmpf1fai): - os.remove(tmpf0bambai) + os.remove(tmpf1fai) if __name__ == "__main__" : __main__()

1 0

Problem with sqlalchemy / python versions
by Assaf Gordon 05 Oct '09

05 Oct '09

Hello, After pulling the latest version, I've encountered a problem with importing sqlalchemy. (I haven't upgraded in a long time, so I can't be sure which changeset introduced this issue). The symptom is that running the upload.py python script throws the following exception: ----------------------- Traceback (most recent call last): File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/tools/data_source/upload.py", line 10, in import galaxy.model File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/model/__init__.py", line 13, in import galaxy.datatypes.registry File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/datatypes/registry.py", line 6, in import data, tabular, interval, images, sequence, qualityscore, genetics, xml, coverage, tracks, chrominfo File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/datatypes/data.py", line 6, in import metadata File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/datatypes/metadata.py", line 5, in from galaxy.web import form_builder File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/web/__init__.py", line 5, in from framework import expose, json, require_login, require_admin, url_for, error, form, FormBuilder File "/home/gordon/projects/galaxy_servers/galaxy_fresh_copy/lib/galaxy/web/framework/__init__.py", line 31, in from sqlalchemy import and_ ImportError: No module named sqlalchemy ------------------------ It happens in the following scenario: 1. clone a fresh copy of galaxy 2. run "sh setup.sh" 3. run "sh run.sh" 4. upload a data file to galaxy. 5. The file is completely uploaded (the purple rectangle step) 6. galaxy executes "upload.py" - then the problem happens. I can also reproduce it quickly by doing: 1. clone a fresh copy of galaxy 2. run "sh setup.sh" 3. remove the "-ES" parameters from "run.sh" 4. run "sh run.sh" In which case the following exception is thrown: gordon@tango:~/temp/galaxy$ sh run.sh Traceback (most recent call last): File "./scripts/paster.py", line 27, in <module> command.run() File "build/bdist.solaris-2.11-i86pc/egg/paste/script/command.py", line 78, in run File "build/bdist.solaris-2.11-i86pc/egg/paste/script/command.py", line 117, in invoke File "build/bdist.solaris-2.11-i86pc/egg/paste/script/command.py", line 212, in run File "build/bdist.solaris-2.11-i86pc/egg/paste/script/serve.py", line 227, in command File "build/bdist.solaris-2.11-i86pc/egg/paste/script/serve.py", line 250, in loadapp File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 193, in loadapp File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 213, in loadobj File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 237, in loadcontext File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 267, in _loadconfig File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 397, in get_context File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 439, in _context_from_explicit File "build/bdist.solaris-2.11-i86pc/egg/paste/deploy/loadwsgi.py", line 18, in import_string File "/home/gordon/temp/galaxy/lib/pkg_resources.py", line 1912, in load entry = __import__(self.module_name, globals(),globals(), ['__name__']) File "/home/gordon/temp/galaxy/lib/galaxy/web/__init__.py", line 5, in <module> from framework import expose, json, require_login, require_admin, url_for, error, form, FormBuilder File "/home/gordon/temp/galaxy/lib/galaxy/web/framework/__init__.py", line 31, in <module> from sqlalchemy import and_ ImportError: No module named sqlalchemy My guess is that this is a mix-up of using my site-wide python modules (without "-ES") and Galaxy's eggs (with "-ES"). But I don't know how to solve it. Also, there's the issue of executing python from inside galaxy: On my development station, python2.5 is the default and all is well. My production server is CentOS-5.3 - in which the default python is 2.4 (I had to change 'run.sh' to run "python2.5"). On an Ubuntu machine, the problem is reversed: Ubuntu switched to python2.6 (since 9.04) - so running just "python" runs 2.6. So far I (wrongly) assumed I only needed to change the shell scripts (run.sh, setup.sh, manage_db.sh) to use a fixed python version. But if galaxy runs python internally (other than tools written in python), then maybe a better solution is needed. Any help from a python guru will be greatly appreciated - so far I can't run the upgraded version (and can't really go back since I've upgrade the DB to version 21). Thanks! gordon. P.S. I'm running Debian 5.0, with the following python (and site-wide sqlalchemy) $ python Python 2.5.2 (r252:60911, Jan 4 2009, 21:59:32) [GCC 4.3.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import sqlalchemy >>> sqlalchemy.__version__ '0.4.7p1' >>>

2 2

Library dataset upload
by SHAUN WEBB 05 Oct '09

05 Oct '09

Hi. In our local install of Galaxy there is a small change to the code that allows upload of novoindex binary files (from the novoalign program) in a similar fashion to ab1 and scf files. This works fine with the data upload tool. There have been multiple changes to the library dataset upload methods in recent releases and I have lost track of which files are responsible for library dataset upload and checking these binary file types. Could someone please outline how this differs to the normal upload process and which which scripts are used. Many thanks Shaun Webb -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.

2 1

[hg] galaxy 2825: Correct fix for cloning a history - resolves p...
by Greg Von Kuster 04 Oct '09

04 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/a60c55fb0d76 changeset: 2825:a60c55fb0d76 user: Greg Von Kuster <greg(a)bx.psu.edu> date: Sun Oct 04 10:55:43 2009 -0400 description: Correct fix for cloning a history - resolves problem with built-in id reserved word. 1 file(s) affected in this change: lib/galaxy/web/controllers/history.py diffs (12 lines): diff -r d97f4e86be45 -r a60c55fb0d76 lib/galaxy/web/controllers/history.py --- a/lib/galaxy/web/controllers/history.py Fri Oct 02 11:02:14 2009 -0400 +++ b/lib/galaxy/web/controllers/history.py Sun Oct 04 10:55:43 2009 -0400 @@ -322,7 +322,7 @@ return self.shared_list_grid( trans, status='error', message=message, **kwargs ) # When cloning shared histories, only copy active datasets new_kwargs = { 'clone_choice' : 'active' } - return self.clone( trans, id, **new_kwargs ) + return self.clone( trans, ids, **new_kwargs ) elif operation == 'unshare': if not ids: message = "Select a history to unshare"

1 0

Ease-of-Use with galaxy and workflows (long rant)
by Assaf Gordon 04 Oct '09

04 Oct '09

Hello, I've recently tutored a genomics course, and part of the exercise in that course was to annotated short-reads libraries, and compare the number of exons/introns/UTRs/intergenic reads and base-pairs (the exact details are irrelevant). Galaxy seemed like the perfect tool for the exercise, and indeed was used for deriving the answers. However, as the students (and myself) used galaxy, some usability issues surfaced. Here's the problem set (some details omitted for brevity): Given three libraries of long and short RNAs, what is the number of reads (and base-pairs) that overlap annotated coding-exons (same strand and opposite strand), introns, 3'UTRs and intergenic regions. The libraries were given as BED files (already mapped to hg18). Ostensibly, it should be easy and straight forward to do this in Galaxy: 1. upload a library BED file 2. download a gene table from UCSC 3. Use "Extract Features" to extract exons/introns/UTR3 4. Use "Filter" to separate negative/positive genes and intervals 5. Intersect above datasets 6. use "Base Coverage" to count covered base-pairs. For the first library, the above process is fine. It takes longer if you've never used Galaxy, but that's understandable. One annoyance is that the labels of the datasets are not useful ("Intersect on data 12 and data 4"). If you're very organized, immediately after running each tool you rename the dataset to something meaningful. It's annoying, because you waste more time renaming and organizing you datasets than actually running tools. It took me no less than 30 minutes to run everything, rename and organize it (and I'm pretty good with Galaxy...). The real problem is with the other two libraries: I already know exactly what needs to be done - so doing it manually will be very frustrating. But, constructing a workflow from the current history is not as useful as it first seems. First issue (minor but annoying): When I clicked "Extract Workflow", galaxy did a perfect job of reconstructing all my steps. The workflow takes two input datasets, and produces many many others. The only problem: The two datasets (one - my library, the other - UCSC's Gene track) are indistinguishable in the workflow editor. which one is which ? There's the very useful "name" attribute to each input dataset, but it is not set... The only way to understand which one is which is to follow the workflow and see what's the next tool that's connected. A novice galaxy user might not even notice this issue - and might mix-up the two input datasets. A possible work-around (in the "extract workflow step") is to name each input dataset by the label of the dataset in the history (something like "Input data, based on UCSC KnownGenes dataset"). Second issue: I have extracted the workflow and used it on the other two libraries. But the generated datasets - oh boy. Making sense out of them is a real pain. I have uploaded the library, imported the UCSC KnownGene track, and executed the workflow. Take a look at the following history: http://main.g2.bx.psu.edu/history/imp?id=93de35e1ee121686 . Can you tell me which datasets answers the question of how many of my reads intersect introns ? intergenic regions ? same-strand exons ? (13, 15 and 22, respectively). Using the workflow and trying to understand which dataset is which can take almost as long as just running everything from scratch without a workflow. Third issue: I personally created this workflow six days ago, by extracting it from a history that I've made. Looking at it now, I have no way of adding/changing/updating it. It's almost "write once - read never". http://main.g2.bx.psu.edu/workflow/imp?id=6e55935a2b1f3d59 I will need to carefully trace each chain of datasets and tools to understand it - that's really annoying (I realize nobody cares about my annoyance level. but in practice it means I won't use it and won't share it with others - it's not useful). I don't have a good solution (this is rant, not a bugfix...), but I think that as galaxy goes into the Next-Gen sequencing arena, this situation will become more common and problematic. This kind of basic analysis (taking a library and annotating it) is a very standard procedure - in our lab it is done almost automatically on every next-gen sequenced library. To do it in Galaxy, the process needs to be much simpler... A small improvement would be to add two description labels for each tool in the workflow: one (detailed) will be shown inside the workflow editor, and the other to use a output label for the generated dataset. Thanks for reading so far, gordon.

1 0

[hg] galaxy 2824: merge
by Nate Coraor 02 Oct '09

02 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/d97f4e86be45 changeset: 2824:d97f4e86be45 user: Anton Nekrutenko <anton(a)bx.psu.edu> date: Fri Oct 02 11:02:14 2009 -0400 description: merge 0 file(s) affected in this change: diffs (39 lines): diff -r 2c0c81150dbd -r d97f4e86be45 tools/sr_mapping/bowtie_wrapper_code.py --- a/tools/sr_mapping/bowtie_wrapper_code.py Fri Oct 02 11:00:30 2009 -0400 +++ b/tools/sr_mapping/bowtie_wrapper_code.py Fri Oct 02 11:02:14 2009 -0400 @@ -3,13 +3,14 @@ def exec_before_job(app, inp_data, out_data, param_dict, tool): try: refFile = param_dict['refGenomeSource']['indices'].value - dbkey = os.path.split(refFile)[1].split('.')[0] - # deal with the one odd case - if dbkey.find('chrM') >= 0: - dbkey = 'equCab2' - out_data['output'].set_dbkey(dbkey) except: try: refFile = param_dict['refGenomeSource']['ownFile'].dbkey except: - out_data['output'].set_dbkey('?') + out_data['output'].set_dbkey('?') + return + dbkey = os.path.split(refFile)[1].split('.')[0] + # deal with the one odd case + if dbkey.find('chrM') >= 0: + dbkey = 'equCab2' + out_data['output'].set_dbkey(dbkey) diff -r 2c0c81150dbd -r d97f4e86be45 tools/sr_mapping/bwa_wrapper_code.py --- a/tools/sr_mapping/bwa_wrapper_code.py Fri Oct 02 11:00:30 2009 -0400 +++ b/tools/sr_mapping/bwa_wrapper_code.py Fri Oct 02 11:02:14 2009 -0400 @@ -3,9 +3,10 @@ def exec_before_job(app, inp_data, out_data, param_dict, tool): try: refFile = param_dict['solidOrSolexa']['solidRefGenomeSource']['indices'].value - out_data['output'].set_dbkey(os.path.split(refFile)[1].split('.')[0]) except: try: refFile = param_dict['solidOrSolexa']['solidRefGenomeSource']['ownFile'].dbkey except: out_data['output'].set_dbkey('?') + return + out_data['output'].set_dbkey(os.path.split(refFile)[1].split('.')[0])

1 0

[hg] galaxy 2822: fix for trimmer interface
by Nate Coraor 02 Oct '09

02 Oct '09

details: http://www.bx.psu.edu/hg/galaxy/rev/65f28c1f1226 changeset: 2822:65f28c1f1226 user: Anton Nekrutenko <anton(a)bx.psu.edu> date: Fri Oct 02 10:55:21 2009 -0400 description: fix for trimmer interface 1 file(s) affected in this change: tools/filters/trimmer.xml diffs (13 lines): diff -r 6eb4f3017fbe -r 65f28c1f1226 tools/filters/trimmer.xml --- a/tools/filters/trimmer.xml Thu Oct 01 09:09:40 2009 -0400 +++ b/tools/filters/trimmer.xml Fri Oct 02 10:55:21 2009 -0400 @@ -9,8 +9,8 @@ <param name="start" type="integer" size="10" value="1" label="Trim from the beginning to this position" help="1 = do not trim the beginning"/> <param name="end" type="integer" size="10" value="0" label="Remove everything from this position to the end" help="0 = do not trim the end"/> <param name="fastq" type="select" label="Is input dataset in fastq format?" help="If set to YES, the tool will not trim evenly numbered lines (0, 2, 4, etc...)"> + <option selected="true" value="">No</option> <option value="-q">Yes</option> - <option value="">No</option> </param> <param name="ignore" type="select" display="checkboxes" multiple="True" label="Ignore lines beginning with these characters" help="lines beginning with these are not trimmed"> <option value="62">></option>

1 0